The Beaverhouse/Litestone Official Discord Server

V A H K I T I 17-Feb-20 01:34 PM

Memes

HA

BEAT YA TO IT THIS TIME

@The Cap'm (Reese)

The Cap'm (Reese) 17-Feb-20 01:35 PM

~~Sequels are never as good as the original~~

~~...generally~~

V A H K I T I 17-Feb-20 01:35 PM

:v

Ondrik🅱 (Ondrej) 17-Feb-20 01:35 PM

I was about to ask

"what happened to litestone-dev?"

The Cap'm (Reese) 17-Feb-20 01:36 PM

might want to post a final message in old dev to clarify why it's there

Ondrik🅱 (Ondrej) 17-Feb-20 01:36 PM

178'239 messages were sent into the channel

that's quite a lot

V A H K I T I 17-Feb-20 01:38 PM

Done

The Cap'm (Reese) 17-Feb-20 01:38 PM

there we go

Ondrik🅱 (Ondrej) 17-Feb-20 01:38 PM

also, what about the stuff which doesn't fit in any of the dev channels?

The Cap'm (Reese) 17-Feb-20 01:38 PM

onto greener pastures

Ondrik🅱 (Ondrej) 17-Feb-20 01:38 PM

like, localization for instance - where should I post about it?

it's not related to art, modeling, or programming

V A H K I T I 17-Feb-20 01:39 PM

New channels are always doable

The Cap'm (Reese) 17-Feb-20 01:39 PM

also channel description btw

The Cap'm (Reese) 17-Feb-20 06:51 PM

so question

@V A H K I T I

We're trying to make the ammo pickups use the upgraded sprites just like the HUD, correct?

V A H K I T I 17-Feb-20 06:54 PM

Ye

The Cap'm (Reese) 17-Feb-20 06:54 PM

so in other words

we're not using the old sprites at all

right?

V A H K I T I 17-Feb-20 06:55 PM

I guess not no, why?

The Cap'm (Reese) 17-Feb-20 06:55 PM

...So why can't we just rename the new sprites to the old ones and not have to do a bunch of hooking stuff?

V A H K I T I 17-Feb-20 06:58 PM

Are you high? :V

Onua Lewa and Tahu?? :V

The Cap'm (Reese) 17-Feb-20 06:59 PM

I see that for Lewa, but Tahu already uses unique ones

V A H K I T I 17-Feb-20 07:00 PM

True. Still it's gonna create a mishmash

The Cap'm (Reese) 17-Feb-20 07:01 PM

~~this is why I wanted a universal pickup texture before~~ Aight, that's enough from me.

...oh, actually, one other thing.

The Legend FMV kept a typo from the original text

referring to "...the islander's powers..."

which should be "...the islanders' powers..."

the existing use of the apostrophe implies that one islander has powers, while the corrected usage I posted refers to the islanders as a group

V A H K I T I 17-Feb-20 08:13 PM

Fucc

benji 17-Feb-20 11:34 PM

so @V A H K I T I did you get the hookmod working?

V A H K I T I 17-Feb-20 11:34 PM

Working? No. I got it to crash again.

Found out where it's doing so

benji 17-Feb-20 11:36 PM

oh wait

I think I might have the solution

V A H K I T I 17-Feb-20 11:37 PM

benji 17-Feb-20 11:37 PM

I can't voice now but I might be able to join you with live share

V A H K I T I 17-Feb-20 11:38 PM

Aight, one sec

Apparently you're still in it

benji 17-Feb-20 11:41 PM

ok try that one

V A H K I T I 17-Feb-20 11:42 PM

Error C2198 'GcLegoCamera__NewToa': too few arguments for call OptionalPatchNative

Ayy it works

The Cap'm (Reese) 17-Feb-20 11:43 PM

so

does that mean we now have NobuaCam ™️ ?

V A H K I T I 17-Feb-20 11:43 PM

[][][] lego_level_initfull [][][] init cam This is CameraDo

Not yet

benji 17-Feb-20 11:43 PM

excellent

could you paste me the IDA pseudocode?

V A H K I T I 17-Feb-20 11:44 PM

Sure, one sec

void __thiscall GcLegoCamera::NewToa(GcLegoCamera *this, ScIdentifier *a2) { this->float_1104 = flt_7065B0; if ( id_onua__dword_706590 == a2->i ) { this->camera_h_float_980 = flt_7065B4; } else if ( id_gali__dword_706594 == a2->i ) { this->camera_h_float_980 = flt_7065B8; } else if ( id_poha__dword_706598 == a2->i ) { this->camera_h_float_980 = flt_7065BC; } else if ( id_kopa__dword_70659C == a2->i ) { this->camera_h_float_980 = flt_7065C0; } else if ( id_lewa__dword_7065A0 == a2->i ) { this->camera_h_float_980 = flt_7065C4; } else if ( id_tahu__dword_7065A4 == a2->i ) { this->camera_h_float_980 = flt_7065C8; } else if ( id_akam__dword_7065A8 == a2->i ) { this->camera_h_float_980 = flt_7065CC; this->float_1104 = flt_7065D0; } else if ( id_wair__dword_7065AC == a2->i ) { this->camera_h_float_980 = flt_7065D4; this->float_1104 = flt_7065D8; } this->camera_h_float_980 = this->camera_h_float_980 + flt_7065DC; this->float_1096 = this->camera_h_float_980; }

benji 17-Feb-20 11:45 PM

alright, could you double click the flt_ values on the top and second to bottom lines and tell me what those values are?

V A H K I T I 17-Feb-20 11:46 PM

.data:007065B0 flt_7065B0 dd 7.0 .data:007065DC flt_7065DC dd 0.1 (edited)

benji 17-Feb-20 11:49 PM

how about the two floats in the bottom else if block?

V A H K I T I 17-Feb-20 11:49 PM

8.0 and 14.0 respectively

benji 17-Feb-20 11:49 PM

cool let's use those

Alright, now it's up to you to change the values of Unknown 1 and 2 to determine what they do

V A H K I T I 17-Feb-20 11:51 PM

SO if I load this right now I should expect a royally fucked camera view, yes?

Or if I change them rather

benji 17-Feb-20 11:51 PM

farther out, most likely

V A H K I T I 17-Feb-20 11:51 PM

Aight, will test

OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOH MAMA MIA

Now THAT'S WHAT I CALL FUCKIN NOBUACAM

The Cap'm (Reese) 17-Feb-20 11:52 PM

it looks like you shrank onua

V A H K I T I 17-Feb-20 11:52 PM

I think it must be the FOV

I'll tinker

The Cap'm (Reese) 17-Feb-20 11:53 PM

Honey, I Shrunk the Toa! staring Rick Moranis

V A H K I T I 17-Feb-20 11:53 PM

He's scaled fine

It's just the camera

The Cap'm (Reese) 17-Feb-20 11:53 PM

yeah I know

V A H K I T I 17-Feb-20 11:54 PM

Only works for onua though I assme we just haven't gotten to the redirection part @benji

benji 17-Feb-20 11:54 PM

it should override all the characters that the native function handled

V A H K I T I 17-Feb-20 11:54 PM

Well it doesn't. Just onua.

FYI right off the bat yes the first float is height.

Halved it here

I'm gonna take a wild guess and say the second is zoom

The Cap'm (Reese) 17-Feb-20 11:55 PM

~~width~~

V A H K I T I 17-Feb-20 11:55 PM

Yup

So height and zoom are floats 1 and 2 respectively

Don't mind the distortion btw. I forgot to copy my DGVoodoo config.

benji 17-Feb-20 11:57 PM

ahhh phew

The Cap'm (Reese) 17-Feb-20 11:57 PM

~~this is why i always use my 4:3~~

V A H K I T I 17-Feb-20 11:57 PM

Also nvm, it does work with the other Toa, I just didn't notice it as much with Gali for some reason

benji 17-Feb-20 11:58 PM

Ideally we ought to put this knowledge back into IDA

V A H K I T I 17-Feb-20 11:58 PM

Gali looks less zoomed out than Onua for some reason.

benji 17-Feb-20 11:58 PM

however, if we keep downloading JMMB's IDA databases it will be overwritten

V A H K I T I 17-Feb-20 11:58 PM

Probably just her height difference

True

The Cap'm (Reese) 17-Feb-20 11:58 PM

she has a head over him

V A H K I T I 17-Feb-20 11:58 PM

Well @JrMasterModelBuilder can just look over this info

He updates the database every time he goes into it pretty much

JrMasterModelBuilder 17-Feb-20 11:59 PM

What up?

V A H K I T I 17-Feb-20 11:59 PM

FOund out what some floats do!

benji 17-Feb-20 11:59 PM

(GcLegoCamera.camera_h_float_980 is height, GcLegoCamera.float_1104 is zoom in unknown units)

V A H K I T I 18-Feb-20 12:00 AM

The Kaita... actually kind of look a bit good with these settings. Though it takes up too much of the screen

The Cap'm (Reese) 18-Feb-20 12:01 AM

bois be too thicc

insert joke about kirby super star here

V A H K I T I 18-Feb-20 12:01 AM

~~Wow so we just makde a hookmod~~

(edited)

benji 18-Feb-20 12:01 AM

FYI the old dev channel has some very useful pins

V A H K I T I 18-Feb-20 12:01 AM

Ye, it's still there, just archived

It's in the legacy section now

So how do we then pass this off to the OSI now?

benji 18-Feb-20 12:02 AM

FYI we probably could have just called gclegocamera::setzoomfactor from the beginning

JrMasterModelBuilder 18-Feb-20 12:02 AM

Just added those camera values.

1

V A H K I T I 18-Feb-20 12:02 AM

nice

Well not quite Benji cause again, the Kaita adjust both height and zoom (edited)

benji 18-Feb-20 12:04 AM

I'm thinking we ought to make our hooked GcLegoCamera::NewToa do nothing, and instead write a function that the OSI can use to set the height and zoom from wherever it wants

V A H K I T I 18-Feb-20 12:05 AM

Sounds good to me. I assume we'll have this called in the individual character classes?

benji 18-Feb-20 12:07 AM

it's up to @ShadowDraikana where to set the camera positions from

V A H K I T I 18-Feb-20 12:12 AM

I'm gonna seriously shit bricks if you're about to tell me this entire part of the mod can be done in one line of code. :v

Okay more than one good so it's not THAT simple. xP

Two fairly straightforward blocks though

UH

My VS just crashed

The Cap'm (Reese) 18-Feb-20 12:14 AM

.-.

V A H K I T I 18-Feb-20 12:15 AM

https://prod.liveshare.vsengsaas.visualstudio.com/join?4FA8D26352637F68227671B062817B9F02F5

Dunno how much of that was lost if any

benji 18-Feb-20 12:19 AM

that should be good to go for the native side

V A H K I T I 18-Feb-20 12:20 AM

Nice! So for the OSI what would I be putting in and does it matter where?

I assume as of right now with nothing it'll just flat crash or shut down (edited)

benji 18-Feb-20 12:21 AM

I don't think it will, go ahead and try running it

it will probably mean the camera keeps its default height offset and zoom factor

which could be zero or any other number

V A H K I T I 18-Feb-20 12:22 AM

Hol up, just trying to repoint the project for rebuilt

What all do I have to change for that again?

benji 18-Feb-20 12:23 AM

you need to tell the other hookmods where to find the ijl15.dll now that you've moved it

in the project properties for each of the hookmods, go to VC++ Directories

oh did you get it to work?

V A H K I T I 18-Feb-20 12:25 AM

Ye

Seems to have defaulted to NobuaCamTM

So Wairhua (edited)

benji 18-Feb-20 12:25 AM

ok, now time for the OSI side

V A H K I T I 18-Feb-20 12:25 AM

Actually it looks off even for them

It must be just a default somewhere else

The Cap'm (Reese) 18-Feb-20 12:26 AM

wairhua

V A H K I T I 18-Feb-20 12:26 AM

Alright so what do I put in the OSI then?

benji 18-Feb-20 12:26 AM

Live Share it and we can work it out

V A H K I T I 18-Feb-20 12:27 AM

~~YOU get a NobuaCam, and YOU get a NobuaCam. EVERYONE GETS A NOBUACAM~~

The Cap'm (Reese) 18-Feb-20 12:27 AM

~~which islander is oprah~~

V A H K I T I 18-Feb-20 12:27 AM

https://prod.liveshare.vsengsaas.visualstudio.com/join?8A77BACD829E91B26E9A1DB4C11CCE46D039

Lel

benji 18-Feb-20 12:27 AM

ideally this would be @ShadowDraikana 's call, but we can do some research for testing purposes

V A H K I T I 18-Feb-20 12:27 AM

Ye

I enjoy tinkering in the OSI

If I had to suggest a spot it would either be the Toa classes or the level setups

onuaclass would be as good a place as any to start I think

Note: MOST of the code in these classes is unused and has been so since prior to our alpha

Example:

method onuaclass(param1, param2, param3, param4, param5) { this.gs_lego_toa(param1, param2, param3, param4, param5); this.dig = 1; this.walkspeed = 4; this.runspeed = 15; this.standingjumpheight = 6; this.standingjumplength = 6; this.runningjumpheight = 4; this.runningjumplength = 8; this.swimingabilty = 0; this.bounce = 0; this.mapperstate = 2; gckeymapper::setusecontext(this.mapperhandle, 0); this.inputhandle = null; return null; }

None of that is functional

Some of it is actually handled by movelists now.

ShadowDraikana 18-Feb-20 12:30 AM

use toa classes

not the level setups

V A H K I T I 18-Feb-20 12:30 AM

Aight

ShadowDraikana 18-Feb-20 12:30 AM

well

it might need the level setup

benji 18-Feb-20 12:30 AM

lol the zoom set already exists

V A H K I T I 18-Feb-20 12:30 AM

But is it used?

benji 18-Feb-20 12:30 AM

irrelevant

if it works

V A H K I T I 18-Feb-20 12:31 AM

True

Did we then just accidentally redirect the exe back to existing OSI code?

benji 18-Feb-20 12:32 AM

we need to comment out our GcLegoCamera__SetZoomFactor registration

V A H K I T I 18-Feb-20 12:32 AM

?

benji 18-Feb-20 12:33 AM

in the hookmod

V A H K I T I 18-Feb-20 12:33 AM

o. I'll bring that back up then

benji 18-Feb-20 12:34 AM

don't bother sharing it

just comment out the line

V A H K I T I 18-Feb-20 12:34 AM

OSIRegisterFunction?

benji 18-Feb-20 12:34 AM

the zoom factor one, yes

V A H K I T I 18-Feb-20 12:35 AM

Done

ShadowDraikana 18-Feb-20 12:35 AM

should be warp factor 1 cuz we know how this game rolls

benji 18-Feb-20 12:35 AM

ok, now we need to know how to access the camera from onua

V A H K I T I 18-Feb-20 12:36 AM

Do I need to reshare? Cause it says you're still here

benji 18-Feb-20 12:39 AM

I'm still here

can't find any references to cameras for the life of me

could you do a search?

searching remotely is super slow for me

V A H K I T I 18-Feb-20 12:39 AM

You won't find any. IIRC there are next to none. I'll have another look tho

?

Or are you looking for references within player.lss?

benji 18-Feb-20 12:41 AM

we're looking for references outside the actual camera LSS files

ShadowDraikana 18-Feb-20 12:42 AM

~~next time let me handle the osi part of the liveshare liam~~ (edited)

also

visual studio search

SUCKS

horrendously slow

even hangs

V A H K I T I 18-Feb-20 12:43 AM

So something like this benji?

benji 18-Feb-20 12:43 AM

perfect

alright throw in some numbers and let's give it a go

V A H K I T I 18-Feb-20 12:50 AM

Where did you put it again? My liveshare lost track of you.

benji 18-Feb-20 12:51 AM

onuaclass.lss

V A H K I T I 18-Feb-20 12:51 AM

Ah thanks

Stand by

Ayyy

What were the original values for Onua again? 1 and 14 was it?

benji 18-Feb-20 12:53 AM

idk

ShadowDraikana 18-Feb-20 12:53 AM

V A H K I T I 18-Feb-20 12:53 AM

Either way we got control over this beast now! ❤️

benji 18-Feb-20 12:53 AM

anyways, that was a hookmod start to end, with OSI integration

V A H K I T I 18-Feb-20 12:54 AM

Not as complicated as I figured, though the integration bit you may still have to go over with Kay since I wasn't able to capture it, or hear any explanations from you

However we got a fair bit ready to go for her

Thanks for your time tonight btw. I know you're super busy as of late

1

benji 18-Feb-20 12:55 AM

reminder to commit asap once it works

V A H K I T I 18-Feb-20 12:56 AM

Okay so the original values I sent earlier must be for the default since I'm back to NobuaCam. xP

I'll jump back into ida and find the proper floats for toa

benji 18-Feb-20 12:56 AM

have fun

V A H K I T I 18-Feb-20 12:56 AM

THank

ShadowDraikana 18-Feb-20 12:58 AM

cool

V A H K I T I 18-Feb-20 01:09 AM

Okay so I can't seem to adjust the zoom

Just the height

The Cap'm (Reese) 18-Feb-20 01:09 AM

oof

V A H K I T I 18-Feb-20 01:10 AM

@benji Should I try uncommenting out that thing we commented out?

benji 18-Feb-20 01:14 AM

Sure

V A H K I T I 18-Feb-20 01:14 AM

Didn't work. Just got done testing it.

I set the OSI value to some absurd number like 50 and it doesn't change the zoom at all

Did something go wrong here?

benji 18-Feb-20 01:23 AM

No idea, any number of things could be going on

V A H K I T I 18-Feb-20 01:23 AM

:/ So what do?

V A H K I T I 18-Feb-20 01:35 AM

I assume it's soemthing to do with the existing OSI code for the zoom we've assumed works

V A H K I T I 18-Feb-20 01:49 AM

Well I'm gonna try and get some sleep. Let me know if you're free later tomorrow to test further

Just a quick aside before going to bed: Clearing out the setzoomfactor method in basecamera entirely does nothing. No crash but no change either.

I think that does literally nothing, even after what we did.

V A H K I T I 18-Feb-20 11:12 AM

@benji Obligatory ping in case you missed this

benji 18-Feb-20 11:15 AM

yeah the OSI was fine

V A H K I T I 18-Feb-20 11:16 AM

Oh? So what do you think might be wrong here, or otherwise what should be my next step in debugging it?

benji 18-Feb-20 11:17 AM

imho the most likely issue is that the values we found in GcLegoCamera::NewToa were just starting values, so setting them via OSI after the toa changes just changes the initial value, not the current value (edited)

V A H K I T I 18-Feb-20 11:18 AM

Hmm.. Well it worked for the height, unless the values for zoom are buried deeper for some reason

benji 18-Feb-20 11:18 AM

but that's a random guess

V A H K I T I 18-Feb-20 11:18 AM

How would you go about debugging this then? (edited)

benji 18-Feb-20 11:20 AM

Check the rest of the exe function that calls GcLegoCamera::NewToa for references to those same variables to see how they are used, or look for native functions that might reference a different variable that might be the zoom factor

V A H K I T I 18-Feb-20 11:20 AM

Aight, gimmie a few minutes and I'll do just that

Well wait hold on.

If that's the case, why did it work when we did it in the mod itself setting values? Let me double check that and make sure it actually DID anything, but I'm pretty sure it did

Yep, DEFINITELY works.

So it's something we're missing in sending that off to the OSI, not the values themselves, right?

FYI I uncommented this stuff to make it work.

V A H K I T I 18-Feb-20 11:35 AM

AHA

Fixed it

zoom

Er

Okay

So I had to re-register the zoomfactor as a new OSI function

Using the existing one does not work

benji 18-Feb-20 11:35 AM

nice

V A H K I T I 18-Feb-20 11:36 AM

I'm L E A R N I N G. ❤️

Question now though is WHY does the existing function not work?

I'm not gonna complain or anything, but having to add a new function should technically be unnecessary

benji 18-Feb-20 11:37 AM

can I see the new register call?

V A H K I T I 18-Feb-20 11:39 AM

Hold up, having some trouble actually controlling it now.

It's definitely a change from the norm, but something else may be up

Stand by

Theeere we go

Script issues. I sent up a new method as a clone of the height one when I should have just renamed the function calls for the existing method for zoom

WHich makes it even weirder that it DOESN'T work with the original function call

Cause the script as you say is fine

Okay yep, gained full control now

One sec, I'll show you the code

Nothing fancy though, I just uncommented out the function registration, turned it into "setbuttfactor" temporarily, and changed all other instances of zetzoomfactor to that.

Basically just used all our existing code, but registered it as a new function

Maybe the OG function has something else going on that prevents it from being called in this way?

ShadowDraikana 18-Feb-20 11:46 AM

>making new methods

benji 18-Feb-20 11:46 AM

maybe we can't register gclegocamera::setzoomfactor because it's already registered by the EXE

ShadowDraikana 18-Feb-20 11:46 AM

BOI

^

i'd check that

benji 18-Feb-20 11:47 AM

what are you on about

V A H K I T I 18-Feb-20 11:47 AM

Well we didn't register it before remember?

We commented that out once we found out it already was

So we just tried to use the function that was already there.

But evidently it won't let us.

benji 18-Feb-20 11:47 AM

I had you uncomment it last night

V A H K I T I 18-Feb-20 11:47 AM

I did that yes, but it didn't change anything

Neither registering it or leaving it as-is had any effect

ShadowDraikana (Ashlyn)Today at 11:46 >making new methods

???

ShadowDraikana 18-Feb-20 11:49 AM

I sent up a new method as a clone of the height one when I should have just renamed the function calls for the existing method for zoom

V A H K I T I 18-Feb-20 11:49 AM

I mean I did it to make sure that it didn't just take the same input as the new height method

Anyways, what I've done here works. I'm able to adjust both the height and zoom, and perfectly replicate the OG camera settings via the script.

FYI for Onua, I rounded up from like.. 2.9 and a 6 digit fraction to 3.0.

So 3.0 height, 7.0 zoom for all normal Toa.

Changed the function name to CamZoom from Butts btw. :v

benji 18-Feb-20 12:00 PM

So does that mean Nobua Mode works like you want?

V A H K I T I 18-Feb-20 12:00 PM

It sure do.

UTTER_BODGE 18-Feb-20 02:54 PM

\o/

V A H K I T I 18-Feb-20 05:17 PM

Am home now

So here's a thing I dug up from the old dev chat that might be relevant to our conundrum with the passive Rahi

ShadowDraikana (Ashlyn) 17/04/2019 oh hey side note: did you know that what controls the waterfall in the Vatuka's lair is only used once in the entire game? the game function called for it is never used anywhere else in the OSI "gctransdirector", "hide"

The function that coincidentally also holds the necessary code to spawn the particle fountains and move the infected masks when called by GcCharacter::Kill.

@ShadowDraikana Does this change anything in your mind in regards to scripting those functions now?

ShadowDraikana 18-Feb-20 05:24 PM

O_o

so that's what it's tied into

V A H K I T I 18-Feb-20 05:25 PM

¯\_(ツ)_/¯

ShadowDraikana 18-Feb-20 05:25 PM

fucking

you know what

V A H K I T I 18-Feb-20 05:26 PM

All I know right now is that it's a step in the GcCharacter::Kill function to make the things happen, and it's also apparently already registered as an OSI function according to past you.

(edited)

ShadowDraikana 18-Feb-20 05:26 PM

that handles transparent objects

think mbch

i completely forgot to attempt to use it there

V A H K I T I 18-Feb-20 05:26 PM

Heh

Well there ya go

ShadowDraikana 18-Feb-20 05:26 PM

it's legit used nowhere else

outside of mud0

V A H K I T I 18-Feb-20 05:26 PM

And it works there

ShadowDraikana 18-Feb-20 05:27 PM

do me a favor and check if it has other functions

as in what can transdirector do

V A H K I T I 18-Feb-20 05:27 PM

Question is, can we access the code that's tucked away in it for infected masks from the OSI

If we can, half our work is already done

ShadowDraikana 18-Feb-20 05:27 PM

IF that's part of a registered osi sub function if you will

child is a better word

is the hide command fired when the mask is in play?

V A H K I T I 18-Feb-20 05:28 PM

IIRC it's used to hide the Rahi during its death animation

Eg: the S P E E N

ShadowDraikana 18-Feb-20 05:29 PM

curious

so the fadeout is triggered from there

V A H K I T I 18-Feb-20 05:30 PM

The things are apparently done under GcTransDirector::sTransNode but I'm not sure where to find that

ShadowDraikana 18-Feb-20 05:31 PM

that's a lead at least

gotta do something in the house real quicc

V A H K I T I 18-Feb-20 05:31 PM

Ah here we are

ShadowDraikana 18-Feb-20 05:46 PM

V A H K I T I 18-Feb-20 05:46 PM

That shows pretty much everything there I think

It creates the sprite and the emitter.

THis moves the mask up

if ( anim_sprite_new ) { pos_y_plus1 = flt_6FEE0C + pos_y; GcAnimSprite::GcAnimSprite( anim_sprite_new, aInfMasks, dword_6FEE14, dword_6FEE10, 72, 2, pos_x, pos_y_plus1, pos_z, &sprite_path, 0, 0, a13, 0); }

To put it in perspective, this is all that aisetbenign does on its own.

void __thiscall GcCharacter::AISetBenign(GcCharacter *this, bool a2) { GcCharacterAIController::SetBenign(this->character_ai_controller, a2); }

So we need to find a way to grab this one section of GcCharacter::Kill and tack it onto aisetbenign

V A H K I T I 18-Feb-20 06:29 PM

Okay so step 1 of getting this into a hookmod is done. I now have GcCharacter::Kill doing that trampoline thing we initially did last night with an added debug string

@benji

[][][] AreaSetActiveNow active area is bech area is bech startPos is str0 DED

The rest of this function is a lot more complex, so I'm not entirely sure how to proceed.

benji 18-Feb-20 08:20 PM

oh nice work

V A H K I T I 18-Feb-20 08:20 PM

Thank

benji 18-Feb-20 08:20 PM

I don't see why you're hooking Kill though

it seems like AISetBenign is the one you want to change

V A H K I T I 18-Feb-20 08:21 PM

It is, but the code I want is directly called by Kill, so I was hoping to hook kill and just change what AI setting it trips to just clone that of setbenign

benji 18-Feb-20 08:21 PM

modifying AISetBenign will be 10000x easier

if you can get away with that

V A H K I T I 18-Feb-20 08:22 PM

Well I've written here what would probably need to be done to do it that way, if that seems reasonably within my skill level?

A simple EXE mod can get them back in the game just by changing a hard-coded function call off of aidie. That's the easy part. The problem is that the infected masks and particle fountain are a part of gcmodeldirector::hide, and when that's not run, none of that happens. What I'd need to do is basically extract that code from gcmodeldirector::hide and have it run indepenedently after aisetbenign is run How would you recommend I approach that?

benji 18-Feb-20 08:23 PM

Adding code to functions is ez pz, removing code from functions is a massive pain because you have to re-code yourself all the stuff you don't want removed

V A H K I T I 18-Feb-20 08:24 PM

Fair. Well I'm just working on an assignment and Nobua's model right now, but if you're free in maybe 10 minutes we could tackle that if you want to help me learn that aspect of this.

benji 18-Feb-20 08:26 PM

I'm down to help you add code to a function, but I'm not interested in trying to re-code almost all of Kill

V A H K I T I 18-Feb-20 08:26 PM

Right, no I'm fine with whatever is easiest and gets the job done.

I'll just undo what I did here. It didn't take too long

benji 18-Feb-20 08:27 PM

well it's up to you to tell me what you want done and how you want to do it

V A H K I T I 18-Feb-20 08:27 PM

Well assuming we use this in tandem with JMMB's EXE mod, the game will now by default turn any Rahi killed passive and spawn the infected mask sprite.

WHat needs to happen now is the code to make the sprite move and spawn the particle emitter currently a part of GcModelDirector::Hide needs to be brought into the fold.

benji 18-Feb-20 08:28 PM

so the part you pasted after you said

THis moves the mask up

(edited)

or what

V A H K I T I 18-Feb-20 08:29 PM

Pretty much, yeah. That code just takes the Y value and adds y+1.

THere's also code to spawn the emitter in there

Er.. I thought there was but now I'm not seeing it. One sec

V A H K I T I 18-Feb-20 08:39 PM

Okay maybe I'm looking at something different then, but this definitely handles the mask movement, or at least it REALLY looks like it would

benji 18-Feb-20 08:40 PM

I don't see anything movement related

V A H K I T I 18-Feb-20 08:40 PM

I think that code snipped I pasted is what we want.

if ( anim_sprite_new ) { pos_y_plus1 = flt_6FEE0C + pos_y; GcAnimSprite::GcAnimSprite( anim_sprite_new, aInfMasks, dword_6FEE14, dword_6FEE10, 72, 2, pos_x, pos_y_plus1, pos_z, &sprite_path, 0, 0, a13, 0); }

Basically get Y, add Y+1

Which would just make the sprite rise by 1 value every tick until the animation ends

~~The one thing I remembered from my Javascript class~~

benji 18-Feb-20 08:42 PM

no, that says to create it 1 unit above the position of the character

V A H K I T I 18-Feb-20 08:42 PM

Hmm

Well in that case I'll have to have a look in that other function JMMB mentioned before.

GcTransDirector::sTransNode

Unless it's outside that and it just has to be there to get to it. His message way back when wasn't super clear

JrMasterModelBuilderToday at 04:21 Not hiding the model and adding it to GcTransDirector::sTransNode means that stuff doesn't happen.

benji 18-Feb-20 08:44 PM

sTransNode is the parent of all transparent things

V A H K I T I 18-Feb-20 08:44 PM

Wonderful. So needle in a haystack then?

benji 18-Feb-20 08:44 PM

more like a red herring

V A H K I T I 18-Feb-20 08:44 PM

What do you propose?

benji 18-Feb-20 08:45 PM

No idea

V A H K I T I 18-Feb-20 08:45 PM

I'll try stepping through functions again until I find something. Just wanna finish up this model real quick

benji 18-Feb-20 08:49 PM

aight good luck

V A H K I T I 18-Feb-20 08:59 PM

~~I'll need it~~

ShadowDraikana 18-Feb-20 09:03 PM

oh btw

did you set the hookmods to x64 or win32

in your solution file locally

V A H K I T I 18-Feb-20 09:05 PM

32

ShadowDraikana 18-Feb-20 09:05 PM

i believe that's correct so we're good then

oh ffs here we go making that pr

and now i pray i wrote this correctly

V A H K I T I 18-Feb-20 09:10 PM

Okay so

The best I can find so far is that GcEmitter is called by GcCharacter::React

But this doesn't just apply to death, but any hit the creature takes.

So I'm not sure that this is the right thing.

@benji

ShadowDraikana 18-Feb-20 09:11 PM

https://cdn.discordapp.com/attachments/403611291857584128/555546971352465408/unknown.png

V A H K I T I 22-Feb-20 01:31 AM

@benji Dumb stupid idea based on an old video game trope.

How hard would a hookmod be that takes any bone named head and scales it up by a set amount?

The Cap'm (Reese) 22-Feb-20 08:48 AM

Ah, DK Mode

V A H K I T I 24-Feb-20 11:18 AM

@ShadowDraikana Let's take this here since we're kind of derailing the pitches channel.

ShadowDraikana 24-Feb-20 11:18 AM

aight

V A H K I T I 24-Feb-20 11:21 AM

So for MBCH let's see if GcTransDirector will help us here. You say it's used in MUD0, and it seems to work there.

ShadowDraikana 24-Feb-20 11:21 AM

the main problem looking at this again

is the way the event is fired

it's not working correctly and i really don't understand why

V A H K I T I 24-Feb-20 11:22 AM

How is it firing exactly?

ShadowDraikana 24-Feb-20 11:22 AM

if (param1.eventid == 35) { if (param1.args[0] == this.boulder.id) { if (param1.args[1] == 0) { this.boulder.hide(); } } else if (param1.args[0] == this.waterfall.id) { if (param1.args[1] == 0) { this.waterfall.hide(); } } }

those extra checks for the boulder and waterfall ids are needed along with the param1.args[1] or else it just does the thing anyway even if there has been no fadein/fadeout fired

V A H K I T I 24-Feb-20 11:24 AM

So it's.. testing for the boulder being hidden?

That seems hacky and unnecessary

Can we not just do it with triggers?

ShadowDraikana 24-Feb-20 11:24 AM

no it's testing for the event

it checks whether the event args 0 is the boulder or not

as in the object having fadein/fadeout run

V A H K I T I 24-Feb-20 11:25 AM

Imma brb and get some food, but I feel like this could be done super easily by just plopping a trigger in the pit to test for the boulder itself and then fire an event once it's there.

ShadowDraikana 24-Feb-20 11:25 AM

the args[1] == 0 is the "da fuq" part

see that's the issue

it just fires no matter what

it's not even checking properly

and if i remove the checks it goes nuts the same way

something is setting if off from the get go for some reason

V A H K I T I 24-Feb-20 11:26 AM

Well maybe because it's testing for an event and those are weird and inconsistent.

hmm

Well either way I think a trigger would simplify things and help narrow down the real issue

AFAIK there's no need to test for an event

At the end of the day we just need a thing to happen when another thing is in a place.

No need to overcomplicate it. Or in this case leave it overcomplicated.

ShadowDraikana 24-Feb-20 11:27 AM

well here's the issue

slapping a trigger in that pit would look really really dumb with no water falling from there properly until it landed

V A H K I T I 24-Feb-20 11:28 AM

I mean

The trigger doesn't have to be at the VERY BOTTOM

Just offset it upwards to match the existing timing

Not everything is a problem, you just have to be a bit more creative.

ShadowDraikana 24-Feb-20 11:30 AM

problem is i don't know if there's an actual even for an object passing through a trigger

*event

it could be the trigger events work for anything

V A H K I T I 24-Feb-20 11:31 AM

Well I know right away that triggers don't descriminate players from entities. See early Onu-Koro tests.

ShadowDraikana 24-Feb-20 11:36 AM

i need to know what event 31 does

nm i think i answered that question

it looks like it's for what happens when a boulder object lands

V A H K I T I 24-Feb-20 11:40 AM

️

Anyways I'd still recommend testing a trigger. It would simplify matters.

ShadowDraikana 24-Feb-20 11:44 AM

not really considering that's not going to affect the way it fires it

maybe adding one step to the process but aside from that no

V A H K I T I 24-Feb-20 11:45 AM

Another way to do it would be to take advantage of the fact that the boulder always follows a set path at a set time and have GALI activate a trigger when she touches the boulder, then just have the waterfalls fire on a timer to line up with when the boulder drops.

Or hell, just have the timer run when Gali touches the boulder. I think the boulder moving at all is scripted, right?

ShadowDraikana 24-Feb-20 11:46 AM

as soon as she touched the boulder with the pakari turned on, it starts moving. not a set path btw

that's all handled by the moveable object physics

V A H K I T I 24-Feb-20 11:47 AM

Eg: Boulder begins rolling, start timer. After N seconds, hide waterfalls

ShadowDraikana 24-Feb-20 11:47 AM

well i'd have to fadein/fadeout

V A H K I T I 24-Feb-20 11:47 AM

Well it may not be a set path, but it always follows the same one

IIRC it never changes

ShadowDraikana 24-Feb-20 11:47 AM

which put us right back to the event in question that always just does the thing anyway

something sets it off way early

V A H K I T I 24-Feb-20 11:48 AM

That's another point I'd like to bring up here btw. It may be handled by physics, but it uses the old alpha way of moving boulders around right?

Eg: BLDR compared to RKFL.

So it's far less dynamic.

I would suggest we change that and in doing so we can have an isolated test box for the next patch + ROLL, but only after we get the basic functionality of the set piece down.

V A H K I T I 24-Feb-20 10:43 PM

Any luck @ShadowDraikana ?

ShadowDraikana 24-Feb-20 10:46 PM

nope and im heading to bed

V A H K I T I 24-Feb-20 10:58 PM

.-.

so early?

V A H K I T I 25-Feb-20 02:20 PM

@ShadowDraikana Feel up to continuing this deep-dive today? I did some brief tinkering last night, but I couldn't figure out how to properly use GcTransDirector.

ShadowDraikana 25-Feb-20 02:21 PM

maybe? not sure yet

V A H K I T I 25-Feb-20 02:21 PM

@The Cap'm (Reese) Did you convert the text paths into splines yet, or has that not been done?

The Cap'm (Reese) 25-Feb-20 02:21 PM

i did

all four txts are separate splines

V A H K I T I 25-Feb-20 02:22 PM

nice, so that's something that can be set up at least

The Cap'm (Reese) 25-Feb-20 02:22 PM

anyway's i'm off. I'll be back around 3:30-ish

V A H K I T I 25-Feb-20 02:22 PM

Aight

The Cap'm (Reese) 25-Feb-20 04:45 PM

and lo I have returned

V A H K I T I 25-Feb-20 09:59 PM

same

V A H K I T I 25-Feb-20 11:11 PM

beep boop

The Cap'm (Reese) 25-Feb-20 11:11 PM

bop

The Shadow Emperor 25-Feb-20 11:12 PM

Beezow Doo-doo Zopittybop-bop-bop

V A H K I T I 25-Feb-20 11:13 PM

https://tenor.com/view/scatman-john-scatman-scatmans-world-skibidi-bum-du-du-du-gif-14752774

The Cap'm (Reese) 25-Feb-20 11:13 PM

quality album, that was

V A H K I T I 25-Feb-20 11:13 PM

Scatman is best man

Or was I guess. Rip

The Cap'm (Reese) 25-Feb-20 11:13 PM

yea

third album was a tad iffy but still good

V A H K I T I 25-Feb-20 11:14 PM

I've only actually heard a handful of his songs. I should give his full discography a runthrough

His remix of Invisible Man blows the Queen original out of the fucking park IMO. (edited)

However the original is definitely dated.

Scatman's has a more timeless feel to it.

It doesn't feel quite as clearly 80s synthpop.

The Cap'm (Reese) 25-Feb-20 11:16 PM

Scatman's World and Everybody Jam are super solid

(the albums)

V A H K I T I 25-Feb-20 11:16 PM

I've heard the songs for sure.

Not the full albums

The Cap'm (Reese) 25-Feb-20 11:16 PM

Take Your Time is okay, but it clearly was made when he was in ailing health

V A H K I T I 25-Feb-20 11:16 PM

:/

Sort of like Mother Love for Queen

That song was actually never finished. Before recording the last verse, Freddie needed to take a break and went home to rest. Well suffice to say he never woke up.

The Cap'm (Reese) 25-Feb-20 11:18 PM

yikes

V A H K I T I 25-Feb-20 11:18 PM

Brian May ended up piecing together what they had to work with and sang the last verse himself

The Cap'm (Reese) 25-Feb-20 11:18 PM

ah

V A H K I T I 25-Feb-20 11:18 PM

https://www.youtube.com/watch?v=6rSJbkZOvo0

Queen Forever

Queen - Mother Love

From album Made in Heaven Deluxe edition http://www.queenforever.it/

The Cap'm (Reese) 25-Feb-20 11:18 PM

Yeah Take Your Time has a prominent female vocalist on just about every song, and you get very little of John

and in the title track you can hear the strain in his voice (as it was the last song he ever recorded, apparently)

V A H K I T I 25-Feb-20 11:20 PM

Yeah that's the same with this one. Most of the album Made in Heaven was similar. A lot of unfinished material pieced together as a last hurrah.

"And Freddie at that time said ‘Write me stuff … I know I don’t have very long; keep writing me words, keep giving me things I will sing, then you can do what you like with it afterwards, you know; finish it off’ and so I was writing on scraps of paper these lines of ‘Mother Love’, and every time I gave him another line he’d sing it, sing it again, and sing it again, so we had three takes for every line, and that was it … and we got to the last verse and he said ‘I’m not up to this, and I need to go away and have a rest, I’ll come back and finish it off … and he never came back" ~ Brian May

Fuck now I'm sad. All these amazing artists and amazing PEOPLE that died way too soon. ;~;

The Cap'm (Reese) 25-Feb-20 11:24 PM

yeah...

V A H K I T I 25-Feb-20 11:24 PM

So uh.... getting back more on topic I guess to try and lighten the mood, what's everyone working on tonight/want to work on, if anything? (edited)

V A H K I T I 25-Feb-20 11:41 PM

:v

V A H K I T I 27-Feb-20 09:25 PM

@The Cap'm (Reese) Are you busy right now?

The Cap'm (Reese) 27-Feb-20 09:25 PM

not necessarily

V A H K I T I 27-Feb-20 09:25 PM

Think you'd have time for a little MBCH experiment?

The Cap'm (Reese) 27-Feb-20 09:25 PM

could do

V A H K I T I 27-Feb-20 09:25 PM

So we all know that before the water is fully hidden and all the swapping in and out of models is going on, shit turns invisible and it looks jank as fuck.

So I'm thinking we hide all of that for the time being by making a cutscene from below when the boulder starts falling.

Then that can end once everything is all processed and nobody has to see that ugliness

The Cap'm (Reese) 27-Feb-20 09:27 PM

so what you're saying is combine it with the pushblock scene or have it as a camera pan

V A H K I T I 27-Feb-20 09:27 PM

I mean we could potentially do both, but the pan is absolutely necessary here until we figure out depth sorting.

We could even possibly just chain the two together, though Idk how good it would look

I'll leave it up to you as to what should be shown in the pan, but just don't get too wild with it, and make sure everything on the top of the cliff is not visible.

The Cap'm (Reese) 27-Feb-20 09:29 PM

oh yeah I actually have to do things :v

~~nevermind im busy~~

V A H K I T I 27-Feb-20 09:30 PM

My suggestion would be to focus on the boulder falling and then the tohunga as the falls fade

Boi

The Cap'm (Reese) 27-Feb-20 09:30 PM

well I have no clue how I'll coordinate all that but I'll try making some sort of pan

V A H K I T I 27-Feb-20 09:30 PM

It's mostly just a matter of timing really.

The Cap'm (Reese) 27-Feb-20 09:31 PM

Yeah. And I calculate that how, exactly?

V A H K I T I 27-Feb-20 09:31 PM

My plan is to have this start the moment the boulder tips over the edge, so build it on that assumption for a start time.

As for the end time just count how long it takes for shit to fade out and work from there

The Cap'm (Reese) 27-Feb-20 09:32 PM

you are aware how cam times work right

V A H K I T I 27-Feb-20 09:32 PM

?

The Cap'm (Reese) 27-Feb-20 09:32 PM

times in cam slbs are measured from 0 to 1

me manually timing things will do jack and shit

V A H K I T I 27-Feb-20 09:33 PM

I mean... assuming what you mean is that every frame in a cam SLB is some fraction between 0 and 1, Idk what utility you could use for it, but I'm sure there's a way you could break down the amount of time the boulder and fades take into that fraction

The Cap'm (Reese) 27-Feb-20 09:34 PM

all I know about timing these is pressing the "time this for me please" button and it auto adjusting times for me

V A H K I T I 27-Feb-20 09:36 PM

So you've never once looked at one of these and thought about how much real time you want them to go on for? That's not something @UTTER_BODGE has made easy to calculate?

The Cap'm (Reese) 27-Feb-20 09:37 PM

I just use points to make a shape and space them so the camera doesn't go lightspeed between them

V A H K I T I 27-Feb-20 09:39 PM

Well... in that case I'd just say start by trying to time a slow pan from the boulder drop to the end of the fade. Be it by trial and error or otherwise. Once you have that down, you can divide that up into sections for what to focus on and when since you'll now have the full timespan of the pan as a frame of reference to time everything else.

Just a simple left to right two point pan or something like that to start just to get a feel for the real timing.

Then fill in the gaps once you have that down.

Make sense?

The Cap'm (Reese) 27-Feb-20 09:41 PM

that also requires me being able to view the pan

V A H K I T I 27-Feb-20 09:41 PM

Which I think @ShadowDraikana Can set up for you real quick once you get something for her to work with.

The Cap'm (Reese) 27-Feb-20 09:42 PM

well i have the Tarakava pan already done

and a trigger for it

V A H K I T I 27-Feb-20 09:42 PM

What's that have to do with this?

The Cap'm (Reese) 27-Feb-20 09:42 PM

It's something to work with :v

I.E. the trigger

to trigger it

V A H K I T I 27-Feb-20 09:43 PM

o

V A H K I T I 27-Feb-20 10:15 PM

any luck?

The Cap'm (Reese) 28-Feb-20 11:17 AM

So here's what I have.

Here and here there are three points on top of one another, which hopefully should make the camera pause.

Miniboss is Path 0, boulder is Path 1

Attachment: mbch_CAM.slb (1.03 KB)

also here's this to test the box trigger in the boulder pit

Attachment: mbch_TRIGGER.slb (352 B)

since it was misaligned for some reason

V A H K I T I 28-Feb-20 02:23 PM

Has it been tested or are you not able to do that?

@The Cap'm (Reese)

The Cap'm (Reese) 28-Feb-20 04:33 PM

Cannot

(And I'm at work till around 7 tonight)

V A H K I T I 28-Feb-20 09:49 PM

oof

The Cap'm (Reese) 28-Feb-20 09:52 PM

Yeah still can't do it. :p

V A H K I T I 28-Feb-20 09:53 PM

nani

WHat was that about a box trigger btw?

The Cap'm (Reese) 28-Feb-20 09:56 PM

The killbox you told me to add to the boulder pt

V A H K I T I 28-Feb-20 09:56 PM

o

The Cap'm (Reese) 28-Feb-20 09:56 PM

It was slightly misaligned

V A H K I T I 28-Feb-20 10:15 PM

I see

V A H K I T I 28-Feb-20 10:30 PM

Btw I've decided to rename Greg & PD 3

Imma make it a play on Evil Dead 3 and call it "Army of Dankness". :v

The Cap'm (Reese) 28-Feb-20 10:31 PM

fair

The Cap'm (Reese) 28-Feb-20 11:49 PM

how's that going ftr

V A H K I T I 28-Feb-20 11:53 PM

Attachment: Table.mp4 (14.31 MB)

ShadowDraikana 29-Feb-20 08:58 AM

https://tenor.com/view/zod-heresy-man-of-steel-gif-8396847

i actually saw that movie recently btw

that makes this gif 10 times better lol

Ondrik🅱 (Ondrej) 01-Mar-20 08:39 AM

you know that you haven't done shit in a long time

when you are 51 commits behind

ShadowDraikana 01-Mar-20 08:44 AM

oof

The Cap'm (Reese) 01-Mar-20 12:07 PM

so for that camera pan for the boulder

what I did won't work

the cam times are auto-set by distance apart, meaning it can't and won't pause

best I could do is just make the pan go around the area more to try accounting for the fadeout

V A H K I T I 01-Mar-20 12:12 PM

It pauses in CLF1.

There has to be a way

ShadowDraikana 01-Mar-20 12:12 PM

pardon

pauses?

V A H K I T I 01-Mar-20 12:13 PM

It pauses at the end before the cutscene itself ends.

It doesn't just reach the end of the spline then cut back to the Toa like the boss intros.

There's a solid 2 second pause.

ShadowDraikana 01-Mar-20 12:17 PM

1.5 seconds if this is right

the question is i don't see how it actually interfaces with the cutscene itself

in clf1

unless event 6 is what's triggering that

like that fires when a scene is supposed to end

V A H K I T I 01-Mar-20 06:33 PM

SuS

The Cap'm (Reese) 01-Mar-20 06:33 PM

SeeS

V A H K I T I 01-Mar-20 06:33 PM

SooS MooM

The Cap'm (Reese) 01-Mar-20 06:33 PM

Bees

The Shadow Emperor 01-Mar-20 06:37 PM

WW SOOS BOOB

V A H K I T I 01-Mar-20 07:10 PM

What's everyone working on tonight? Any outstanding tasks y'all wanna tackle?

@ShadowDraikana Progress on MBCH? If you're not currently still trying things I need you to push what you have so I can.

ShadowDraikana 01-Mar-20 07:12 PM

look i'm trying to relax for the evening now

had more shit go down today and i'm getting fucking sick of mbch

V A H K I T I 01-Mar-20 07:13 PM

Okay so... push your changes so somebody else can take over.

ShadowDraikana 01-Mar-20 07:13 PM

it's tedious and i straight up do not want to work on it

i have no changes that work

V A H K I T I 01-Mar-20 07:13 PM

Don't hoard code, we've been over this

ShadowDraikana 01-Mar-20 07:13 PM

it's fucking broken

V A H K I T I 01-Mar-20 07:13 PM

Idc if they WORK I just need timers in place which you have last I heard (edited)

ShadowDraikana 01-Mar-20 07:13 PM

i did but they straight up weren't even functioning

period

i can't explain that either

V A H K I T I 01-Mar-20 07:14 PM

Well just send whatever you have then.

ShadowDraikana 01-Mar-20 07:14 PM

and no i'm not pushing it as is because it does literally fuck all

and i removed it earlier and i really am not in the mood to readd it now

V A H K I T I 01-Mar-20 07:16 PM

Look, nobody else here knows how to set up a timer. Unless you want to give one of us a crash course in some other area, shit isn't gonna get done with you sitting on changes, functional or not. I know you don't want to touch this area anymore, but some of us still do. If you already removed the code then fine I guess, but don't do that again. If something isn't working and you don't want to work on it anymore, send what you have, don't just revert it and leave us with our thumbs up our asses. :/

ShadowDraikana 01-Mar-20 07:16 PM

i reverted it BECAUSE IT DOES FUCKING NOTHING

NOTHING

V A H K I T I 01-Mar-20 07:17 PM

Does the code you put in work in other areas, or is it just this one that's acting up?

ShadowDraikana 01-Mar-20 07:17 PM

this one

V A H K I T I 01-Mar-20 07:17 PM

Then it could probably have been salvaged with further testing.

There's probably a REASON it does nothing, however stupid and nonsensical it may be

ShadowDraikana 01-Mar-20 07:18 PM

fine. i'll deal with it later tonight.

V A H K I T I 01-Mar-20 07:18 PM

And we can't find that reason if the code is gone

ShadowDraikana 01-Mar-20 07:18 PM

i'm getting sick of this

like i am beyond done with this area

V A H K I T I 01-Mar-20 07:19 PM

Well nobody's asking you to keep hammering at it anymore. All I'm asking is for a known functional code base that we can debug ourselves.

Literally all I wanted was timer code. Yes it doesn't function here for some dumbass reason, and I understand and accept that. I just wanted it in there functional or not so that maybe we have a chance to find out why. By all means just relax if you don't want to deal with this area anymore.

ShadowDraikana 01-Mar-20 07:21 PM

not to mention the fadein/show thing doesn't work even with the changes you made

and when i tried making the timer affect the first waterfall only it did fuck all

hell the timer didn't even fire correctly

which makes absolutely ZERO sense because it was being read and it should have been firing

(sound familiar)

i'll set it back up later

V A H K I T I 02-Mar-20 06:31 PM

Btw Reese, an idea.

You say you can't make a camera pause, but we do know at the very least it can pause at the beginning and end of its path.

So we COULD theoretically split up your MBCH camera into two splines separated by a scripted pause.

The Cap'm (Reese) 02-Mar-20 06:33 PM

See I thought about that

V A H K I T I 02-Mar-20 06:33 PM

Ie: Cam 1 goes to boulder, pause, immediately jumps to cam 2

The Cap'm (Reese) 02-Mar-20 06:33 PM

But IIRC last time we tried stringing cams together it didn't work at all

V A H K I T I 02-Mar-20 06:33 PM

We tried this before?

When?

The Cap'm (Reese) 02-Mar-20 06:33 PM

Credits from TAHU

Trying to make the game play the pans up to the credits played only the first one iirc and then started the credits

V A H K I T I 02-Mar-20 06:36 PM

I don't remember this at all, and am also not entirely clear on what you're trying to describe, but until @ShadowDraikana sends me her timer and cam playback code, I'll take your word for it since at present I'm unable to tinker.

(No rush btw Ash)

At any rate I'm sure it's possible. Though I'm not sure how well the game will react to it.

The worst case scenario in my head is that it'll go through ALL the motions before starting the next cam. That includes scrolling the letterboxing back out, and then in again for the start of the next section.

Which uh...

Won't look particularly good.

The Cap'm (Reese) 02-Mar-20 06:42 PM

Well question now

How does mud man/rock boi do it

Because they dont letterbox the game at all

SHRN3 does it too

And alpha SHRN6

V A H K I T I 02-Mar-20 06:44 PM

SHRN3 has a pan? I don't recall this

The Cap'm (Reese) 02-Mar-20 06:44 PM

Well not so much a pan

It snaps the camera in front of you while a door closes

V A H K I T I 02-Mar-20 06:44 PM

ah

The Cap'm (Reese) 02-Mar-20 06:44 PM

Which I assume is either the same or a similar function

V A H K I T I 02-Mar-20 06:45 PM

May want to look into that then. My guess is that it's just a cam with a single point, but I guess also some toggleable value somewhere as to whether or not to letterbox during the scene.

Given that everything we've set up ourselves does the letterboxing, I would assume that this is the default setting

Whatever SHRN3 and the boss cams do must be something manually set.

The Cap'm (Reese) 02-Mar-20 06:46 PM

And SHRN6

Which has a pan in the alpha

V A H K I T I 02-Mar-20 06:47 PM

Maybe give that same digging to the best of your ability. I need to do a quick grocery run. If you can't find anything, I'll TECHNICALLY have time when I get back, though I really should be doing assignments.

V A H K I T I 05-Mar-20 01:32 PM

@The Cap'm (Reese) It LOOKS simple enough at first glance? THere are three different floats for forward vector.

Presumably W, S, and Right Click speeds

The Cap'm (Reese) 05-Mar-20 01:32 PM

ah

V A H K I T I 05-Mar-20 01:32 PM

Well for setting that up anyways

Two of them are the same which I'm willing to wager is Right Click and S (edited)

One is 3, the other two are 12.

The Cap'm (Reese) 05-Mar-20 01:33 PM

huh

so would the idea be to bump up S to...I dunno, 20 or something?

V A H K I T I 05-Mar-20 01:36 PM

Just confirmed in game btw. S and right click give the exact same boost. If there is a difference it's negligible.

The Cap'm (Reese) 05-Mar-20 01:36 PM

ah

V A H K I T I 05-Mar-20 01:59 PM

Can you do me a favour?

The Cap'm (Reese) 05-Mar-20 01:59 PM

sup

V A H K I T I 05-Mar-20 02:00 PM

What's the ID of Gali's swim animations? THat includes the default as well as the windup.

I'm thinking this might be a movelist thing.

ShadowDraikana 05-Mar-20 02:00 PM

what's up

V A H K I T I 05-Mar-20 02:00 PM

All the EXE seems to do is determine the forward vector.

I'm looking into speeding up Gali's wind-up S swim boost

The Cap'm (Reese) 05-Mar-20 02:01 PM

36 - GALI SWIM

V A H K I T I 05-Mar-20 02:01 PM

It's kind of inept right now

THank

My main tipoff here is that the EXE doesn't seem to have any code at all for the S boost.

I can find things that it does for pressing W and Right Click, (GcMotionSystem::SwimKeyPressed and GcMotionSystem::SurfaceKeyPressed respectively) but nothing for S.

The Cap'm (Reese) 05-Mar-20 02:03 PM

...hmm

V A H K I T I 05-Mar-20 02:03 PM

My best guess now is that it's either entirely movelist handled, or worse, functions like the jump animation where the height is determined by the animation itself.

The Cap'm (Reese) 05-Mar-20 02:03 PM

It might just be that it's named weird but I can't find the S animation in my list

https://docs.google.com/document/d/1fbQkpul2f1Kk1YmesOgNzvTsJcHLA7HT9QYOS-I41TM/edit?usp=sharing

Gali's Animations

c201 - GA_C201 (Onua Meets Gali) c202 - GA_C202 (DiveFromMask) c230 - GA_C230 (Takara) c301 - GA_C301 (Gali Meets Pohatu) 00 - GALI IDLE 01 - GALI WALK 02 - GALI RUN 03 - GALI JUMP UP 04 - GALI JUMP DOWN / GALI RUN JUMP DOWN 16 - GALI THROW (early melee) 17 - GALI DRAG START 1...

V A H K I T I 05-Mar-20 02:04 PM

Though if it IS animation handled, @Ondrik🅱 (Ondrej) may be able to do something with it since it would just be a matter of making the ending boost move the model farther.

Ondrik🅱 (Ondrej) 05-Mar-20 02:05 PM

V A H K I T I 05-Mar-20 02:05 PM

:v

@The Cap'm (Reese) Frogkick?

The Cap'm (Reese) 05-Mar-20 02:05 PM

unused IIRC

Ondrik🅱 (Ondrej) 05-Mar-20 02:05 PM

making the ending boost move the model farther.

... I'm not sure I can do that

V A H K I T I 05-Mar-20 02:05 PM

Also Gali has turning swim animations? THat's new to me

The Cap'm (Reese) 05-Mar-20 02:05 PM

yeah I have two minds on those

they're either unused or they're subtle

when my game runs at a shit fps, I think I actually catch them

V A H K I T I 05-Mar-20 02:06 PM

With a hookmod we could POSSIBLY make use of those if they're at all worth adding.

Just have them play if the forwrd vector changes I THINK

The Cap'm (Reese) 05-Mar-20 02:07 PM

it also might be that underwater is breaking them like it does the damage animation

V A H K I T I 05-Mar-20 02:07 PM

hmm

The Cap'm (Reese) 05-Mar-20 02:07 PM

cuz Gali does have an animation for being hurt underwater

and it seemingly tries to play

but it's immediately canceled by the normal swim anim

V A H K I T I 05-Mar-20 02:09 PM

I mean that makes sense from what I can see in the exe.

Lots of ForceAnim calls.

So it's clearly hard-coded to play swim and nothing but swim forever and always.

The Cap'm (Reese) 05-Mar-20 02:09 PM

I've also inferred that 63 - GA_SWIM_AFTER_JUMP also doesn't play for the same reason

though to be fair I

've not looked through the movelist for it (edited)

V A H K I T I 05-Mar-20 02:10 PM

I'd love to get all this up and running, but just from briefly looking over things here, I think the entire swim function set would have to be hooked and gutted.

~~Like a fish if you will~~

Anyways obviously for anyone but @benji that's probably EXCEPTIONALLY unfeasible right now.

That does bring up an interesting thought though.

I must be missing some conditions somewhere, because there's no way it's constantly forcing swim to play but letting frogkick(?) through without something telling it somewhere to STOP forcing the other animation first.

The Cap'm (Reese) 05-Mar-20 02:12 PM

Is frogkick the S animation?

V A H K I T I 05-Mar-20 02:12 PM

Otherwise you have shit like damage cancelling

I would assume so

That's what Gali does

A frock kick

The Cap'm (Reese) 05-Mar-20 02:12 PM

frock

V A H K I T I 05-Mar-20 02:13 PM

You know what I mean. :v

V A H K I T I 05-Mar-20 03:07 PM

@The Cap'm (Reese) ( ͡° ͜ʖ ͡°)

Attachment: Fast3TheMovie.mp4 (17.35 MB)

Ondrik🅱 (Ondrej) 05-Mar-20 03:07 PM

speedrunning intensifies

V A H K I T I 05-Mar-20 03:09 PM

Attachment: 2020-03-05_15-08-42.mp4 (16.45 MB)

~~TOO MANY PUs~~

Ondrik🅱 (Ondrej) 05-Mar-20 03:09 PM

V A H K I T I 05-Mar-20 03:11 PM

~~Gee, I didn't know Gali had the Kakama Nuva in this game~~ ( ͡° ͜ʖ ͡°)

Attachment: 2020-03-05_15-10-22.mp4 (11.04 MB)

Ondrik🅱 (Ondrej) 05-Mar-20 03:11 PM

good embed discord

V A H K I T I 05-Mar-20 03:11 PM

Embedded fine on my end

Ondrik🅱 (Ondrej) 05-Mar-20 03:11 PM

0:00 / 0:00

V A H K I T I 05-Mar-20 03:13 PM

???????????????????????????????

Attachment: 2020-03-05_15-12-56.mp4 (4.89 MB)

o h

Attachment: 2020-03-05_15-16-37.mp4 (17.74 MB)

I think I confirmed jump height is also movelist controlled. :v

Fucking DESTROYED

Attachment: 2020-03-05_15-19-18.mp4 (19.72 MB)

sweg (Andrew) 05-Mar-20 03:32 PM

~~is gali luigi~~

The Cap'm (Reese) 05-Mar-20 04:40 PM

Mega oof

🌻 sher1bot! 🌺 05-Mar-20 04:57 PM

OMG

The Cap'm (Reese) 05-Mar-20 05:00 PM

when you get time

can you check if height of ledge grab is also determined like that

V A H K I T I 07-Mar-20 07:12 PM

I mean I imagine it is, but I don't think that's what's wrong with Voriki and the Kaita.

Especially Voriki because for all intents and purposes he's literally just a reskin of Tahu.

Same basic model and skeletal structure, same animations, same data files, etc.

I think there's a deeper issue there somewhere.

V A H K I T I 08-Mar-20 12:20 PM

beep

🌻 sher1bot! 🌺 08-Mar-20 12:29 PM

boop

Ondrik🅱 (Ondrej) 08-Mar-20 12:41 PM

biip

The Cap'm (Reese) 08-Mar-20 04:10 PM

SuS

The Cap'm (Reese) 19-Mar-20 07:21 PM

so uh

I guess by the luck of a blue moon or some shit, I just completed MBCH in the alpha

boulder actually fell when I pushed it

door's open, matoran moved just like they did when we ported the area (though the fourth one actually vanished properly)

The Cap'm (Reese) 19-Mar-20 07:41 PM

On a partially related side note, figured out what the geysers in GL3S are for

Provided they're working, they kill when in proximity

V A H K I T I 19-Mar-20 07:42 PM

️

The Cap'm (Reese) 19-Mar-20 07:44 PM

You say, stuff is way, Way to go, Go away. Who had you was? I yes you would, It was catastro-, catastro-feeling good.

The Cap'm (Reese) 20-Mar-20 05:39 PM

okay so I'm not sure yet but I may have found something odd in alpha lev3

yup okay this is a thing

fuckn obs

hold on

V A H K I T I 20-Mar-20 05:48 PM

?

The Cap'm (Reese) 20-Mar-20 06:19 PM

Well since OBS is fucking with me rn I'll just explain

So GLY1

I've long wondered why it's called that considering there's no glyph there

You get the stone hammer at the end, not the stone rain

After a playthrough today, I figured it out. There's a spot that, if you pass it, the stone rain is automatically given to you

It's past where the runner stops, right before what is, in the beta, a tunnel

V A H K I T I 20-Mar-20 07:25 PM

Huh

The Cap'm (Reese) 20-Mar-20 07:27 PM

Yeah it's weird

This is the only spot in the game where you don't get the glyph via a pickup afaik

Presumably it's a trigger

The Cap'm (Reese) 20-Mar-20 10:51 PM

Attachment: 2020-03-20_21-50-20.mp4 (3.37 MB)

keep in mind I'm mashing E the entire time here

(aka the power switch key)

ShadowDraikana 21-Mar-20 12:35 AM

nani

i need to look at that

The Cap'm (Reese) 21-Mar-20 12:43 AM

yea 'ss weird

The Cap'm (Reese) 21-Mar-20 01:24 PM

Okay so

via some inferences and texture/code searching

I fixed Mr. Windy's textures here

Attachment: 2020-03-21_12-19-34.mp4 (4.46 MB)

his code for the two projectiles that were white squares referenced "sticks" and "rocks" folders, with one-frame stick_ and rock_ textures

which, of course, no longer exist as of this build

However, the flyingdebris texture he uses in the final notably has sticks flying around in it, and there is an unused sprite animation of a boulder

Putting two and two together, he now no longer throws white squares

On a related side note, it is actually impossible to kill Dave here. Nothing calls his playextro method, unlike the hydra

The Cap'm (Reese) 21-Mar-20 04:51 PM

@Ondrik🅱 (Ondrej) Had time so I finally got around to doing this

Ondrik🅱 (Ondrej) 21-Mar-20 04:51 PM

rip the timesave, but it was cheap anyway

I mean, even I called for its removal

that should show

The Cap'm (Reese) 21-Mar-20 04:54 PM

Pushed to clusterfuck, will get a main branch for it in just a sec

pr is up for main

The Cap'm (Reese) 21-Mar-20 07:15 PM

so in conclusion I did lev5 stuff today

~~are you proud of me @V A H K I T I~~

V A H K I T I 21-Mar-20 07:35 PM

nice :p

The Cap'm (Reese) 21-Mar-20 07:36 PM

~~I gave Dave his attacks and his last name~~

~~that is nice~~

really though, the alpha refers to him as "Mr. Windy"

V A H K I T I 21-Mar-20 07:36 PM

The Cap'm (Reese) 21-Mar-20 07:37 PM

leaving the official boss names as:

Vatuka-Nui Hydra Rocky Snowman Mr. Windy Puff the Magic Dragon

this has been my contribution for today

V A H K I T I 21-Mar-20 07:46 PM

I may make an attempt at something after if there's anything for me to work on. @ShadowDraikana What's on your plate right now?

The Cap'm (Reese) 21-Mar-20 07:47 PM

well the new Amana Volo model you mentioned before

V A H K I T I 21-Mar-20 07:49 PM

True, and I did make an attempt at it. Though unless I get a better idea of what some of the other parts are, it doesn't look particularly good so far.

The Cap'm (Reese) 21-Mar-20 07:50 PM

oof

how about GLY15's thermals? What was the last thing we did with those?

V A H K I T I 21-Mar-20 07:51 PM

Well I'd like to consolidate work to level 2 where at all possible

I want to get that patch done

The Cap'm (Reese) 21-Mar-20 07:51 PM

just saying since it's on the current patch additions list

Hmm...maybe you could design the underwater hive so we can get underwater invasion Rahi going?

you're good at designing things right?

V A H K I T I 21-Mar-20 07:53 PM

Idk am I? .-.

The Cap'm (Reese) 21-Mar-20 07:54 PM

~~you already have a couple textures to work with and it's something to do~~

V A H K I T I 21-Mar-20 07:56 PM

True.

The Cap'm (Reese) 21-Mar-20 07:56 PM

If not, just look at the trello and see if there's anything that strikes your fancy

V A H K I T I 21-Mar-20 08:10 PM

Yeah, I want to work on something but I'm back in that weird shitty headspace again. >->

The Cap'm (Reese) 21-Mar-20 08:10 PM

V A H K I T I 21-Mar-20 08:10 PM

?

The Cap'm (Reese) 21-Mar-20 08:11 PM

shit headspace not good

not good at all

The Cap'm (Reese) 22-Mar-20 01:14 AM

Added the text for the swimming tutorial totem and the two Rau hints to the slb (and translation doc); pushing now

If we still have the totem model with the custom texture for Gali's level on it I can get that into BECH tomorrow (the model, at least; I don't really know how to set up totem conversations) (edited)

now I'm really done for the night

The Cap'm (Reese) 22-Mar-20 01:33 PM

Okay I was going to save this suggestion until we focus on lev3, but could we move RKFL so that it's not right after VLLG? It's a major annoyance right off the bat in the level, and it was around SHRN back in the alpha.

V A H K I T I 22-Mar-20 01:33 PM

Sure

The Cap'm (Reese) 22-Mar-20 01:35 PM

I was thinking between XROD and SHRN

(After the Kakama platforming section)

V A H K I T I 22-Mar-20 01:37 PM

Could work

Ondrik🅱 (Ondrej) 22-Mar-20 01:37 PM

I mean, changing the position in the level won't change how much of an annoyance it is

V A H K I T I 22-Mar-20 01:40 PM

The biggest issue with it and snfl is how long it takes.

I think we just need to decrease the amount of boulders it takes to open the door

The Cap'm (Reese) 22-Mar-20 01:40 PM

It's a timer, not boulders shot

Ondrik🅱 (Ondrej) 22-Mar-20 01:40 PM

it's not boulders

it's time

V A H K I T I 22-Mar-20 01:40 PM

Well decrease that then

Ondrik🅱 (Ondrej) 22-Mar-20 01:40 PM

around a minute and ten seconds until you can just barely fit through

V A H K I T I 22-Mar-20 01:41 PM

Yeah that's way too much

I'd say at MAXIMUM it should be 30 seconds

The Cap'm (Reese) 22-Mar-20 01:41 PM

My point is that it's so early in the level that it immediately puts off the player

Ondrik🅱 (Ondrej) 22-Mar-20 01:41 PM

yeah, that's true

V A H K I T I 22-Mar-20 01:42 PM

Well either way we should decrease that timer.

Cause as Ondrik says, moving it doesn't stop it from being a pain in the mask.

The Cap'm (Reese) 22-Mar-20 01:42 PM

Putting it later gives more of a curve than a sharp spike in difficulty/annoyance followed by more normal stuff

And I agree with the timer shortening

100% (edited)

I still want it moved tho

V A H K I T I 22-Mar-20 01:43 PM

I mean yeah go for it.

The Cap'm (Reese) 22-Mar-20 01:44 PM

Cool. I'll do that today.

Ondrik🅱 (Ondrej) 22-Mar-20 01:44 PM

I really need to play this game again and get used to all the changes

The Cap'm (Reese) 22-Mar-20 01:44 PM

Anyone got that old totem model we made for VLLG when the horns were bound to Q btw? I wanna put that in BECH for the swimming tutorial

I wanna get a couple things done before we're all ready to focus on TP03

V A H K I T I 22-Mar-20 01:48 PM

Is it not still just in the blk?

Apparently not

~~Fuck, the one time we should have been as messy as Saffire~~

The Cap'm (Reese) 22-Mar-20 01:49 PM

I think we kept the texture in the lev2 blk IIRC

V A H K I T I 22-Mar-20 01:49 PM

Well it's still in that one alpha area, right?

Ondrik🅱 (Ondrej) 22-Mar-20 01:49 PM

I should have it still

The Cap'm (Reese) 22-Mar-20 01:49 PM

well yes and no

There is a totem in GLY2

but it has a stone wall texture on it

V A H K I T I 22-Mar-20 01:50 PM

I mean if it's the same model you can just open the dae file in notepad and change the texture path

The Cap'm (Reese) 22-Mar-20 01:50 PM

If memory serves we made the texture for this totem

Oh?

V A H K I T I 22-Mar-20 01:50 PM

No, it's an unused texture from the alpha IIRC

And yea, that's why I like dae files.

Part of the old process for getting Walker's models game-ready before was opening them in Notepad and redefining the default definition of a meter. :p

Ondrik🅱 (Ondrej) 22-Mar-20 01:51 PM

I have it

1.1 (edited)

V A H K I T I 22-Mar-20 01:51 PM

Nice

The Cap'm (Reese) 22-Mar-20 01:51 PM

send plz

Ondrik🅱 (Ondrej) 22-Mar-20 01:51 PM

old VLLG2

Attachment: vllg.blk (1.41 MB)

need the texture too?

The Cap'm (Reese) 22-Mar-20 01:51 PM

thank

shouldn't

Ondrik🅱 (Ondrej) 22-Mar-20 01:51 PM

np

this is why I keep an archive of the old versions

The Cap'm (Reese) 22-Mar-20 02:17 PM

rkfl is pushed, moving on to sign placing now

V A H K I T I 22-Mar-20 02:18 PM

Nice

@ShadowDraikana Feel like doing a convo real quicc?

The Cap'm (Reese) 22-Mar-20 02:22 PM

Could be as simple as copy/paste depending

Would have to check how many lines Onua's totems have (edited)

This one has 6

The Cap'm (Reese) 22-Mar-20 02:37 PM

This a good position?

V A H K I T I 22-Mar-20 02:38 PM

Ye

The Cap'm (Reese) 22-Mar-20 02:38 PM

k

V A H K I T I 22-Mar-20 02:39 PM

Or maybe place it before the spot of water you HAVE to go through

The Cap'm (Reese) 22-Mar-20 02:39 PM

...is that a "do this instead" or a suggestion

cuz my hand was on the push button right before you sent that

V A H K I T I 22-Mar-20 02:40 PM

It is a suggestion. Just thinking closer to here might be better

The Cap'm (Reese) 22-Mar-20 02:40 PM

no I know what you mean

just whether or not it was a "dew it" or a "maybe"

V A H K I T I 22-Mar-20 02:41 PM

For that matter, I would suggest this area get a bit of a redesign as part of the bech overhaul.

It's a bit of a stark right angle to get where you need to go through the water and it's not super obvious until you're already in the water.

I don't like that the game is introducing a new mechanic without making the destination visible.

The Cap'm (Reese) 22-Mar-20 02:43 PM

V A H K I T I 22-Mar-20 02:43 PM

Like you literally jump in the water just to make a big 180 and get out again

The Cap'm (Reese) 22-Mar-20 02:43 PM

~~I know, I've played this a thousand times~~

that a good position for the totem

V A H K I T I 22-Mar-20 02:44 PM

It is for now, but I'd say given this it's subject to change

The Cap'm (Reese) 22-Mar-20 02:44 PM

well yeah

V A H K I T I 22-Mar-20 02:45 PM

Bold idea: What if we cleaned up and enclosed this area a bit more then made it the spawn point?

The Cap'm (Reese) 22-Mar-20 02:45 PM

I already was wary of putting it over here due to the archway I grayboxed before

wut

V A H K I T I 22-Mar-20 02:45 PM

?

The Cap'm (Reese) 22-Mar-20 02:45 PM

explain

V A H K I T I 22-Mar-20 02:45 PM

What.. is there to explain? :v (edited)

The Cap'm (Reese) 22-Mar-20 02:45 PM

Your idea?

V A H K I T I 22-Mar-20 02:46 PM

I just said the idea

The Cap'm (Reese) 22-Mar-20 02:46 PM

Yeah. And I don't get what you mean exactly.

V A H K I T I 22-Mar-20 02:47 PM

I literally don't know how to explain it any clearer than the original area.

Cleaning up this beach instead of the other one and spawning here puts the areas you need to go to into a much more direct perspective, and could allow us to fill the original spawn area with more optional things. It is otherwise an unnecessarily large area with little more than 2 crabs

The Cap'm (Reese) 22-Mar-20 02:48 PM

See that's a better explanation.

But then brings up the question of MTUP to here

how they fit together

V A H K I T I 22-Mar-20 02:49 PM

What about it?

The Cap'm (Reese) 22-Mar-20 02:50 PM

Wasn't the idea before to merge MTUP and BECH?

V A H K I T I 22-Mar-20 02:51 PM

MTUP is goin to need a metric fuckton of cleanup to be anywhere near the quality of Bech. If @Grampa Walker is up to it, I'm sure he can find a way, but at the moment I think it's a bit too large an undertaking considering how much we already have to do that is a lot more necessary.

The Cap'm (Reese) 22-Mar-20 02:52 PM

Taking that off the trello card, then

V A H K I T I 22-Mar-20 02:52 PM

Or just move it to future patches

If we want to get this out anytime soon, I do think we need to start cutting things that aren't necessarily within the scope of revitalizing level 2.

Things like TTUN additions for instance are 100% necessary.

Things like MBCH can, if they continue to be a pain in the ass, be put off to the side for now.

Ideally I'd like to get this patch out in approximately the next month and a half, but that all depends on how everyone else's schedules and motivations line up.

The Cap'm (Reese) 22-Mar-20 02:55 PM

in that case, you should go over the trello again and move things to other patch lists to slim it down

V A H K I T I 22-Mar-20 02:55 PM

I plan to as soon as I finish my character modelling final

The Cap'm (Reese) 22-Mar-20 02:55 PM

i already moved GLY15 to the lev5 list yesterday

totem is pushed btw

UTTER_BODGE 22-Mar-20 03:00 PM

and there is an unused sprite animation of a boulder

on one hand I feel like the boulder doesn't really fit the environment, on the other hand I don't have any better ideas

The Cap'm (Reese) 22-Mar-20 03:00 PM

i mean

as I said, he was supposed to throw a rock according to the code

and the fact this boulder animation exists in the beta like the flyingdebris (which I infer evolved from the "stick" he was coded to throw judging by the sprites) leads me to believe that the boulder goes here

V A H K I T I 22-Mar-20 03:03 PM

Who's throwing a rock? What did I miss?

The Cap'm (Reese) 22-Mar-20 03:04 PM

The alpha Air Elemental?

The video I posted yesterday?

V A H K I T I 22-Mar-20 03:04 PM

o

The Cap'm (Reese) 23-Mar-20 06:37 PM

Okay, how the fuck do collision boxes work

I'm trying to fix the lava pillars in TA10

I can change the big rectangle's size by changing the Y value of either collision point, but changing the X or Z values don't do jack shit

unless someone else wants to try their hand at making these things not suck ass I propose we remove them for now

The Cap'm (Reese) 23-Mar-20 07:11 PM

On a not really related but also kind of related note, this looks wrong...

Attachment: 2020-03-23_18-10-33.mp4 (4.53 MB)

sweg (Andrew) 23-Mar-20 07:14 PM

bonkle lava

V A H K I T I 24-Mar-20 02:29 AM

What is it that sets the collision for those anyways?

Or do we not know?

Also yeah, that's an easy fix. It's literally just fucked up UVs.

One side of the falls has a seam and the UVs on the opposite side of the seam are flipped.

For texture scrolling to be consistent, the UVs have to at least be facing the same direction.

Tl;dr:

Put it on the to-do list and I'll fix it tomorrow

The Cap'm (Reese) 24-Mar-20 10:42 AM

The collision afaik is defined by the box you can edit in unity

There's code in the puzzle class to hurt you if you touch the box

I don't know if something in that code is messing up the box or if it's an exe thing

If we had the visual debugger in the alpha I could check of it renders the boxes any different

V A H K I T I 24-Mar-20 02:17 PM

Well @ShadowDraikana successfully made Alpha LSS work, maybe she can get this working as well?

The Cap'm (Reese) 24-Mar-20 02:30 PM

Reminder to fix TA12 thing above

V A H K I T I 24-Mar-20 02:30 PM

yeet

The Cap'm (Reese) 24-Mar-20 02:31 PM

Anyways, for these pillars, if we can't figure them out in a quick amount of time, I say we cut them for this patch and leave them for the lev6 patch later on (edited)

V A H K I T I 24-Mar-20 02:31 PM

I mean we should be doing that anyways tbh

The Cap'm (Reese) 24-Mar-20 02:32 PM

?

Oh I get it nvm

V A H K I T I 24-Mar-20 02:32 PM

We're supposed to be doing these patches in sequence. Going off the rails down rabbit holes in other levels is only causing us delays and providing us less content to add when we get to them proper.

The Cap'm (Reese) 24-Mar-20 02:34 PM

In that case I'll cut them from the obj slb and attempt to comment their code out for now

V A H K I T I 24-Mar-20 02:39 PM

aight

The Cap'm (Reese) 24-Mar-20 02:56 PM

If I fail the commenting part i will ask for help

The Cap'm (Reese) 24-Mar-20 03:44 PM

okay nope I don't know how to properly comment this out

obj slb is done at least

Thinking on it, we should probably take out the fireballs as well

until the lev6 patch

so if I could get some help on that commenting that stuff out that'd be cool

ShadowDraikana 24-Mar-20 03:54 PM

dm me

V A H K I T I 24-Mar-20 03:55 PM

Why does this have to be done via DMs? :v

UTTER_BODGE 24-Mar-20 04:07 PM

Okay, how the fuck do collision boxes work I'm trying to fix the lava pillars in TA10 I can change the big rectangle's size by changing the Y value of either collision point, but changing the X or Z values don't do jack shit

The collision afaik is defined by the box you can edit in unity There's code in the puzzle class to hurt you if you touch the box

@The Cap'm (Reese) ok so

two things going on here

a) 99% of the time those collision boxes aren't used for anything but for checking if the game should activate collision checks against the real mesh/shape of the object

checking if something collides with a box is cheap, checking if something collides with a complex shape of a model is not - so they have a box surrounding the models

and if you're inside that, then they do the expensive collision check against the model itself

this is the first time I'm hearing of the game using the box itself for any other purpose.... which is a problem, because

b) like trigger boxes, these boxes must be cubes

and the game will make them cubes if they're not

i.e. whatever the tallest/widest/longest section of the box is, all the shorter sides will be expanded out in-game to match

The Cap'm (Reese) 24-Mar-20 04:10 PM

well considering these are pillars that's a pisser

UTTER_BODGE 24-Mar-20 04:10 PM

yyyyyep

the best solution would be to use some entirely different means of checking for collision with them

is there any way to make it check against the actual shape, not the surrounding box?

The Cap'm (Reese) 24-Mar-20 04:10 PM

Or we could just make them part of the lava model and have them kill via that instead of coding

ShadowDraikana 24-Mar-20 04:10 PM

i'm trying to figure out how this even works atm

this area's code uses a metric fuckton of variables

The Cap'm (Reese) 24-Mar-20 04:11 PM

~~i just want to comment this stuff out~~

ShadowDraikana 24-Mar-20 04:11 PM

38 to be exact

which is

insane

The Cap'm (Reese) 24-Mar-20 04:11 PM

~~my brain hurts too much to do this today~~

UTTER_BODGE 24-Mar-20 04:12 PM

Or we could just make them part of the lava model and have them kill via that instead of coding

I think handling it the same way as normal lava is probably the best call

at least off the top of my head

The Cap'm (Reese) 24-Mar-20 04:14 PM

in that case nuking the pillar code entirely and commenting out the boulders for now would be the ideal solution

ShadowDraikana 24-Mar-20 04:15 PM

y'know

just making those pillars as part of the bcl would solve a whole lot i would think. now why did saffire not do it this way

1. because saffire or 2. there's a legitimate reason for them doing this (edited)

V A H K I T I 24-Mar-20 04:17 PM

I mean presumably they aren't supposed to instantly kill you

The Cap'm (Reese) 24-Mar-20 04:17 PM

considering how much damage they do it's damn close

UTTER_BODGE 24-Mar-20 04:17 PM

hmm

V A H K I T I 24-Mar-20 04:17 PM

Temporary for testing

ShadowDraikana 24-Mar-20 04:17 PM

considering contact with lava instantly kills you anyway

UTTER_BODGE 24-Mar-20 04:18 PM

to me it seems weird to not be instakill but

I haven't tried it first hand

V A H K I T I 24-Mar-20 04:18 PM

I mean they are pretty numerous

UTTER_BODGE 24-Mar-20 04:18 PM

so idk what the difficulty is like

I guess we could spam and stack smaller cube triggers and rig that up via scripting

if that was the idea

ShadowDraikana 24-Mar-20 04:33 PM

...the fireballs are kaput right

The Cap'm (Reese) 24-Mar-20 04:35 PM

they don't move

ShadowDraikana 24-Mar-20 04:38 PM

i can tell you why

the array for them is literally empty

V A H K I T I 24-Mar-20 04:39 PM

I mean to be fair this is a BLATANTLY unfinished level

And it was cut

ShadowDraikana 24-Mar-20 04:39 PM

they have class references in the onevent code

The Cap'm (Reese) 24-Mar-20 04:39 PM

which is a CRIME

V A H K I T I 24-Mar-20 04:39 PM

That's what we're here for

ShadowDraikana 24-Mar-20 04:39 PM

as in stuff that would reference the code within the associated fireball class

but they left the array dummied out

ffs saffire

why the hell did they leave that blank, there's no excuse for that

V A H K I T I 24-Mar-20 04:40 PM

My question is why do they have their own class in the first place?

Are these not meant to just function like BLDR?

ShadowDraikana 24-Mar-20 04:40 PM

because there's a fuckton of code involved for them?

i'm not going to rip this stuff out just because we think everything needs to fucntion like fucking bldr

if that's how it's SUPPOSED to work then yeah

The Cap'm (Reese) 24-Mar-20 04:41 PM

I think that was a question, not a "make it like BLDR"

V A H K I T I 24-Mar-20 04:41 PM

It was a question but now it's appended with an "Ash needs to fuckin chill".

(edited)

~~Get yo Pink Diamond transformation out of here~~

ShadowDraikana 24-Mar-20 04:42 PM

boi

The Cap'm (Reese) 24-Mar-20 04:42 PM

~~i don't get that reference wut~~

V A H K I T I 24-Mar-20 04:43 PM

~~If you shatter me, I'm not bowing to you~~

The Cap'm (Reese) 24-Mar-20 04:43 PM

~~is that the same reference or something else~~

ShadowDraikana 24-Mar-20 04:44 PM

that'd be steven universe i believe. which i don't pay any attention to

The Cap'm (Reese) 24-Mar-20 04:44 PM

oh

V A H K I T I 24-Mar-20 04:44 PM

F

The Cap'm (Reese) 24-Mar-20 04:44 PM

is that show still going

ShadowDraikana 24-Mar-20 04:44 PM

apparently

The Cap'm (Reese) 24-Mar-20 04:44 PM

never really watched it past one or two episodes when it first came on

but anyways TA10

ShadowDraikana 24-Mar-20 04:49 PM

any cut areas that had fireballs

aside from this one

The Cap'm (Reese) 24-Mar-20 04:49 PM

TP02

if you land on the center platform a fireball falls down one of the lavafalls

So are we not cutting the fireballs? If not I need to redo the obj slb

?

ShadowDraikana 24-Mar-20 05:01 PM

idk

The Cap'm (Reese) 24-Mar-20 05:02 PM

well it's important to know considering we need to get back to more important matters (lev2 and TP03)

The Cap'm (Reese) 24-Mar-20 05:49 PM

good talk :v

ShadowDraikana 24-Mar-20 06:49 PM

i'm not up to speed on what the plan even is here and if i was i've forgotten

The Cap'm (Reese) 24-Mar-20 06:49 PM

well the plan is to have them fall

like they seem to be intended to

but if that can't be done quickly we dummy them out and move on to more important things for 1.1

V A H K I T I 24-Mar-20 08:02 PM

ye

The Cap'm (Reese) 24-Mar-20 08:07 PM

Soooooooooooooooooooooooo

Can it be done quickly or do we comment it all out for now

The Cap'm (Reese) 24-Mar-20 08:29 PM

Regardless I'm keeping a copy of the old obj slb in the blk for future reference

V A H K I T I 24-Mar-20 08:42 PM

Idk. Depends what Ash hgas to say

In the meantime I'd focus on level 2

The Cap'm (Reese) 24-Mar-20 10:07 PM

Well what can I do, o wise liam

The Cap'm (Reese) 24-Mar-20 10:35 PM

Send me a message, dear prophet, to what path I should follow

Elucidate my purpose, o seer of progress

V A H K I T I 24-Mar-20 10:38 PM

Whatever you like really. The trello is as good a leader as I am right now. :v

It's been so long since I've actually had to coordinate anything here I've kinda lost my edge. Gotta ease back into it. :p

The Cap'm (Reese) 24-Mar-20 10:38 PM

Yeah uh, mostly model stuff.

Which I am in no way qualified for

V A H K I T I 24-Mar-20 10:39 PM

Well if there's nothing for level 2 you can do, feel free to branch out. Just make sure that it doesn't interfere with progress on level 2 if it's a job you can't personally finish.

@ShadowDraikana How are you feeling lately? Your woodshed is growing cobwebs. :p

The Cap'm (Reese) 24-Mar-20 10:52 PM

I'm honestly not sure if there's anything on trello I can do

V A H K I T I 24-Mar-20 11:05 PM

.-.

The Cap'm (Reese) 24-Mar-20 11:06 PM

Hey, if you see anything on there I have the skillset to do go right ahead and tell me; I'm not seeing anything.

The Cap'm (Reese) 24-Mar-20 11:36 PM

still need to reorganize that anyways

V A H K I T I 24-Mar-20 11:36 PM

Well that's something for the time being

The Cap'm (Reese) 24-Mar-20 11:36 PM

what is

V A H K I T I 24-Mar-20 11:36 PM

reorganizing

The Cap'm (Reese) 24-Mar-20 11:37 PM

I mean, that's your job.

Setting priorities for what to get done for 1.1

you said you'd do that post-character design final

V A H K I T I 24-Mar-20 11:38 PM

true

ShadowDraikana 25-Mar-20 10:59 AM

ok so

fireballs today

keep or no keep

for ta10

replaced the ancient music code and cleaned up the area class a bit. haven't touched anything else yet

The Cap'm (Reese) 25-Mar-20 11:47 AM

@ShadowDraikana

ShadowDraikana 25-Mar-20 12:12 PM

i'll go hook them up then

ShadowDraikana 25-Mar-20 12:45 PM

PFF

saffire called the setsurfmode method twice in the initfull method

The Cap'm (Reese) 25-Mar-20 12:46 PM

oof

ShadowDraikana 25-Mar-20 12:46 PM

redundant cleanup code too

setsurfmode was set up in a way to allow turning surfing on and off by calling it with an argument or not

so saffire called that

turned surfing off, setsplitanimation, etc. then immediately did the same thing again in the cleanup

looks like someone got interrupted in scripting this area the more i look at it

...why are there two tp03 area classes

oh there's one for lev8

The Cap'm (Reese) 25-Mar-20 12:53 PM

you can cut that since we're moving it to lev6 again

ShadowDraikana 25-Mar-20 12:54 PM

aight

was the area blk for it removed from the lev8 assets along with the makefile

The Cap'm (Reese) 25-Mar-20 01:02 PM

I took it out of the makefile back when I ported it over to lev6

ShadowDraikana 25-Mar-20 01:03 PM

aight. i take it the blk was removed too or was just the makefile updated

went ahead and pushed the code removal for it from lev8

The Cap'm (Reese) 25-Mar-20 01:03 PM

pretty sure I moved the folder entirely

ShadowDraikana 25-Mar-20 01:03 PM

ahh

meanwhile

wtf is this bullshit

the same exact code

repeated and assigned to different variables

correct me if i'm wrong but this could be handled with ONE variable not THIRTY-SEVEN (edited)

and give that var as the second argument for items within the following array

ShadowDraikana 25-Mar-20 01:17 PM

that somewhat simplifies the class a bit

benji 25-Mar-20 01:28 PM

well that code assigns a different random number to each variable there

ShadowDraikana 25-Mar-20 01:30 PM

oh fuck yeah that's right

benji 25-Mar-20 01:31 PM

however, repeating with a while loop would be much more elegant

ShadowDraikana 25-Mar-20 01:31 PM

if i only use one it's using the same number for all of them

benji 25-Mar-20 01:31 PM

right

V A H K I T I 25-Mar-20 01:32 PM

Well well well, looks like somebody's getting their groove back. Nicely done so far Ash.

ShadowDraikana 25-Mar-20 01:34 PM

@benji how would you propose i set up a while loop for this

if i can compact this down as much as possible that'd make this a hell of a lot cleaner

benji 25-Mar-20 01:35 PM

well I'd need to see how the random values are used

ShadowDraikana 25-Mar-20 01:36 PM

they're used for timer values and assigned to different timers themselves in an array

the start of which is in that screenshot

basically repeats for 37 different timers

benji 25-Mar-20 01:41 PM

well but I need to see the code to tell you how to use a loop

ShadowDraikana 25-Mar-20 01:44 PM

clusterfuck-branch-take-two, ta106_puzzle class

is where this is

just pushed some edits to it

benji 25-Mar-20 01:55 PM

So you'd replace lines 113-186 with a loop, like so:

this.timerarray = [ ]; // Create empty array var i = 0; // Stores which iteration of the loop we are in while (i < 37) { var timername = "wt"; // We need to pad the single digit timers with an extra '0', // so that 'wt2' becomes 'wt02' if (i <= 9) { timername = timername + "0"; } timername = timername + __tostring(i); this.timerarray.__append(new lego_timer(timername, globalclass.randnum.getrandomfloat(3.0, 4.5), 0)); i = i + 1; }

(edited)

If you don't care what the timers are named, you can remove the middle segment about padding the timer names

Oh, and it looks like you can merge the loop that calls initfull on the timers into the loop I just posted

ShadowDraikana 25-Mar-20 01:58 PM

awesome

benji 25-Mar-20 01:59 PM

oh wait, don't use that

ok fixed

(You need the i = i + 1 to not cause an infinite loop)

(Man I wish LSS had a normal for loop)

ShadowDraikana 25-Mar-20 02:00 PM

yeah i was going to ask if i needed that thing on the end since every other while loop has it

oh yeah can i axe all those variables at the start of initfull now or do we still need those here outside of 38

benji 25-Mar-20 02:10 PM

if var1 through var37 aren't used anywhere else then they can be deleted

ShadowDraikana 25-Mar-20 02:18 PM

cool

i'll keep this while loop in mind for future use elsewhere, particularly for cycling through ids like that

Ondrik🅱 (Ondrej) 25-Mar-20 02:25 PM

Question

so I finally got the unity editor and how exactly does this work?

This is where I am now

UTTER_BODGE 25-Mar-20 02:29 PM

I'm heading to work right now but

see the readme on the project's main page

Ondrik🅱 (Ondrej) 25-Mar-20 02:30 PM

I have no Manager object

V A H K I T I 25-Mar-20 02:30 PM

Anything I an do to be of help right now friends? I'm not really doing much.

@ShadowDraikana

The Cap'm (Reese) 25-Mar-20 02:30 PM

did you even get the project

you need to open the scene in the project

ShadowDraikana 25-Mar-20 02:31 PM

not much at the immediate moment

V A H K I T I 25-Mar-20 02:32 PM

Aight, keep me posted

ShadowDraikana 25-Mar-20 02:32 PM

trying to figure out what the hell is up with the blank fireball array and what saffire was doing

V A H K I T I 25-Mar-20 02:32 PM

@Grampa Walker You busy today?

ShadowDraikana 25-Mar-20 02:32 PM

one other side question about ta10

do we want the music to restart upon death

The Cap'm (Reese) 25-Mar-20 02:32 PM

no

ShadowDraikana 25-Mar-20 02:32 PM

thought so

Ondrik🅱 (Ondrej) 25-Mar-20 02:33 PM

okay, I opened the scene, that was the issue. And now I'm getting this

ShadowDraikana 25-Mar-20 02:35 PM

and pushed

music will play continuously instead of stopping and restarting

fixed some more redundancies with the kill/unkill code for that matter

The Cap'm (Reese) 25-Mar-20 02:36 PM

so do them boulders work now

I'll commit my no-pillars object slb

ShadowDraikana 25-Mar-20 02:38 PM

they're set up as moveable objects in the tp02 class

tf

i still love this btw

Ondrik🅱 (Ondrej) 25-Mar-20 02:47 PM

lol

sometimes I'm extremely baffled by all the work that we've collectively put into this

ShadowDraikana 25-Mar-20 02:49 PM

i'm baffled how i didn't lose my sanity with the osi back in the asm days

dark times

The Cap'm (Reese) 25-Mar-20 02:49 PM

As am I

benji 25-Mar-20 02:52 PM

You might want to take some time to rename the params there to match what variable they are assigned to

ShadowDraikana 25-Mar-20 02:53 PM

ye

just haven't touched that class in like forever so i haven't done so yet

The Cap'm (Reese) 25-Mar-20 04:09 PM

so how goes the boulders then

The Cap'm (Reese) 25-Mar-20 07:14 PM

good talk :v

ShadowDraikana 25-Mar-20 07:18 PM

they aren't

The Cap'm (Reese) 25-Mar-20 07:21 PM

Wut

ShadowDraikana 25-Mar-20 07:42 PM

as in they aren't going

The Cap'm (Reese) 25-Mar-20 07:43 PM

UTTER_BODGE 25-Mar-20 11:47 PM

@Ondrik🅱 (Ondrej) post a screenshot of the console/log

no way of knowing what's going wrong without that

V A H K I T I 30-Mar-20 05:41 PM

@The Cap'm (Reese) Got the model working with Benji's help. Pushed

The Cap'm (Reese) 30-Mar-20 05:42 PM

Yay

V A H K I T I 30-Mar-20 05:42 PM

I tested it but it apparently spawns me.. inside the chamber with the Tarakava, underwater.

The Cap'm (Reese) 30-Mar-20 05:43 PM

Underwater is probably a code thing

V A H K I T I 30-Mar-20 05:43 PM

Probably a spawnpoint thing too

The Cap'm (Reese) 30-Mar-20 05:43 PM

You set STR0 at the new entrance yes?

V A H K I T I 30-Mar-20 05:43 PM

I did, and this is nowhere near there

The Cap'm (Reese) 30-Mar-20 05:45 PM

There might be a setunderwater in the code upon entering. Check

V A H K I T I 30-Mar-20 05:45 PM

Gonna try that yeah, cause my spawn points are fine.

The Cap'm (Reese) 30-Mar-20 05:46 PM

Actually while you're there

The waterfall on the left there

It has clipping issues in-game

V A H K I T I 30-Mar-20 05:47 PM

Not sure what you mean by "there". I'm not even editing the water

There we go

The Cap'm (Reese) 30-Mar-20 05:47 PM

No I'm not even in the game yet I'm just saying (edited)

V A H K I T I 30-Mar-20 05:47 PM

Nuked all the setunderwater code

The Cap'm (Reese) 30-Mar-20 05:47 PM

Look to the left waterfall from where you are in that screencap

V A H K I T I 30-Mar-20 05:48 PM

Gotta fix this door

Also

both of them have issues

The Cap'm (Reese) 30-Mar-20 05:48 PM

yes

but the left is the most noticable

V A H K I T I 30-Mar-20 05:49 PM

I think I'm gonna clone the entry door for the exit one as well. The stone just looks... bad

The Cap'm (Reese) 30-Mar-20 05:50 PM

i see you changed TAKV's texturing there

V A H K I T I 30-Mar-20 05:50 PM

Not on purpose

I think something got fucked up in Maya

Not surprised.

I'm just gonna do it over.

I forgot to generate a new BCL anyways.

The Cap'm (Reese) 30-Mar-20 05:55 PM

oof

V A H K I T I 30-Mar-20 06:19 PM

And of course. After I do all the work a SECOND TIME Maya fucks it all up AGAIN.

I'm going to work on this tomorrow. I don't have the strength to deal with this shit right now.

No fuck it. I need to get this over with. >->

V A H K I T I 30-Mar-20 06:45 PM

Great, well now it works, but I'm getting a crash I've never seen before.

It's one of those "touch the water and the game fucking explodes" crashes.

@ShadowDraikana Any insight?

The BLK btw.

Attachment: takv.blk (552.52 KB)

ShadowDraikana 30-Mar-20 06:49 PM

what the fuck now

oh those crashes

you haven't seen these?

V A H K I T I 30-Mar-20 06:49 PM

I have seen the effect, but I don't recognize this particular function.

I may just be rusty

ShadowDraikana 30-Mar-20 06:50 PM

what exactly resulted in this

one thing comes to mind right off the bat when you said touch the water and the game fucking explodes

V A H K I T I 30-Mar-20 06:50 PM

I DID just make like 3 incomplete commits in a row.

It could be any number of things given what I edited. But probably due to altering the water model.

I hadn't changed the BCL yet though

ShadowDraikana 30-Mar-20 06:51 PM

that would do it

i had this issue with gali's shrine before

V A H K I T I 30-Mar-20 06:52 PM

Last I remember this was an issue with generating BCLs from models the wrong way, hence why I held off for the moment on doing that.

I take it even the water model itself can cause it?

ShadowDraikana 30-Mar-20 06:53 PM

yup

because water

V A H K I T I 30-Mar-20 06:53 PM

Wonderful. How did you fix it then? (edited)

ShadowDraikana 30-Mar-20 06:53 PM

i think it's due to mtl mismatch

trying to do something with the bcl that doesn't match the model and then implosion

V A H K I T I 30-Mar-20 06:53 PM

.-.

ShadowDraikana 30-Mar-20 06:53 PM

as in material mistmatch

if i'm remember this correctly

it's fucky as hell and sometimes it does work

V A H K I T I 30-Mar-20 06:54 PM

Okay so you're saying I HAVE to generate a new BCL to make this work then

ShadowDraikana 30-Mar-20 06:54 PM

likely

V A H K I T I 30-Mar-20 06:54 PM

How do I do that for water? I vaguely recall it's a stupidly involved process that I previously just shifted to you.

ShadowDraikana 30-Mar-20 06:55 PM

it's because saffire used an incredibly complicated way of handling materials

as in the material slb

ffs where's the pin with this information

V A H K I T I 30-Mar-20 06:56 PM

Probably in the old dev chat

ShadowDraikana 30-Mar-20 06:57 PM

for the love of god the pins got cleared

fml

V A H K I T I 30-Mar-20 06:57 PM

Wot

They absolutely did not

ShadowDraikana 30-Mar-20 06:57 PM

they are not showing up on my end

V A H K I T I 30-Mar-20 06:57 PM

Also apparently I can just generate one from my water model and make it work

Huh

ShadowDraikana 30-Mar-20 06:57 PM

yep exactly what i suspected

V A H K I T I 30-Mar-20 06:59 PM

?

Anyways @The Cap'm (Reese), fixed the water clipping, and merged TAKV with GIZR. It doesn't look pretty at the merge site, but I'll leave that to @Grampa Walker since this area could use with a UV overhaul anyways.

I'll push it now

Done

Go nuts with the cutscene you two. :p

The Cap'm (Reese) 31-Mar-20 10:38 AM

The backtrack trigger to SHRN does not work (edited)

(in takv)

V A H K I T I 31-Mar-20 11:23 AM

Fucc

Does everything else work?

The Cap'm (Reese) 31-Mar-20 11:47 AM

yes

just the trigger

V A H K I T I 31-Mar-20 11:51 AM

weird

V A H K I T I 02-Apr-20 03:39 PM

@ShadowDraikana Are you free?

ShadowDraikana 02-Apr-20 03:40 PM

not at the moment

V A H K I T I 02-Apr-20 03:41 PM

Will you potentially be later today?

ShadowDraikana 02-Apr-20 03:42 PM

maybe

V A H K I T I 02-Apr-20 03:53 PM

Aight, well let me know fren. :p

ShadowDraikana 08-Apr-20 09:05 AM

RE save corruption: ping me when we have hands on deck for this

V A H K I T I 08-Apr-20 11:59 AM

@ShadowDraikana Suuuuup

@JrMasterModelBuilder You busy today?

The Cap'm (Reese) 08-Apr-20 11:59 AM

did you read the rundown of the issue

V A H K I T I 08-Apr-20 11:59 AM

Maybe a quick one

The Cap'm (Reese) 08-Apr-20 12:00 PM

Front End's quit function calls GcSaver

which is a bad thing

ShadowDraikana 08-Apr-20 12:00 PM

i need to specifically kill this call to verify that

within the function itself

which is what i need to know how to do or for someone else to do

i just need one very tiny bit of code bypassed

i want to rule this out in effect

HOWEVER

The Cap'm (Reese) 08-Apr-20 12:02 PM

Essentially what I found yesterday is that save files corrupt once the window closes after you click "Quit" in front end; it doesn't happen if the game force closes (either from a shutdown or Alt+F4)

V A H K I T I 08-Apr-20 12:04 PM

Or if you hit the X presumably

The Cap'm (Reese) 08-Apr-20 12:05 PM

i assume so yes

V A H K I T I 08-Apr-20 12:05 PM

So why can't this be turned off from the OSI if it's being called from a scripted button?

The Cap'm (Reese) 08-Apr-20 12:07 PM

IIRC it's the GcGame::QuitGame function that gets called, and that also calls GcSaver? Is that accurate @ShadowDraikana ?

V A H K I T I 08-Apr-20 12:07 PM

Is there an OSI function that just closes the game? Seems like an easier way to test this.

I mean I can probably nop out the GCSaver call, but I'm not sure it's necessary to go that far

Btw, is this related to Ondrik's bug from yesterday?

The Cap'm (Reese) 08-Apr-20 12:12 PM

I don't believe so no

That was purely test menu

ShadowDraikana 08-Apr-20 12:13 PM

no it's needed to nop it out

the osi calls the function

the function itself is where the fuck up is happening i think

but i need that specific gcsaver call noped out within the function to be sure

V A H K I T I 08-Apr-20 12:17 PM

Well gimmie just one minute and I'll look into it then. Just discussing what to do with an apparent sadist pedophile in the bionicle community with other community leaders right now.

The Cap'm (Reese) 08-Apr-20 12:18 PM

.-.

V A H K I T I 08-Apr-20 12:26 PM

Pff. Well then.

Seems pretty straightforward. :p

Found another small issue already btw.

PTV1 and potentially other areas don't have music, but they don't have code to stop music from frontend or start the music that would have carried over from the previous area on loading a save

The Cap'm (Reese) 08-Apr-20 12:33 PM

yeah we know

that's been a thing forever

V A H K I T I 08-Apr-20 12:34 PM

IIRC we fixed this in another area once before.

For this specific issue we could maybe hijack code from PTOS to make it work.

Ie the "entered from back door" code

THat way we could just say something like "if entered from FREN, play music, else do nothing"

The Cap'm (Reese) 08-Apr-20 12:39 PM

so you got that line out or

V A H K I T I 08-Apr-20 12:39 PM

working on it

Just brushing up on how to do this

ShadowDraikana 08-Apr-20 12:45 PM

ping me with updates

again

just the gcsaver call needs to be skipped

V A H K I T I 08-Apr-20 12:48 PM

Question though

What function does the quit button in the text menu call?

And why can't we just use it here

The Cap'm (Reese) 08-Apr-20 12:48 PM

*test

V A H K I T I 08-Apr-20 12:49 PM

Yes

that

:p

The Cap'm (Reese) 08-Apr-20 12:50 PM

Here's the thing

My theory

The test menu doesn't load an area

Front End does

V A H K I T I 08-Apr-20 12:50 PM

Fair

The Cap'm (Reese) 08-Apr-20 12:50 PM

in fact

tested just now

V A H K I T I 08-Apr-20 12:50 PM

Well I made it skip the call anyways

Just need to run one more test

The Cap'm (Reese) 08-Apr-20 12:50 PM

quitting from the test menu does call the saver

it just doesn't have another area to save so it doesn't overwrite level/area (edited)

V A H K I T I 08-Apr-20 12:51 PM

Sounds about right

Oh yeah another thing we need to look into

How pausing the game and alt tabbing inverts the process

Ie the game will be paused UNLESS the window isn't in focus. (edited)

Then the menu will be up, but the game will be running normally

Ondrik🅱 (Ondrej) 08-Apr-20 12:53 PM

alt tabbing isn't a "full" pause I think

see RKFL and SNFL

V A H K I T I 08-Apr-20 12:54 PM

@ShadowDraikana Try this

Attachment: LEGOBionicle.exe (5.89 MB)

Idk if it'll work, but I tried IDA's patch program to apply the changes to the EXE directly. (edited)

Feel free to test also, Reese.

Just keep an eye on the last modified date of the save you use.

If this worked, it should just hit the GCSaver call, and jump right over it.

Fuck I don't think it worked

Bah

The Cap'm (Reese) 08-Apr-20 12:57 PM

it did not

V A H K I T I 08-Apr-20 12:57 PM

Okay I'll try just nopping it out manually.

V A H K I T I 08-Apr-20 01:04 PM

Done

Attachment: LEGOBionicle.exe (5.89 MB)

That didn't need to be as difficult as I was originally making it

:p

I just nopped out the call and left everything else.

Tested, and it doesn't save on quitting

So it should get the job done

The Cap'm (Reese) 08-Apr-20 01:08 PM

yup works

save is uncorrupted

benji 08-Apr-20 01:08 PM

thought: If you disable saving from the frontend, will that disable saving settings changes?

V A H K I T I 08-Apr-20 01:09 PM

I'm not certain. Does GcSaver handle that?

The Cap'm (Reese) 08-Apr-20 01:09 PM

nope, setting save fine

Tested by turning off music and quitting out

music is still off on reload

1

V A H K I T I 08-Apr-20 01:10 PM

nice

The Cap'm (Reese) 08-Apr-20 01:11 PM

so that's fixed, then

V A H K I T I 08-Apr-20 01:11 PM

Yeah I guess is is, isn't it? There really isn't any downside to this if settings aren't saved.

The only thing that will be lost is progress in a specific area.

The Cap'm (Reese) 08-Apr-20 01:12 PM

?

V A H K I T I 08-Apr-20 01:12 PM

Well let's say you finish an invasion but quit before leaving the room.

That progress won't be saved

We'll have to add a GcSaver call to the pause menu quit button to remedy that

The Cap'm (Reese) 08-Apr-20 01:12 PM

also the settings are saved

so

V A H K I T I 08-Apr-20 01:13 PM

So..?

Oh right

I misspoke

:p

The Cap'm (Reese) 08-Apr-20 01:13 PM

V A H K I T I 08-Apr-20 01:13 PM

I meant are saved

Point is, we'll need to add a save call to the pause menu if we want this to really be fixed

The Cap'm (Reese) 08-Apr-20 01:13 PM

said save call will have to happen before area transition

V A H K I T I 08-Apr-20 01:14 PM

well no

The Cap'm (Reese) 08-Apr-20 01:14 PM

well yes :v

V A H K I T I 08-Apr-20 01:14 PM

We'd basically just be moving the save call from the frontend quit button to the pause menu quit button

OH WAIT

I see what you mean

The Cap'm (Reese) 08-Apr-20 01:14 PM

it you don't trigger saving before transition it'll save FREN again

V A H K I T I 08-Apr-20 01:15 PM

I mean as long as it happens when the button is pressed, I don't see why it would transition before the save is created.

The Cap'm (Reese) 08-Apr-20 01:15 PM

just saying

V A H K I T I 08-Apr-20 01:15 PM

@ShadowDraikana Is that something you can do via the OSI?

The Cap'm (Reese) 08-Apr-20 01:26 PM

regardless I'll add the fix to the patch notes for Main

V A H K I T I 08-Apr-20 01:26 PM

aight

Sent Kay a DM btw. She can't see the pings here because warframe.

The Cap'm (Reese) 08-Apr-20 01:27 PM

oof

~~insert joke about discord overlay here~~

pr is up

ShadowDraikana 08-Apr-20 01:30 PM

yeah but i can see dm notifs just fine. because discord

The Cap'm (Reese) 08-Apr-20 01:40 PM

oof

ShadowDraikana 08-Apr-20 01:44 PM

ok so

@benji aight so it looks like in order to do what we want, gcsaver::save needs to be registered as an osi function. just need to allow for it to be called and go from there

benji 08-Apr-20 01:50 PM

sounds like you should ask @V A H K I T I to add it to BetterSaver

V A H K I T I 08-Apr-20 01:50 PM

nani

The Cap'm (Reese) 08-Apr-20 06:02 PM

And then that conversation ended.

The Cap'm (Reese) 09-Apr-20 01:08 PM

(edited)

V A H K I T I 09-Apr-20 03:15 PM

@benji I'm not exactly sure how I would go about doing that. Is that something you taught me before and I'm just having a stroke?

benji 09-Apr-20 04:49 PM

I distinctly recall walking you through adding a native function for the OSI to use

And you recorded it

V A H K I T I 09-Apr-20 05:51 PM

Well yeah, but I don't think we ever went over adding things to bettersaver

ShadowDraikana 09-Apr-20 05:53 PM

preferably we'd register the function in the osi normally but have that code stored with bettersaver because it relates to gcsaver

benji 09-Apr-20 05:58 PM

what hookmod you do it in has no effect on how you do it

V A H K I T I 09-Apr-20 06:05 PM

Hmm.. okay. I guess I'll refresh myself on that tomorrow and give it a shot

V A H K I T I 10-Apr-20 02:10 PM

Working on this now.

BetterSaver already has definitions for most if not all GcSaver things, so that helps

The Cap'm (Reese) 10-Apr-20 02:10 PM

Yeet

V A H K I T I 10-Apr-20 02:11 PM

Er.

s = MH_CreateHook(pGcSaver__Save, &BetterSaver::Save, nullptr); @benji This means it's already hooked and usable, right?

@ShadowDraikana Try calling this instead of GcSaver directly.

ShadowDraikana 10-Apr-20 02:18 PM

aight i'll work on this shortly

benji 10-Apr-20 02:43 PM

That means BetterSaver::Save will be called instead of the old GcSaver::Save. It does not let the OSI call it though.

V A H K I T I 10-Apr-20 02:43 PM

Ah..

benji 10-Apr-20 02:43 PM

Keep looking for the OSI function registering.

V A H K I T I 10-Apr-20 02:49 PM

You're sure you never registered it, or you're just having me look to check?

V A H K I T I 10-Apr-20 03:38 PM

Okay so it doesn;t look like it's registered, but I SHOULD just be able to register it the same way you did clearcinema like this, no?

Er

Changing the clearcinema call obviously

Missed that in my copy paste. :p

Hmm.. no cause that leads back to this, and I'd need to do the same thing with that. The problem is I never recorded the second half of our thing I think.

V A H K I T I 10-Apr-20 03:48 PM

Well I tried what I THINK will work, and it built, so let's see what's what then

V A H K I T I 10-Apr-20 04:19 PM

Ayyy I figured it out!

The Cap'm (Reese) 10-Apr-20 04:19 PM

Mems

V A H K I T I 10-Apr-20 04:20 PM

@ShadowDraikana I've successfully registered BetterSaver::Save as an OSI function. Tested with the Miru trigger in the test level. Every time you walk through it, the save file is updated.

You should be able to put this into the pause menu now, and we can finally wrap up the save corruption issue once and for all

Attachment: BetterSaver.dll (236.5 KB)

If all goes well on your end with this, I'll push my changes to the LOMNHook, Main, and Rebuilt repos.

Full disclosure: I really did completely forget what I was doing here, and just cludged my way through using context clues from other registered functions, so definitely test this as best you can.

FYI @benji, this is what I did if you want to tell me I did good or bad. :P

static ScOSIVariant* __cdecl OSIStub_BetterSaver_Save(ScOSIVariant* ret, LOMNHook::Util::ScOSIVirtualMachine* vm, void* param1, void* param2, void* param3, void* param4, void* param5, void* param6, void* param7, void* param8, void* param9, void* param10) { SaveDirector::ValueID id = (SaveDirector::ValueID)param1; pGcSaver__Save; SaveDirector::Save(); OutputDebugStringW(L"Save Game called via script"); // Return a null variant ret->Payload = 0; ret->TypeID = 0x0F; return ret; }

LOMNHook::Util::OSIRegisterFunction(OSIStub_BetterSaver_Save, "bettersaver", "save", 0, 0, 0xf, 0xf, 0xf, 0xf, 0xf, 0xf, 0xf, 0xf, 0xf, 0xf);

There's probably some unnecessary things in there, or maybe not. Idk. But at the moment it seems to work, so I can clean it up before pushing if necessary, but otherwise testing and implementation can commence.

benji 10-Apr-20 04:25 PM

Looks great; nice job.

V A H K I T I 10-Apr-20 04:26 PM

Thanks.

benji 10-Apr-20 04:26 PM

The id variable looks unused

V A H K I T I 10-Apr-20 04:27 PM

I'll remove it and test then

Yep, that still works fine

As I said, I was just sorta copy pasting from other functions cause I did forget the second half of your little lecture since I didn't have a chance to record it. xP

benji 10-Apr-20 04:28 PM

Also the pGcSaver__Save does nothing

If you want to call the function, you have to use parentheses after the name

But I don't think you want that line anyway

V A H K I T I 10-Apr-20 04:29 PM

That's weird, I swear I tried it with JUST the savedirector call ebfore and it didn't work. That's the only reason I dug that up

YOu are right though, I remove it too and it's fine

Guess I just did it wrong the first time.

Also, implementing this will make testing a lot easier in the future too, because not having the game save on quit from the pause menu makes it a bit of a hassle to get in and out of the same level when testing new features or changes via the test menu.

Cause unless you make a point of going through a door, or manually editing the save, anywhere you use the debug menu to teleport to doesn't get registered to the save

In retrospect I'm not sure why they tried to do it they way they did from frontend cause uh...

They REALLY should have known that writing a save when an area is loaded would register THAT area and not the previous one.

I mean they COULD have added some conditional shenanigans or just had the game store the last two area updates in memory, then had it ignore the most recent one if it returns as FREN, but this is a lot more elegant and foolproof. At least in theory. (edited)

The Cap'm (Reese) 10-Apr-20 04:53 PM

V A H K I T I 11-Apr-20 11:23 AM

AIght then

Guess I'll just uhhhhh

Do this myself

Done

The game now saves when you quit from the pause menu

V A H K I T I 11-Apr-20 11:36 AM

https://github.com/TheLegendOfMataNui/LOMN-Beta/commit/7435941aaef4bb936769f9b722185d6fc9a85f55

Save Corruption Fix · TheLegendOfMataNui/LOMN-Beta@7435941

Nopped out native code that saves game in Frontend, resulting in bad saves Update Better Saver to allow save game calls directly from the OSI Update pause screen to force save game on quit

Ondrik🅱 (Ondrej) 11-Apr-20 11:47 AM

Halleluja!

V A H K I T I 11-Apr-20 12:11 PM

Pushed also to main

I have done fairly thorough testing on my end with all of this, but all the same feel free to test further whenever it's convenient. (edited)

The Cap'm (Reese) 11-Apr-20 12:20 PM

Yeet

The Cap'm (Reese) 11-Apr-20 12:53 PM

works

though I do have to ask

are we planning on fixing the succ crash this patch

V A H K I T I 11-Apr-20 12:54 PM

The hydra?

The Cap'm (Reese) 11-Apr-20 12:54 PM

yes

V A H K I T I 11-Apr-20 12:54 PM

I mean we don't really know what's wrong with it, but if we can find out, yes

The Cap'm (Reese) 11-Apr-20 12:54 PM

if not we need to turn the crabs off

V A H K I T I 11-Apr-20 12:57 PM

Yea. Well what do we know about the issue so far?

IIRC it was an issue with the hydra not discriminating the crabs from gali

The Cap'm (Reese) 11-Apr-20 12:57 PM

Crabs=active, getting succed =crash. IIRC it has something to do with AI?

V A H K I T I 11-Apr-20 12:58 PM

I seem to recall it was an issue with collision and how the hydra is basically trying to apply its effect to EVERYONE in the level instead of just gali

Which causes the game to flip the fuck out when it does so to the crabs

The Cap'm (Reese) 11-Apr-20 12:58 PM

i don't recall that, but it's been a long time since we looked into this

V A H K I T I 11-Apr-20 01:02 PM

V A H K I T I12/02/2020 Well that was a short deep dive. It seems to be bombing just after disabling character collisions, which I assume maybe it's trying to do on a universal scale, and the crabs don't like that. I think what it's doing is trying to hit a fly with a sledgehammer. It's programmed to disable and hide EVERYTHING in the scene that isn't itself, not specifically Gali. (I think)

The Cap'm (Reese) 11-Apr-20 01:02 PM

assume

(I think)

V A H K I T I 11-Apr-20 01:03 PM

I mean y'all got any research showing anything better?

The Cap'm (Reese) 11-Apr-20 01:03 PM

No. ~~but you know what they say about assumption~~

V A H K I T I 11-Apr-20 01:07 PM

I'll look into it again now I guess

Well first thing

sweg (Andrew) 11-Apr-20 01:08 PM

holy crap no more "save game broke" reports

V A H K I T I 11-Apr-20 01:08 PM

I forgot Ash got the intro sort of working

That's neat

Second

This isn't a good sign for my theory. :p

Unless it IS still TRYING to hide the crabs but is flipping out because it can't

I remember where we left off with this now, we were working on the intro and trying to put the hydra into its idle phase for the duration of it

@ShadowDraikana Would you mind refreshing me a bit on that? What did we last leave off at with this?

ShadowDraikana 11-Apr-20 01:15 PM

we experimented with some sort of idle timer

that apparently doesnt work

we need to extend the idle state at the start to be just after the cutscene ends

V A H K I T I 11-Apr-20 01:27 PM

Are we able to force animations on bosses like we can other things?

If so, we could just do that on a timer

Hell, if we REALLY wanted to get hacky with it

We could spawn the boss AS a regular enemy, (which we already know we can do) for the duration of the cutscene, then swap it out with the actual boss after that's over

Or if the OSI already does that and just simultaneously calls code to register it as a boss, we could just have the game wait to activate its boss code

This would probably have the added advantage of not having the health bar render during the cutscene

@ShadowDraikana

ShadowDraikana 11-Apr-20 01:33 PM

We straight up cannot

I stopped reading there at the top

V A H K I T I 11-Apr-20 01:34 PM

That's bad form

ShadowDraikana 11-Apr-20 01:34 PM

Reading the rest but i wanted to get that off first

Hardcode fuckery

V A H K I T I 11-Apr-20 01:34 PM

Hence my secondary suggestions

ShadowDraikana 11-Apr-20 01:35 PM

Heres a whack idea

Rip out the init code for the taniwa

disable thw setup code in initfull and see what it does

Dont have my laptop on me atm but ill pull up the class on git or something (edited)

V A H K I T I 11-Apr-20 01:36 PM

Well I can tell you right now just commenting out the lines that call addboss and gethydraboss cause a crash

ShadowDraikana 11-Apr-20 01:37 PM

as i suspected

what does it die on

V A H K I T I 11-Apr-20 01:37 PM

let me chedk

ShadowDraikana 11-Apr-20 01:37 PM

moat likely boss fadein etc etc

V A H K I T I 11-Apr-20 01:37 PM

Either way I'm sure we can make my swap idea work, it'll just take a bit of extra code

The Cap'm (Reese) 11-Apr-20 01:37 PM

~~get it? moat? cuz it's the water boss~~

ShadowDraikana 11-Apr-20 01:38 PM

Boi

V A H K I T I 11-Apr-20 01:38 PM

Cause we've spawned bosses from hives before and without the associated code, they just act like normal enemies. Albeit stuck in their idle animations (edited)

Which IS what we want technically

So we wouldn't even need to force it

Whether we just swap out the actual entity itself after the cutscene or activate the boss code on top of it is up to how we can actually manpulate the script

If we can delay the init and just hook it onto an existing entity when it fires, that would be the ideal solution

Anyways I'll check the crash first and foremost.

GcModelDirector::Show

I'm guessing with those lines commented out, it doesn't know what to look for

Interestingly this.hydr = gchydraboss::gethydraboss(); seems to be dead.

Commenting out just that has no effect at all

At least in the start of the fight

Though it doesn't seem to come into play at the start on further examination so maybe not

ALright so here's a start

If I comment out the show line as well, I can just make the boss not render at all

So that's a good sign for the plan of delaying the init (edited)

Well that's not quite what I wanted, but it works

Loaded in the taniwa as a normal enemy using code from BLCV

The Cap'm (Reese) 11-Apr-20 01:50 PM

what's it doing

V A H K I T I 11-Apr-20 01:50 PM

I basically just told the game to load it the same way it loads the Kane-Ra. It's permanently idle, which is what all bosses do when loaded this way. It's just not loaded in the correct position.

The Cap'm (Reese) 11-Apr-20 01:50 PM

ah

ShadowDraikana 11-Apr-20 01:57 PM

Yeah because its setting the coords

Osi is

V A H K I T I 11-Apr-20 01:58 PM

Well do we know the coordinates that the actual boss is supposed to spawn in?

ShadowDraikana 11-Apr-20 01:59 PM

Check exe for those

OR

See if tweakable can be set

As a char

V A H K I T I 11-Apr-20 02:01 PM

How does that help us get the boss coordinates? :p

Also

ShadowDraikana 11-Apr-20 02:01 PM

this wouldtrigger a cam menu entry. Select char and the coords would be there

V A H K I T I 11-Apr-20 02:02 PM

gethydraboss seems to have diddly shit to do with the actual boss.

It literally just gets the entity and then sends it back off to modeldirector

Seems kinda redundant but okay

ShadowDraikana 11-Apr-20 02:03 PM

Basically like going gs lego character but without the extra code

Loading a character model for use later

V A H K I T I 11-Apr-20 02:05 PM

Hmmm

I could try something really stupid to make this work.

I could ATTEMPT to make a hookmod that makes GcHydraBoss::Delay directly accessible from the OSI.

ShadowDraikana 11-Apr-20 02:06 PM

Litestone secret technique

Actually

That

Might fuckin work but i'd have to sync it up with with when in the cutscene the delay ceases

If it even works at all

V A H K I T I 11-Apr-20 02:08 PM

Well I'll give it a shot then. I just need to brush up again on actually doing that. The Better Saver thing was easy because most of the preliminary setup of type definitions were already present.

V A H K I T I 11-Apr-20 02:48 PM

Alright

step 1 complete

I've successfully hooked the function

Now to make it OSI accessible (edited)

Currently it just hooks the function and does the exact same thing it always did

No changes except for outputting that debug string on the lower right there

Either way it's a start

The Cap'm (Reese) 11-Apr-20 02:51 PM

~~can you do boss music while you're in there~~

V A H K I T I 11-Apr-20 02:51 PM

?

The Cap'm (Reese) 11-Apr-20 02:51 PM

I kid, I know you moved that to a future patch (changing boss music)

V A H K I T I 11-Apr-20 02:51 PM

o

If this works though, I may be able to do the same to fix the vuravura's sound effects

maybe

Though that might be a bit harder given how each sound is likely associated with a different function

Quote @benji in that video I recorded for reference: "This is gonna be a pain, and I'm probably going to do most of it for now" Yep. This is probably where I lose the plot.

The Cap'm (Reese) 11-Apr-20 03:08 PM

mega oof my dude

The Cap'm (Reese) 11-Apr-20 03:16 PM

you know what I just realized

if we redo rock man's model, we'll need to redo the boss door graphic

V A H K I T I 11-Apr-20 03:34 PM

True

But that won't be too difficult.

As evidenced by the unused Vuravura door textures, they literally just overlayed a screenshot of the model over a blank door texture and added blend effects to it. :p

UTTER_BODGE 11-Apr-20 04:03 PM

y

oh

thanks keyboard

disregard y

also hello

The Cap'm (Reese) 11-Apr-20 04:03 PM

hi

V A H K I T I 11-Apr-20 04:03 PM

Hello there. :v

The Cap'm (Reese) 12-Apr-20 03:24 PM

hello there

V A H K I T I 12-Apr-20 05:11 PM

wat

Roblord 12-Apr-20 05:12 PM

Angery bat

V A H K I T I 12-Apr-20 05:16 PM

The angle makes it look like it's angrily flexing big muscular arms in Tahu's direction as a show of defiance.

@Chip 🐉🇬🇧 You know what to do.

ShadowDraikana 12-Apr-20 05:48 PM

no he's obviously asserting his dominance

The Cap'm (Reese) 12-Apr-20 06:08 PM

Btfr

Unused red bat (used in alpha)

Figured it might be more appropriate to use than bats

UTTER_BODGE 12-Apr-20 06:21 PM

oh cool

ye good use of it

The Cap'm (Reese) 12-Apr-20 06:21 PM

They were used twice in the alpha I believe, maybe more that I haven't found

By twice I mean two areas

TA12 would be the easiest place to spot them

I've been considering replacing all the bats in lev6 with btfr for a while but today I randomly decided to put them in the invasion

UTTER_BODGE 12-Apr-20 06:25 PM

I like that idea

V A H K I T I 12-Apr-20 06:25 PM

I like it

The Cap'm (Reese) 12-Apr-20 06:30 PM

Cool, guess I'll get on that later

V A H K I T I 12-Apr-20 06:35 PM

️

The Cap'm (Reese) 12-Apr-20 06:42 PM

He knows he's often dreamt Of shortening her life She's felt her hand discreetly reaching for the kitchen knife

Get a room, you're meant for each other! This is only going to go one way

The Cap'm (Reese) 12-Apr-20 10:49 PM

done

V A H K I T I 12-Apr-20 11:43 PM

beep

The Cap'm (Reese) 12-Apr-20 11:43 PM

boop

The Cap'm (Reese) 13-Apr-20 04:05 PM

all the btfrs are in if you want to see em

V A H K I T I 13-Apr-20 04:07 PM

Nice.

What's next on the current patch to-do list? I'm still hoping to get some more Ga-Wahi stuff done, but I haven't heard from Walker in a while..

Even tried DMing him just asking if he's alright but never got an answer.

The Cap'm (Reese) 13-Apr-20 04:08 PM

shite

hope he's ok

additions or bugfixes for what's next

V A H K I T I 13-Apr-20 04:10 PM

Well what are the current bugfixes we could tackle?

Maybe we can get a preliminary patch out just to get something up there for people to look forward to

The Cap'm (Reese) 13-Apr-20 04:10 PM

let's see

collection animation for the gear isn't disabled in VLLG2

V A H K I T I 13-Apr-20 04:11 PM

collection animation?

The Cap'm (Reese) 13-Apr-20 04:11 PM

yea

you know

when you collect an item and it plays an animation

the gear is underwater so that's bad

V A H K I T I 13-Apr-20 04:12 PM

Oh

Well there's code we can copy for that from Gly3

Or the area with the kaukau, I forget its identifier

The Cap'm (Reese) 13-Apr-20 04:12 PM

mwat

V A H K I T I 13-Apr-20 04:12 PM

Right

Both of those areas have underwater items with the animation disabled

I'll tackle that now

The Cap'm (Reese) 13-Apr-20 04:13 PM

there's the bettersaver (i think) issue of pickup models respawning on reentering an area

V A H K I T I 13-Apr-20 04:13 PM

@ShadowDraikana Will need to provide more information on that before I can look at it.

The Cap'm (Reese) 13-Apr-20 04:13 PM

there's the water issue that fucks BECH and GLY1/2

there's kevin

V A H K I T I 13-Apr-20 04:14 PM

THAT I don't think I can handle myself

Both of those

The Cap'm (Reese) 13-Apr-20 04:14 PM

There's TVIL not being wide enough so you can't jump over the whole thing

ShadowDraikana 13-Apr-20 04:15 PM

let me do it

just don't even touch it

like stay clear of that shit, save your sanity

V A H K I T I 13-Apr-20 04:15 PM

The water issue or kevin?

I mean

ShadowDraikana 13-Apr-20 04:15 PM

~~mine's gone, i have no sanity left to lose~~

The Cap'm (Reese) 13-Apr-20 04:15 PM

GLY3 doesn't save on exit due to using a box trigger, but that's not necessarily an issue now that quitting saves?

V A H K I T I 13-Apr-20 04:16 PM

You SAY you'll do it, but all you've been doing lately is playing warframe. Which I'm not gonna fault you for, these are hard times, but like... Don't say you're gonna do a thing and then leave us hanging, yea?

Otherwise I'm gonna take matters into my own hands regardless

~~Like I already did with the save corruption, but TO BE FAIR your internet got fugged~~

Point is somebody has to keep this project afloat. :p

The Cap'm (Reese) 13-Apr-20 04:17 PM

there's adding frames to a couple of Nokama's conversations, but if we're not gonna include MBCH in 1.1 I might just cut the text for now instead

V A H K I T I 13-Apr-20 04:18 PM

Well I'm going to continue looking into MBCH after everything else is ready.

We're just delaying it for now because it's a pain.

The Cap'm (Reese) 13-Apr-20 04:18 PM

ye

there's the VISN doors, which is lev4 not 2

V A H K I T I 13-Apr-20 04:18 PM

~~Anyways it looks like Ash is back to Warframe, so I'm just going to continue like that interjection never happened~~

One thing at a time. I'll get the collection animation disabled now

The Cap'm (Reese) 13-Apr-20 04:20 PM

k

I'm just listing stuff that can realistically be done rn

V A H K I T I 13-Apr-20 04:20 PM

Ye

The Cap'm (Reese) 13-Apr-20 04:20 PM

such as not the mudman issue that causes the melee crash

or getleaf

V A H K I T I 13-Apr-20 04:23 PM

Hmm

ShadowDraikana 13-Apr-20 04:23 PM

folds arms

The Cap'm (Reese) 13-Apr-20 04:23 PM

plays ARMS

V A H K I T I 13-Apr-20 04:24 PM

@ShadowDraikana Yes? :p

Anyways I don't see any code in gly3 or mwat that disables the pickup animation. Unless I'm just skimming over it.

The Cap'm (Reese) 13-Apr-20 04:24 PM

it should also be in BECH

ShadowDraikana 13-Apr-20 04:24 PM

that's the thing

V A H K I T I 13-Apr-20 04:24 PM

Should be or already is?

ShadowDraikana 13-Apr-20 04:24 PM

it's rigged up entirely differently

The Cap'm (Reese) 13-Apr-20 04:24 PM

is

V A H K I T I 13-Apr-20 04:24 PM

Of course it is

How is it rigged up then?

ShadowDraikana 13-Apr-20 04:25 PM

the collection is not even handled the same way

like completely

The Cap'm (Reese) 13-Apr-20 04:25 PM

we moved the gate stone there so we had to manually disable the animation

ShadowDraikana 13-Apr-20 04:25 PM

which requires setting it up as an object in a different manner

and not a collectible

The Cap'm (Reese) 13-Apr-20 04:25 PM

the decision to move the gear was a bit more abrupt so the code there wasn't put in VLLG

ShadowDraikana 13-Apr-20 04:25 PM

to create the illusion of collectibel

V A H K I T I 13-Apr-20 04:25 PM

So there is hacky code in bech to do what mtwat and gly3 do then?

ShadowDraikana 13-Apr-20 04:26 PM

then fire the saver code elsewhere to actually get the item to do the thing

yup

i just replicated it

V A H K I T I 13-Apr-20 04:26 PM

Well as long as it works that's all that really matters

The Cap'm (Reese) 13-Apr-20 04:28 PM

also

mtwat is a very good name for that area

V A H K I T I 13-Apr-20 04:29 PM

:v

@JrMasterModelBuilder Are you available? I need some info on a thing.

One of these values is (probably?) a timer float, but judging by the declarations of GcHydraBoss itself being non-existent, I'm guessing you didn't really dig too far into this function. Any idea what may be what?

Unrelated: Levels Don't Save On Transition What levels are involved with this, and does it still happen after the corruption fix?

The Cap'm (Reese) 13-Apr-20 04:33 PM

no like

level-to-level loads don't trigger GcSaver

ex. MUD0 > MTUP2

V A H K I T I 13-Apr-20 04:34 PM

Well that can be manually fixed now

Cause we can directly call BetterSaver::Save from the OSI

I'll just add a manual save call into the initfull of those areas (edited)

The Cap'm (Reese) 13-Apr-20 04:35 PM

the only level it doesn't need to trigger from is post-7 since that'd be...problematic

V A H K I T I 13-Apr-20 04:35 PM

Just a bit

:p

We don't need to save at the end of say mud0, rather at the beginning of Mtup2

The Cap'm (Reese) 13-Apr-20 04:35 PM

ye

V A H K I T I 13-Apr-20 04:35 PM

I'll just do that now. Should take all of 5 minutes

Just throw Bettersaver::Save into initfull, done

I'll have to do it 12 times for both main and rebuilt but eh

Done for mtup2, though I don't think it's necessary for that

Well not AS necessary

The Cap'm (Reese) 13-Apr-20 04:43 PM

yea

since the cutscene forces you to STRT/BECH

V A H K I T I 13-Apr-20 04:43 PM

If you quit during the cutscene it'll boot you back, but since it's no longer playable it'll save on transition to strt

Ye

I'll leave it just in case though

Cause yeah, it WILL boot you back if you quit during the cutscene for whatever reason

Better safe than sorry. It doesn't break anything to have it save there (edited)

The Cap'm (Reese) 13-Apr-20 04:44 PM

ye

V A H K I T I 13-Apr-20 04:44 PM

Literally this is all we need to do now to have the game save wherever and whenever we want

Hell we could hook this up to the checkpoints in places like Blr1/2 if we really wanted to get fancy with it

(I think)

ANyways one thing at a time

JrMasterModelBuilder 13-Apr-20 04:46 PM

It's probably one of the animation states for the Hydra.

Initially it sets an animation, than after a certain time it switches it.

V A H K I T I 13-Apr-20 04:47 PM

Yep

That's exactly what it is

What I need to know is what part of this tells it how long it should wait

Because I need to extend it

JrMasterModelBuilder 13-Apr-20 04:48 PM

dbl_760148 points to a double, for how long. (edited)

V A H K I T I 13-Apr-20 04:49 PM

.data:00760148 dbl_760148 dq 3.333333253860474 ?

See that's what I thought, but I've never successfully been able to edit those. Or if I have, it hasn't had any effect

This included

I set it to fuckin 9 and it LOOKED like it edited the actual bytes as per usual with IDA's patch program, but nothing changed

JrMasterModelBuilder 13-Apr-20 04:54 PM

9 would be 00 00 00 00 00 00 22 40

V A H K I T I 13-Apr-20 04:55 PM

Yep, I use patch program to change byte into that.

I'll load it again, but last time I did this it had no effect at all

Yep, no change

Unless doing it with the patch program in this specific case doesn't actually affect the game when ran through the debugger, Idk what's up

joint-Dogg666 13-Apr-20 04:58 PM

Have you tried opening the binary in a hex editor and making sure the bits are actually changed?

JrMasterModelBuilder 13-Apr-20 04:58 PM

You would still need to apply the patch to the EXE.

V A H K I T I 13-Apr-20 05:00 PM

Weird. Why does the patch program work like this in other instances and not here?

Is this just only something that the assemble function can do?

Cause I noticed that's not applicable for editing this section

JrMasterModelBuilder 13-Apr-20 05:01 PM

Patching code in the IDB doesn't change the file on disk.

V A H K I T I 13-Apr-20 05:02 PM

Well no, but it does function as an on-the-fly patch of sorts when run through the debugger doesn't it? I'm positive I've done that before

JrMasterModelBuilder 13-Apr-20 05:02 PM

Yes, if you are patching it in memory while the debugger is running, that would work.

V A H K I T I 13-Apr-20 05:02 PM

Then if it works you can just hit apply patches to input file

Okay so

This doesn't do anything, even through the debugger

Is my point

OH WAIT

I see what you mean

It has to actually be RUNNING first (edited)

JrMasterModelBuilder 13-Apr-20 05:03 PM

yes

V A H K I T I 13-Apr-20 05:04 PM

Alright, I'll just try applying this to the file then

Ayy it worked!

I need to tweak the time still, but that made it idle until the cutscene ended

OKAY so once I get that down, I'll have another thing for your patch program then. No hookmod needed here

JrMasterModelBuilder 13-Apr-20 05:08 PM

V A H K I T I 13-Apr-20 05:13 PM

Attachment: 2020-04-13_17-12-34.mp4 (26.13 MB)

The Cap'm (Reese) 13-Apr-20 05:14 PM

is that the only time it idles that long

or does it idle that long every time it idles

V A H K I T I 13-Apr-20 05:14 PM

Unfortunately no, it idles like that at least every time YOU die

I need to test further

The Cap'm (Reese) 13-Apr-20 05:14 PM

not what i meant

it does idle post-succ no matter what

so does it go long there

cuz if it's only every death Dave does that too

V A H K I T I 13-Apr-20 05:15 PM

It does, yes

The Cap'm (Reese) 13-Apr-20 05:16 PM

it does post-succ or it does only every death

V A H K I T I 13-Apr-20 05:16 PM

Both

However the crabs can mitigate this by keeping the action going, assuming we can fix them too

The Cap'm (Reese) 13-Apr-20 05:16 PM

oh

yeah dats no good

V A H K I T I 13-Apr-20 05:17 PM

I mean it's fine if the crabs are there, but unless we can fix them too, yeah

The Cap'm (Reese) 13-Apr-20 05:17 PM

ye

V A H K I T I 13-Apr-20 05:17 PM

It actually kind of makes the fight a bit easier and more stressful

Cause it gives you a chance to deal with the crab hordes, but also leaves you a bit anxious as to why it's just looming over you

Anyways I'm gonna continue my saver fixes for now

What is the puzzle class name for strt4?

The Cap'm (Reese) 13-Apr-20 05:20 PM

strt4_puzzle

V A H K I T I 13-Apr-20 05:20 PM

Does that not exist in main like beachpuzzle?

The Cap'm (Reese) 13-Apr-20 05:21 PM

i mean i just searched it in the scripts folder

V A H K I T I 13-Apr-20 05:22 PM

.-.

Ah in main it's just called startpuzzle

mtup5 has no puzzle class, correct?

ditto with mtup6

I think this should cover everything for main, correct?

I may just put the save calls for the others in the lego area classes here for consistency If it makes any difference

The Cap'm (Reese) 13-Apr-20 05:26 PM

should

erm

that should was to the "should cover everything for main"

V A H K I T I 13-Apr-20 05:27 PM

Ye

That's better

In all of them it's at the end of initfull

Pushed to main

And pushed to rebuilt clusterfuck

The Cap'm (Reese) 13-Apr-20 05:34 PM

yay

V A H K I T I 13-Apr-20 05:34 PM

Feel free to test

If it works we can cross that off the list

The Cap'm (Reese) 13-Apr-20 05:35 PM

make sure to add it to the main patch notes

V A H K I T I 13-Apr-20 05:35 PM

Right

The Cap'm (Reese) 13-Apr-20 05:39 PM

well there's a problem

V A H K I T I 13-Apr-20 05:39 PM

?

The Cap'm (Reese) 13-Apr-20 05:39 PM

loading into MTUP2 (testing rebuilt) kills gali

V A H K I T I 13-Apr-20 05:39 PM

Wot

The Cap'm (Reese) 13-Apr-20 05:39 PM

and that makes her invisible for the cutscene

by loading I mean loading a save into mtup2

and when she spawns into the next area you're stuck into a death loop

V A H K I T I 13-Apr-20 05:41 PM

I'm not sure how you're accomplishing this

I open up Gali's level from the test menu, quit before the cutscene plays, and when I load, I just get dropped into bech just fine

The Cap'm (Reese) 13-Apr-20 05:42 PM

I shut the game as the cutscene started

then booted the game up again and loaded my save

V A H K I T I 13-Apr-20 05:43 PM

I let the cutscene play a bit and quit.

I got loaded back into MTUP just fine though

But since the trigger is no longer there, this is a problem in and of itself

The Cap'm (Reese) 13-Apr-20 05:44 PM

Yeah I did it again

shut the game down while the cutscene is playing, reload, and gali dies upon starting

invisible during cutscene, death loop in BECH

V A H K I T I 13-Apr-20 05:44 PM

I can't replicate that at all

The Cap'm (Reese) 13-Apr-20 05:45 PM

you're alt f4ing during the scene?

V A H K I T I 13-Apr-20 05:45 PM

I mean realistically, this shouldn't be an issue since there's no legitimate way to quit the game during a cutscene, but there's always the possibility

No, I'm alt tabbing and closing rhe game

The Cap'm (Reese) 13-Apr-20 05:46 PM

I've been alt f4ing

V A H K I T I 13-Apr-20 05:46 PM

Yeah even then I can't replicate this

The worst I get is trapped in mtup

The Cap'm (Reese) 13-Apr-20 05:46 PM

okay what point exactly are you closing the game

V A H K I T I 13-Apr-20 05:47 PM

As soon as I see Onua pop up

The Cap'm (Reese) 13-Apr-20 05:47 PM

okay same wtf

V A H K I T I 13-Apr-20 05:48 PM

Okay okay there's a relatively hacky but easy fix for this

I think we can just make it NOT EVER set the cutscene as having been played

That way it'll just play it every time you enter mtup regardless

Which is the only reason the area exists

The Cap'm (Reese) 13-Apr-20 05:48 PM

ah so like what happened in mtup6 before

V A H K I T I 13-Apr-20 05:48 PM

Ye

There's no reason not to make it do that since it's the only reason you'll ever be here

I feel like we should do the same thing for MTUP 6 now tbh

Cause as it is now even if you don't purposely skip it, it'll register as having been watched

Though we'll have to block off the door BACK to mtup6 if we do that

So I'm not sure

The Cap'm (Reese) 13-Apr-20 05:50 PM

i mean why go back

there's not exactly anything in there (edited)

V A H K I T I 13-Apr-20 05:50 PM

I mean why go back to any area in this game sometimes? Just because you don't need to doesn't mean people aren't going to want to or try to

The Cap'm (Reese) 13-Apr-20 05:51 PM

fair but most areas don't have cutscenes that will fuck up if we run bettersaver

V A H K I T I 13-Apr-20 05:51 PM

:v

Well if you want to remove the trigger in fvil to mtup6, go for it

Then I'll set them both up to just play the cutscene at all times.

The Cap'm (Reese) 13-Apr-20 05:52 PM

i can get on that later

V A H K I T I 13-Apr-20 05:52 PM

AIght

The Cap'm (Reese) 13-Apr-20 05:52 PM

dinner and family time

V A H K I T I 13-Apr-20 05:56 PM

Okay NOW I'm getting the death loop and invisible gali

Hmm

Maybe I do need to put the save call in the puzzle class then

Yeah it's actually writing to the save as having 0 health

The Cap'm (Reese) 13-Apr-20 05:57 PM

and 0 energy

V A H K I T I 13-Apr-20 05:57 PM

I think I know what the issue here is

Cutscenes pause all background processes, and I think it may be saving before the game gets a chance to register all the character's information because the cutscene is set to play first

Does this happen in other areas too I wonder?

It does

Okay well that's a big issue I should have tested for before pushing but live and learn. :v

The Cap'm (Reese) 13-Apr-20 06:00 PM

~~HANGING ON THE EDGE OF TOMORROW~~

V A H K I T I 13-Apr-20 06:26 PM

Alright pushed a fix for main and rebuilt

I found that putting the save call into onevent fixes the issue

Level transition save fix fix.

Also hold off on removing the mtup6 trigger for now, cause I'd like to find a better way to handle this.

Cause for consistency we'd have to do the same thing for all the levels, and AFAIK there's no way to just test for the cutscenes having been watched in their ENTIRETY or otherwise skipped.

It'll just save it to the file regardless, and if we ignore that in other areas that you CAN return to and can't avoid returning to, it's going to get really messy really fast

The Cap'm (Reese) 13-Apr-20 06:30 PM

k

V A H K I T I 13-Apr-20 06:31 PM

Alright so that's level transitions fixed I think. Once again if it works fine, set it as done on the trello

The delay on the hydra is.. partially fixed/we can get away with calling it fixed if we can fix the crabs as well

If we know what textures the rugs in the Turaga huts are supposed to use, I can probably fix that now

IIRC Matau's hut has the proper textures, but Idk if they're the same game-wide or if those are exclusively his rugs

The Cap'm (Reese) 13-Apr-20 06:33 PM

Oh uh

V A H K I T I 13-Apr-20 06:33 PM

Not to mention it's not just rugs but pots too.

The Cap'm (Reese) 13-Apr-20 06:33 PM

He still has no door

V A H K I T I 13-Apr-20 06:33 PM

They're just not as noticeable

No door on the outside for the invasion?

The Cap'm (Reese) 13-Apr-20 06:34 PM

He still doesn't have a door blocking him before invasion clearing

Ye

V A H K I T I 13-Apr-20 06:34 PM

Hmm.. alright, I think I can handle that. Just probably gonna take a late lunch break first.

In the meantime if you could dig up the textures that the hut objects are supposed to use, I can tackle that at the same time

The Cap'm (Reese) 13-Apr-20 06:35 PM

That's called dinner, Liam.

V A H K I T I 13-Apr-20 06:35 PM

~~Shush~~ :v

The tvil bridge is an easy one too.

The Cap'm (Reese) 13-Apr-20 06:35 PM

So the rugs were the issue in the huts?

V A H K I T I 13-Apr-20 06:35 PM

I just have to shift the geometry a bit

IIRC it's all the objects

Rugs, pots, and tables

The Cap'm (Reese) 13-Apr-20 06:36 PM

Ah. And not Matau?

V A H K I T I 13-Apr-20 06:36 PM

But some huts have them textured properly

I think Matau, Vakama, and Nuju are fine

Definitely Matau at least

Oh while I'm on OSI stuff, Gly32 doesn't save?

The Cap'm (Reese) 13-Apr-20 06:37 PM

That's a trigger thing

Box triggers dont fire the saver

V A H K I T I 13-Apr-20 06:37 PM

Why is the exit door here a box trigger then?

The Cap'm (Reese) 13-Apr-20 06:37 PM

Ask Saffire.

V A H K I T I 13-Apr-20 06:37 PM

Is that just a saffire thing, or did we do that?

Ah

Is there a reason it CAN'T be a plane?

The Cap'm (Reese) 13-Apr-20 06:37 PM

No

V A H K I T I 13-Apr-20 06:38 PM

Well after dinner do you think you could tackle that one?

The Cap'm (Reese) 13-Apr-20 06:38 PM

Just haven't changed it yet

Ye probably

V A H K I T I 13-Apr-20 06:38 PM

Aight

The more bugfixes we get out of the way here and now, the more substance we have for a new main patch and the less we have to fix later with more content added on top of them

The Cap'm (Reese) 13-Apr-20 06:38 PM

I still need help getting the MBCH trigger for the falling platforms done ftr, but since we're pushing that back we can deal later

V A H K I T I 13-Apr-20 06:39 PM

If we get this, the turaga huts, and the Ta-Koro bridge done, that's a good chunk of the 1.1 bugfix list out of the way

The Cap'm (Reese) 13-Apr-20 06:39 PM

Yeah

V A H K I T I 13-Apr-20 06:39 PM

Like a lot of this is pretty simple stuff, we've just been preoccupied with not going insane from isolation

If we weren't all going mad and/or completely burned out, we'd have probably been done all of this months ago

The Cap'm (Reese) 13-Apr-20 06:40 PM

so what in here is wrong

V A H K I T I 13-Apr-20 06:40 PM

Hmm.. okay Nokama is fine

Her hut is very unique though so I'm not surprised

Whenua and Onewa are definitely borked though

Both of them have rugs made of wood, and furniture/pottery made of mossy dirt.

The rugs have a texture used in Matau's hut, but I'm not sure if that's supposed to be unique to Matau or not.

The Cap'm (Reese) 13-Apr-20 06:42 PM

yeah I'm not seeing a rug texture in the lev1 folder

V A H K I T I 13-Apr-20 06:43 PM

Well that's good in a way.

What about pottery?

Not that I expect it to have a unique texture

But dirt is definitely not the right one.

~~This isn't Minecraft~~

The Cap'm (Reese) 13-Apr-20 06:44 PM

here's what it uses in-game

V A H K I T I 13-Apr-20 06:44 PM

Ye

If you take away the vertex colours you can tell it's just dirt

And the others use stone

Judging by the texture seam near the top of the pot, I'm going to guess that's not intentional

The Cap'm (Reese) 13-Apr-20 06:46 PM

nothing specifically for pottery, but then again neither does Nokama

hers use the horn textures

V A H K I T I 13-Apr-20 06:47 PM

hmm

The Cap'm (Reese) 13-Apr-20 06:47 PM

we might be able to use an unused "window" texture here?

there's these weird "window" textures in here that don't match the onu-koro aesthetic at all

I don't know how good they'd look on the model but

V A H K I T I 13-Apr-20 06:48 PM

If it comes down to that, I say we just wait for Walker to reemerge

The pots in Onewa's hut look a lot better

The Cap'm (Reese) 13-Apr-20 06:49 PM

otherwise I'd try different stone textures until one looks good

V A H K I T I 13-Apr-20 06:49 PM

Ditto for Vakama

Though both could use some vertex colours under the rim for shading

The Cap'm (Reese) 13-Apr-20 06:51 PM

those seem to be using textures from SHRN

V A H K I T I 13-Apr-20 06:52 PM

Nuju's and Matau's also look fine

So it's pretty much just Whenua's pots, (maybe, they don't look TERRIBLE) and his and Onewa's rugs

The Cap'm (Reese) 13-Apr-20 06:52 PM

yeah

V A H K I T I 13-Apr-20 06:52 PM

The reason I question the rugs is because Matau's are just a bunch of leaves

The Cap'm (Reese) 13-Apr-20 06:53 PM

in theory for Whenua's pots we could jerry-rig the shrine textures like in Onewa's hut

V A H K I T I 13-Apr-20 06:53 PM

True

The Cap'm (Reese) 13-Apr-20 06:54 PM

these, though...

i don't think whenua keeps stone mushrooms lying around

V A H K I T I 13-Apr-20 06:55 PM

Oof

Also yeah there it is

The Cap'm (Reese) 13-Apr-20 06:55 PM

Here's a texture. Could this be passed off as a rug?

V A H K I T I 13-Apr-20 06:55 PM

The plates are made of wet dirt

:p

The Cap'm (Reese) 13-Apr-20 06:55 PM

two of these smoother stone textures

V A H K I T I 13-Apr-20 06:55 PM

Hmm.. maybe

The Cap'm (Reese) 13-Apr-20 06:56 PM

the first could be the plate texture there

smooth stone and all

V A H K I T I 13-Apr-20 06:56 PM

ye

The Cap'm (Reese) 13-Apr-20 06:56 PM

AH

the one pot in Onewa's hut uses the button texture

that was bothering me

wow these two huts are nearly identical

bizarre

right down to the stone mushrooms

V A H K I T I 13-Apr-20 07:02 PM

Not surprised

The Cap'm (Reese) 13-Apr-20 07:02 PM

Matau has them too, but the textures are kinda fucked

V A H K I T I 13-Apr-20 07:02 PM

Matau and Nuju's have the same layout

Wow never noticed that

The Cap'm (Reese) 13-Apr-20 07:02 PM

Matau's is smaller and distinct though

V A H K I T I 13-Apr-20 07:02 PM

Well the mushrooms we can fix at least

The Cap'm (Reese) 13-Apr-20 07:02 PM

Nuju has no even slight verticality and is more open

V A H K I T I 13-Apr-20 07:03 PM

Cause Vakama has those covered

The Cap'm (Reese) 13-Apr-20 07:03 PM

okay the lava mushrooms look fuckin cool

they even have moving textures

V A H K I T I 13-Apr-20 07:03 PM

Ye

The Cap'm (Reese) 13-Apr-20 07:04 PM

also why does Vakama randomly have 6 hint totems lol

so in summation:

Whenua: - Rugs (on_lev_20xx_walkway_base_1) - Pots/Plates (on_lev_20xx_shrinepattern3 & on_lev_20xx_shrine_pattern_2) / (on_lev_20xx_walkway_1) - Shrooms (on_lev_31xx_mus_1 & on_lev_31xx_mus_2) Onewa: - Rugs (PO_LEV_10XX_SAGUATEX2) - Shrooms (PO_LEV_10XX_STICKCACTII3) Matau: - Shrooms (just fix em)

(edited)

V A H K I T I 13-Apr-20 07:06 PM

Seems about right.

The Cap'm (Reese) 13-Apr-20 07:07 PM

i'll edit with texture suggestions

V A H K I T I 13-Apr-20 07:07 PM

Aight

The Cap'm (Reese) 13-Apr-20 07:14 PM

okay there

the two lev3 ones btw

random cactus textures with weird names

no mushroom textures are present in the lev3 folder so if we want a specific mushroom texture we can probably port the lev1 version

UTTER_BODGE 13-Apr-20 07:28 PM

there's these weird "window" textures in here that don't match the onu-koro aesthetic at all

canister "windows" for bech

unsure if they're used or not (edited)

but that's definitely what they are/were for

The Cap'm (Reese) 13-Apr-20 07:35 PM

GLY3 transition is fixed for rebuilt

V A H K I T I 13-Apr-20 07:35 PM

Nice

The Cap'm (Reese) 13-Apr-20 07:35 PM

if someone can shoot me a vanilla gly3 trigger file I can get it done quicker

V A H K I T I 13-Apr-20 07:35 PM

I'm gonna make that dinner I still haven't made yet.

Did you get to retest the loading stuff?

The Cap'm (Reese) 13-Apr-20 07:35 PM

since it takes a year for my laptop to switch branches

I have not, been focused on textures and this

V A H K I T I 13-Apr-20 07:36 PM

I mean yeah it does take a while to switch branches.

Just do what I do and make a duplicate local repo that's permanently on one or the other branch

I have one repo for main, and one for rebuilt

The Cap'm (Reese) 13-Apr-20 07:37 PM

gali no longer game ends upon loading into MTUP

V A H K I T I 13-Apr-20 07:37 PM

It takes ages because it's literally redownloading and/or removing files when you change branches

In the case of main vs rebuilt that uh

that's a lot of fuckin files

The Cap'm (Reese) 13-Apr-20 07:37 PM

well in that case can you shoot me the main gly3_TRIGGER.slb at your earliest convenience

UTTER_BODGE 13-Apr-20 07:38 PM

Just do what I do and make a duplicate local repo that's permanently on one or the other branch I have one repo for main, and one for rebuilt

^^^ thiiiiisss

especially helpful for when you need to directly compare them

The Cap'm (Reese) 13-Apr-20 07:38 PM

I'll keep testing the save thing in the meantime

V A H K I T I 13-Apr-20 07:38 PM

I'll send the trigger now, but I would advise doing this ASAP

The Cap'm (Reese) 13-Apr-20 07:38 PM

~~no that would require a modicum of effort~~

V A H K I T I 13-Apr-20 07:39 PM

Boi

Attachment: gly3_TRIGGER.slb (68 B)

The Cap'm (Reese) 13-Apr-20 07:50 PM

pr for the fix is now up on main

V A H K I T I 13-Apr-20 07:50 PM

Nice, I'll merge it after dinner

The Cap'm (Reese) 13-Apr-20 07:50 PM

and I guess you can ditch the other PR since you put the save corruption fix in the patch notes yourself afterwards

V A H K I T I 13-Apr-20 07:50 PM

Ye. :p

The Cap'm (Reese) 13-Apr-20 07:50 PM

~~ya mook~~

V A H K I T I 13-Apr-20 07:51 PM

~~Fite me~~

The Cap'm (Reese) 13-Apr-20 07:52 PM

~~i will~~

V A H K I T I 13-Apr-20 07:53 PM

~~What's the safe word?~~ ( ͡° ͜ʖ ͡°)

The Cap'm (Reese) 13-Apr-20 07:55 PM

well the saving works

with the exception of lev7, since you put it in ONUA and not MANA

V A H K I T I 13-Apr-20 07:56 PM

Ah right, we changed that in rebuilt

The Cap'm (Reese) 13-Apr-20 07:57 PM

this brings a question to mind (edited)

what do we want to do with lev7 this patch

V A H K I T I 13-Apr-20 07:57 PM

Fixed and pushed

Hmm.. not sure

The Cap'm (Reese) 13-Apr-20 07:58 PM

do we want to try finishing what we have now, releasing whatever we've done so far as-is with the note that it's heavy WIP (just as a teaser for what's to come, essentially), or cut everything and revert to vanilla lev7 until we get it all done?

V A H K I T I 13-Apr-20 07:59 PM

I say the former would be easiest

The Cap'm (Reese) 13-Apr-20 08:00 PM

so finish getting the Kaita functional, as well as rebuilding MANA-PST1-MAN1-KUTA (which is already mostly done)-PST2?

V A H K I T I 13-Apr-20 08:00 PM

ye

The Cap'm (Reese) 13-Apr-20 08:00 PM

okay

I'll not move anything on the trello then

V A H K I T I 13-Apr-20 08:01 PM

Finishing rebuilding the areas is optional for now as long as they work

The Cap'm (Reese) 13-Apr-20 08:01 PM

I moved ko-koro to the lev4 patch since I'm pretty sure we ent doing that for 1.1

oh one other thing we could fix

giving the lev7 toa areas proper model rendering limits

because without them, PHTU and KPKA become impossible if you load a save into lev7

V A H K I T I 13-Apr-20 08:06 PM

nani

The Cap'm (Reese) 13-Apr-20 08:06 PM

You may recall bug reports a while back about how the platform in KPKA wasn't raising

V A H K I T I 13-Apr-20 08:07 PM

I don't recall

The Cap'm (Reese) 13-Apr-20 08:08 PM

...well I was about to show you, but apparently loading into GALI is shutting my game down

V A H K I T I 13-Apr-20 08:08 PM

Any errors in releaseinform?

The Cap'm (Reese) 13-Apr-20 08:10 PM

no

[][][] lego_level_initfull [][][] init cam [][][] Life = 80 Num = 4.000000 [][][] num = 1.000000 [][][] add max energy [][][] set Energy = 80 [][][] num = 1.000000 Setting tweakable on char Setting tweakable on cam [][][] Life = 180 Num = 9.000000 [][][] num = 1.000000 [][][] add max energy [][][] add max energy [][][] add max energy [][][] add max energy [][][] add max energy [][][] set Energy = 180 [][][] num = 1.000000 [][][] AreaSetActiveNow

okay loading into ONUA works so I can show you the bug

PHTU after loading the save:

V A H K I T I 13-Apr-20 08:13 PM

.-.

The Cap'm (Reese) 13-Apr-20 08:13 PM

KPKA

the models don't render until you're close

and they don't do anything until they render

which means you can't shoot the switches

and the button on the platform in KPKA never moves from its lowered position

V A H K I T I 13-Apr-20 08:16 PM

I'll look into it later tonight

Also oof at the health multiplier

The Cap'm (Reese) 13-Apr-20 08:16 PM

yeah uh

that's gonna get worse when the Wairuha switch is put in

cuz this is only Akamai's health added to the rest

V A H K I T I 13-Apr-20 08:17 PM

.-.

The Cap'm (Reese) 13-Apr-20 08:17 PM

We really need to fix how max hp/energy is set

because as-is it's shite

see our fun trying to get Nobua's health/energy right

The Cap'm (Reese) 13-Apr-20 10:21 PM

@V A H K I T I yo how's that late lunch

V A H K I T I 13-Apr-20 10:49 PM

:v

Just taking a break. I'll probably get back o it tomorrow

The Cap'm (Reese) 13-Apr-20 10:49 PM

oof

V A H K I T I 13-Apr-20 10:49 PM

?

The Cap'm (Reese) 13-Apr-20 10:49 PM

just oof

V A H K I T I 13-Apr-20 10:49 PM

y tho

The Cap'm (Reese) 13-Apr-20 10:49 PM

nothing more, nothing less

The Cap'm (Reese) 14-Apr-20 12:43 PM

so I just realized that the description for the stone rain still mentions summoning boulders for Pohatu to kick

so I'mma change that

The Cap'm (Reese) 14-Apr-20 12:57 PM

Leena 14-Apr-20 01:21 PM

Whoa

From that angle the Kaukau looks like Tanma's mask

The Cap'm (Reese) 14-Apr-20 01:28 PM

kinda, you're right

The Cap'm (Reese) 14-Apr-20 01:35 PM

On a related note, I finally documented the items that have descriptions that run offscreen

Kakama, Mahiki, Hurricane Glyph, Hau, Volcano Glyph

V A H K I T I 14-Apr-20 03:16 PM

Okay cool

How do we fix it? I somehow doubt this game will accept a simple /n.

The Cap'm (Reese) 14-Apr-20 03:16 PM

well

There's the example of the alpha where Gali's hook had multiple lines

I don't know how that worked but it's a start

V A H K I T I 14-Apr-20 03:17 PM

@Ondrik🅱 (Ondrej) did that, correct?

The Cap'm (Reese) 14-Apr-20 03:18 PM

wut

I thought that was vanilla

V A H K I T I 14-Apr-20 03:18 PM

I remember Ondrik doing something with multi-line text, but it never turned out looking right

Why does the hook have multiple lines in alpha but not beta?

Did they change the text?

The Cap'm (Reese) 14-Apr-20 03:19 PM

yes

Ondrik🅱 (Ondrej) 14-Apr-20 03:19 PM

Yeah, I did that by adding a 0x10 iirc

The Cap'm (Reese) 14-Apr-20 03:19 PM

that's a good three sentences there

so how they do

V A H K I T I 14-Apr-20 03:21 PM

Does that wrap naturally or is it a forced line break?

The Cap'm (Reese) 14-Apr-20 03:21 PM

Hell if I know

V A H K I T I 14-Apr-20 03:21 PM

Well check the stringtable boi

The Cap'm (Reese) 14-Apr-20 03:21 PM

I don't know how that worked but it's a start

V A H K I T I 14-Apr-20 03:21 PM

:p

The Cap'm (Reese) 14-Apr-20 03:21 PM

well I'm kinda in the middle of classwork

V A H K I T I 14-Apr-20 03:21 PM

f

Well I'm not versed on the text side of things so I'll just start in on the Turaga huts

The Cap'm (Reese) 14-Apr-20 03:22 PM

there's a million things I have to do by tonight

V A H K I T I 14-Apr-20 03:22 PM

Begrudgingly I'm going to leave them as is for Main solely because there's no obvious replacement for any of these textures.

The Cap'm (Reese) 14-Apr-20 03:22 PM

ye

V A H K I T I 14-Apr-20 03:23 PM

~~That and I don't care to have to do WHenua's hut twice~~

The Cap'm (Reese) 14-Apr-20 03:25 PM

lel

V A H K I T I 14-Apr-20 11:06 PM

@JrMasterModelBuilder Are you free?

JrMasterModelBuilder 15-Apr-20 01:17 AM

@V A H K I T I For a little bit.

V A H K I T I 15-Apr-20 01:18 AM

Ah cool. I was wondering if you'd potentially be able to have a quick look into the equipment addition we want to make for 1.1. Basically the idea is to redirect GcCharacter::AddPart to pull its additional models from the character BLK rather than the area.

If it requires a hookmod so be it, but I just wanted to get your opinion on what might need to be done

Currently AddPart is never used in the game. (Aside from the test level in Rebuilt, and the split weapons testing branch) so we can pretty much do whatever with it. (edited)

The only other time it SHOULD have been used is in the alpha with the orange Nui Rama where they for some reason split the wings into a separate model. However that uses an entirely different function.

JrMasterModelBuilder 15-Apr-20 01:23 AM

It's registered as an OSI function, takes a character, a string, and an ID.

V A H K I T I 15-Apr-20 01:24 AM

Ye, that's known, we've figured out how to use it.

JrMasterModelBuilder 15-Apr-20 01:24 AM

What are you wondering about it? (edited)

V A H K I T I 15-Apr-20 01:24 AM

Ie: gccharacter::addpart(tohunga, "vlgr/it0a", 1);

The problem is it will pull it0a from the area BLK.

We don't want this, we want it to pull the part instead from the VLGR blk in this case.

That way it doesn't have to be defined in every area we put the character, or in the case of players, move to

Basically this is just saying "find a vlgr with the attached var 'tohunga', pull it0a from (insert current area BLK name here) and attach it to vlgr"

We want to just be able to define in say.. Kopaka's character setup to attach his sword, and that will just stay there unless told otherwise in a given area.

Likewise we need to be able to load the game and have it attach the part there as well

Parts added to players do persist between areas, but if you quit the game and reload, unless the area has another addpart call, it will be gone

JrMasterModelBuilder 15-Apr-20 01:33 AM

Probably because their crappy active block file system needs switching which they didn't do because they don't use it. (edited)

Take GcModelDirector::AddBoss for example.

V A H K I T I 15-Apr-20 01:34 AM

THat's not used?

JrMasterModelBuilder 15-Apr-20 01:34 AM

It does:

cur_block_file = SrGetCurBlockFile(); GcCharacter::LoadCharBlockHeader(&base_boss_1->super);

To remember the current file then switch to the character block file.

Then it does:

SrSetCurBlockFile(cur_block_file);

Later to reset.

V A H K I T I 15-Apr-20 01:35 AM

I'm not sure what effect that would have on bosses. .-.

I just know that is a function that's directly called from the OSI during boss setup and if it's not there, neither is the boss.

JrMasterModelBuilder 15-Apr-20 01:36 AM

It's how it sets the file loading system to know which block file to load from (the character block file, not the area one). (edited)

gccharacter::addpart doesn't do that.

V A H K I T I 15-Apr-20 01:37 AM

Wait so.. what you're saying is this game needs to override its own code just to read from a char file instead of an area one?

Wow you weren't kidding about this system being shit.

Okay so... I'm guessing it would take a hookmod to make it do this?

JrMasterModelBuilder 15-Apr-20 01:44 AM

yeah

V A H K I T I 15-Apr-20 01:44 AM

How would you suggest going about it?

V A H K I T I 15-Apr-20 02:32 AM

?

benji 15-Apr-20 02:38 AM

@V A H K I T I First add the hookmod that does nothing but call the original function, then once that works, we can work on opening the right block file

V A H K I T I 15-Apr-20 02:39 AM

Aight. I'll probably set that up in the morning if you're available tomorrow. It's rather late at the moment. :p

benji 15-Apr-20 02:39 AM

nah you can work on the first part without me

V A H K I T I 15-Apr-20 02:40 AM

Well yeah, that was the plan. I'm just not sure what I'd put in for the second part and when. :p

I suppose I can just do the first part now. It shouldn't be TOO difficult

I should probably do the same if we want to fix dynamic shadows. IIRC it didn't have anything in its code for removal on death or something like that

But one thing at a time I guess

V A H K I T I 15-Apr-20 02:53 AM

Yeet

I'm getting better at this. :p

benji 15-Apr-20 02:54 AM

but does the part still work?

V A H K I T I 15-Apr-20 02:54 AM

Not presently no, cause all I've done so far is made it output a debug string

I just wanted to confirm I did everything right up to this point

And it looks like I have so neet

benji 15-Apr-20 02:55 AM

nice

V A H K I T I 15-Apr-20 02:55 AM

NOW I can actually make it do shit. :p

So just to clarify: I'll need to get the declarations for GcCharacter as a whole here, yes?

benji 15-Apr-20 02:59 AM

Because you don't want to mess with anything inside a GcCharacter, you can do the struct GcCharacter; trick

V A H K I T I 15-Apr-20 02:59 AM

ooh

benji 15-Apr-20 02:59 AM

(legit computer science lingo: the trick is called declaring without defining, or forward-declaration) (edited)

V A H K I T I 15-Apr-20 03:01 AM

Neat. So from this point then I'm probably going to be a tad lost, cause I didn't get to record the part where we actually put code into this.

Unless for now I'm just copying IDA's pseudocode, but I don't think that's how it works or what we did. xP

benji 15-Apr-20 03:01 AM

no don't copy any pseudocode

V A H K I T I 15-Apr-20 03:02 AM

Thought not

benji 15-Apr-20 03:03 AM

ok I'll try to give an explanation

V A H K I T I 15-Apr-20 03:04 AM

Also I'm not sure how it'll play into this, but it doesn't seem like addpart does the actual part stuff. THat's seemingly done by GcCharacter::_PiecePair

benji 15-Apr-20 03:04 AM

we don't care how addpart works, just that we need to do some code before and after it does its thing

V A H K I T I 15-Apr-20 03:04 AM

True

benji 15-Apr-20 03:07 AM

SETP 1: To work with an existing function in the exe, you need a typedef, which creates a type by specifying the parameters and return type of the function. You can craft one like so:
typedef <return_type> (<calling_convention> *<name>)(<parameters>);

where 
   <return_type> is the type the function returns (check in IDA, int foo() has a return type of int)
   <calling_convention> is usually __cdecl for static functions (functions that are about the class as a whole, not any specific instance), and usually __fastcall or __thiscall for non-static functions. Check in IDA, int __fastcall foo() has a calling convention of __fastcall<name> can be whatever you want, but I use the convention of whatever the function name is in IDA, but with colons replaced with underscores.
   <parameters> are whatever parameters IDA shows in parentheses, with one exception: If the calling convention is __thiscall, you can turn the calling convention to __fastcall and add an extra parameter void* unused after the first parameter. (edited)

V A H K I T I 15-Apr-20 03:10 AM

I'm not too sure where I'm looking for that.

benji 15-Apr-20 03:13 AM

you're looking at the top line of the pseudocode.

V A H K I T I 15-Apr-20 03:14 AM

Ah okay

benji 15-Apr-20 03:14 AM

but you should have already at least attempted STEP 1 if you've successfully hooked the function

V A H K I T I 15-Apr-20 03:15 AM

Oh THIS you mean?

typedef void(__fastcall* GcCharacter__AddPart)(GcCharacter* _this, const struct _ScBaseString* a2, const ScIdentifier* a3); GcCharacter__AddPart tGcCharacter__AddPart; GcCharacter__AddPart pGcCharacter__AddPart = (GcCharacter__AddPart)0x00419060;

Yea, been there done that. :p

benji 15-Apr-20 03:15 AM

yep, except not quite - see the ending note about what to do if you turn the __thiscall to a __fastcall like you did

(the <parameters> section)

V A H K I T I 15-Apr-20 03:17 AM

Ah

So just replace everything after GcCHaracter*?

benji 15-Apr-20 03:18 AM

STEP 2: If you want to be able to call the original exe function after you've hooked it, declare a variable for MinHook to store the original function in, like so:
<typedef_name> <trampoline_name>;

where
   <typedef_name> is the <name> of the typedef from STEP 1
   <trampoline_name> is whatever you'd like to call the variable (I use the convention of a 't' and then the <typedef_name>) (edited)

it says add an extra parameter, not to replace anything

V A H K I T I 15-Apr-20 03:20 AM

So just like this then? (GcCharacter* _this, const struct _ScBaseString* a2, const ScIdentifier* a3, void* unused);

benji 15-Apr-20 03:20 AM

not quite, the line says

add an extra parameter void* unused after the first parameter.

(edited)

V A H K I T I 15-Apr-20 03:20 AM

Derp. Sorry, it's late and I'm not thinking to clearly at the moment. :p

benji 15-Apr-20 03:24 AM

STEP 3: To call and/or hook the exe function, you need to store the original address of the function. Declare the variable like so:
<typedef_name> <address_name> = (<typedef_name>)<address>;

where
   <typedef_name> is the <name> of the typedef from STEP 2
   <address_name> is what you want to call the variable (I use the convention of a 'p' and then the <typedef_name>)
   <address> is the address of the function (Open the IDA-View, double click the function in the functions list, and then copy the address in the left column of the IDA-View) 

V A H K I T I 15-Apr-20 03:26 AM

Yeah I have all that down

Just had to add the unused thing

I also added the thing under OnPostInit

s = MH_CreateHook(pGcCharacter__AddPart, &hGcCharacter__AddPart, (void**)&tGcCharacter__AddPart);

I pretty much have everything in up to the point of adding code into void(__fastcall hGcCharacter__AddPart)(GcCharacter* _this, const struct _ScBaseString* a2, const ScIdentifier* a3) {}

benji 15-Apr-20 03:27 AM

STEP 4: To hook the exe function, you need to have a replacement function to call. Declare (and define) the function like so:
<return_type> <calling_convention> <name>(<parameters>) {

}

where each term in angle brackets has the same value as the terms in STEP 1, except
   <name> is what you want to call the replacement function (I use 'h' + the <name> of the typedef) 

V A H K I T I 15-Apr-20 03:27 AM

Yep, that's where I am now. :v

benji 15-Apr-20 03:27 AM

I'm writing a step by step guide for you to pin

V A H K I T I 15-Apr-20 03:27 AM

Ah okay

benji 15-Apr-20 03:27 AM

so I know you've done a bit more

also so you can double check you did it right

V A H K I T I 15-Apr-20 03:28 AM

Sorry, it was just getting confusing until I realized you were just writing stuff I already did. xP

benji 15-Apr-20 03:32 AM

STEP 5: To hook the exe function, use MinHook like so:
MH_CreateHook(<pointer_name>, &<replacement_name>, <trampoline>);

where
   <pointer_name> is the <address_name> from STEP 3
   <replacement_name> is the <name> from STEP 4
   <trampoline> is (void**)&<trampoline_name> (<trampoline_name> from STEP 2) if you want a trampoline (do you want to be able to call the original function?) or nullptr if you don't

and then enable all your hooks with
MH_EnableHook(MH_ALL_HOOKS);
(edited)

STEP 6: Now write your hook in the function you defined! Common things to do include calling the original function using the trampoline (and probably return whatever it returned)

have you done all that so far?

V A H K I T I 15-Apr-20 03:35 AM

Ye. Except for writing the hook

Currently it just outputs a debug string and nothing else

BUT

I have the context to know how to call the trampoline

benji 15-Apr-20 03:36 AM

right so for your case, let's start by declaring a variable to store whatever the vanilla function gives back

V A H K I T I 15-Apr-20 03:36 AM

Cause we still have the early debug code for GcLegoCamera commented out in here

benji 15-Apr-20 03:36 AM

what type does the function you're hooking return?

(I could look but I want you to figure it out)

Check STEP 1 or 4 for a refresher on return types

V A H K I T I 15-Apr-20 03:39 AM

Void, right?

benji 15-Apr-20 03:39 AM

yep

which means it doesn't return anything so we don't need to make a variable to store nothing

so you can get right to calling the trampoline function

which is as easy as 
<trampoline_name>(<arguments>);

where
   <arguments> are the values to give the function. A common thing to do here is to give in the replacement function's parameters here (and you must do this for the void* unknown of __fastcall hooks) 

V A H K I T I 15-Apr-20 03:41 AM

So tGcCharacter__AddPart(_this, unused, a2, a3);

benji 15-Apr-20 03:41 AM

yep

V A H K I T I 15-Apr-20 03:41 AM

Yay context clues. :p

Also just to see if I could test with that, I tried building and it doesn't like my struct. I think I may have dun goofed somewhere

struct GcCharacter; is correct, yes?

Error C2371 'GcCharacter': redefinition; different basic types OptionalPatchNative C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp 284

benji 15-Apr-20 03:47 AM

ah well it looks like it might have already been done somewhere else in the file

V A H K I T I 15-Apr-20 03:47 AM

Possibly but unless I'm super blind, I couldn't find it

Then again

It wouldn't even build before if it wasn't would it?

benji 15-Apr-20 03:48 AM

Check the output window

V A H K I T I 15-Apr-20 03:48 AM

Nevermind successfully run that debug string in game

benji 15-Apr-20 03:48 AM

it should have a longer error message

look for a typedef void GcCharacter;, which was what I did when I forgot you could forward-declare them

V A H K I T I 15-Apr-20 03:49 AM

1>C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp(284,8): error C2371: 'GcCharacter': redefinition; different basic types 1>C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp(17): message : see declaration of 'GcCharacter' 1>C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp(296,108): warning C4099: 'LOMNHook::Native::_ScBaseString': type name first seen using 'class' now seen using 'struct' 1>C:\Users\sansa\source\repos\LOMNHook\LOMNHook\include\Native\_ScBaseString.h(9): message : see declaration of 'LOMNHook::Native::_ScBaseString' 1>C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp(314,20): warning C4018: '<': signed/unsigned mismatch 1>C:\Users\sansa\Source\Repos\LOMNHook\OptionalPatchNative\OptionalPatchNative.cpp(339,100): warning C4099: 'LOMNHook::Native::_ScBaseString': type name first seen using 'class' now seen using 'struct' 1>C:\Users\sansa\source\repos\LOMNHook\LOMNHook\include\Native\_ScBaseString.h(9): message : see declaration of 'LOMNHook::Native::_ScBaseString'

benji 15-Apr-20 03:49 AM

so it looks like on lines 284 and 17?

V A H K I T I 15-Apr-20 03:49 AM

Ah yep

typedef void GcCharacter;

Didn't know those two things conflicted. Now I do! :p

Which one should I remove?

benji 15-Apr-20 03:50 AM

yep both two ways of making types. Remove the typedef, it's a hack from when I forgot about forward-declaring structs

V A H K I T I 15-Apr-20 03:50 AM

Aight

benji 15-Apr-20 03:51 AM

Also it looks like GcCharacter::AddPart is used in the exe for msqt wings

I don't know what that means, but you might

V A H K I T I 15-Apr-20 03:51 AM

Well yes and no

I guess I was mistaken in the thing I told JMMB earlier if you're finding it there, but that's alpha only all the same

Essentially, the orange Nui Rama is loaded in two parts for some inexplicable reason

benji 15-Apr-20 03:52 AM

I just want to make sure we don't introduce a crash we don't know to test for

V A H K I T I 15-Apr-20 03:52 AM

BUT the beta doesn't use them, and when we re-add them, we'll be re-merging them anyways

Ye

It's super weird and Idk why they did it

The GREEN Nui Rama are loaded in one piece just fine

And they share the exact same animations save for a few additional ones that have nothing to do with the wings.

Also success btw

benji 15-Apr-20 03:55 AM

well done

V A H K I T I 15-Apr-20 03:55 AM

It builds, it outputs debug, and trampolines back to the actual EXE function to add parts

benji 15-Apr-20 03:55 AM

time to make a WIP commit, no?

V A H K I T I 15-Apr-20 03:55 AM

I suppose that would be worth doing if we don't plan on adding the blockfile code tonight

benji 15-Apr-20 03:55 AM

Next, there are some native functions that you will need to call

V A H K I T I 15-Apr-20 03:56 AM

Commit done

benji 15-Apr-20 03:58 AM

SrGetCurBlockFile SrSetCurBlockFile SrGetCurSecondBlockFile SrSetCurSecondBlockFile GcCharacter::LoadCharBlockHeader GcAreaDirector::LoadCharTexBlockHeader

that should be about it (looking at how GcCharacter::AddMask sets the blockfiles and then sets them back)

so for each of those exe functions, do steps 1 & 3 (don't turn __thiscall into __fastcall by adding void* unknown, as you don't plan on hooking these functions) 

We can talk through the rest later

Also, you probably want to pin the 6 steps

V A H K I T I 15-Apr-20 04:00 AM

Yep, will do just as soon as I do this

Okay so SrGetCurBlockFile is a struct if I'm looking at this right, so do I just set that as its type definition as per usual, or should that be added as a struct?

Ie: typedef struct ScBlockFile* __cdecl SrGetCurBlockFile(); (edited)

Or rather

typedef struct ScBlockFile*(__cdecl *SrGetCurBlockFile); SrGetCurBlockFile pSrGetCurBlockFile = (SrGetCurBlockFile)0x0054DB30;

?

benji 15-Apr-20 04:16 AM

you dont need the body of the struct because we dont plan on using anything inside the struct.

and you dont need the struct keyword in there, its a C backwards compatability thing

its what you do if you dont want to declare the struct ahead like we do

V A H K I T I 15-Apr-20 04:20 AM

Hmm.. so just struct ScBlockFile; up top, and then the typedef as typedef ScBlockFile*(__cdecl SrGetCurBlockFile);?

benji 15-Apr-20 04:20 AM

yep, but dont drop the parentheses after the typedef please

V A H K I T I 15-Apr-20 04:21 AM

Aight

benji 15-Apr-20 04:21 AM

i believe they are required even if there is nothing in them

V A H K I T I 15-Apr-20 04:25 AM

typedef void (__thiscall *GcCharacter__LoadCharBlockHeader)(GcCharacter* _this); typedef void (__cdecl *GcAreaDirector__LoadCharTexBlockHeader)(bool a1); typedef ScBlockFile*(__cdecl SrGetCurBlockFile()); typedef void __cdecl SrSetCurBlockFile(struct ScBlockFile* a1); typedef ScBlockFile*(__cdecl SrGetCurSecondBlockFile()); typedef void __cdecl SrSetCurSecondBlockFile(struct ScBlockFile* a1);

I think that's all set up right

It builds and runs without freaking out anyways

:p

THough you said to do step 3, but that's the body which you said I don't need? I'm confused about that (edited)

Unless I'm mixing up what you meant by the body of the struct

Adding these in cause I'm pretty sure I misunderstood you and it really doesn't like the parentheses here.

typedef void (__thiscall *GcCharacter__LoadCharBlockHeader)(GcCharacter* _this); GcCharacter__LoadCharBlockHeader pGcCharacter__LoadCharBlockHeader = (GcCharacter__LoadCharBlockHeader)0x00419330; typedef void (__cdecl *GcAreaDirector__LoadCharTexBlockHeader)(bool a1); GcAreaDirector__LoadCharTexBlockHeader pGcAreaDirector__LoadCharTexBlockHeader = (GcAreaDirector__LoadCharTexBlockHeader)0x0048BE30; typedef ScBlockFile*(__cdecl SrGetCurBlockFile); SrGetCurBlockFile pSrGetCurBlockFile = (SrGetCurBlockFile)0x0054DB30; typedef void (__cdecl *SrSetCurBlockFile)(struct ScBlockFile* a1); SrSetCurBlockFile pSrSetCurBlockFile = (SrSetCurBlockFile)0x0054DB20; typedef ScBlockFile*(__cdecl SrGetCurSecondBlockFile); SrGetCurSecondBlockFile pSrGetCurSecondBlockFile = (SrGetCurSecondBlockFile)0x0054DB50; typedef void (__cdecl *SrSetCurSecondBlockFile)(struct ScBlockFile* a1); SrSetCurSecondBlockFile pSrSetCurSecondBlockFile = (SrSetCurSecondBlockFile)0x0054DB40; typedef SxReferenceCountable*(__cdecl *GcModelDirector__Get)(ScIdentifier* id); GcModelDirector__Get pGcModelDirector__Get = (GcModelDirector__Get)0x00480F70;

This builds without issue,

Pinned a message.

benji 15-Apr-20 05:08 AM

typedef ScBlockFile*(__cdecl SrGetCurBlockFile);

check the format again - the parentheses follow, like so: typedef ScBlockFile*(__cdecl SrGetCurBlockFile)();

V A H K I T I 15-Apr-20 05:09 AM

Tried that too

Doesn't like it any better

benji 15-Apr-20 05:09 AM

you forgot the asterisk

V A H K I T I 15-Apr-20 05:09 AM

Ah there we go

My b

benji 15-Apr-20 05:09 AM

you want to declare a function pointer, not a funtion itself

V A H K I T I 15-Apr-20 05:10 AM

~~If it's not obvious, I still don't truly understand what it is I'm doing here~~ :p

I just know how to nod my head and follow instructions or context clues at this point. xD

Anyways that's all done I guess

The Cap'm (Reese) 15-Apr-20 02:00 PM

so today I decided, quite randomly, to try and get as many missing pictures in the Glossary filled in as possible

Through a combination of in-game screencaps and official art I've managed to get all but these filled in:

Ignalu Lava Surfing Kewa Bird Riding Ngalawa Boat Racing Rahi Turaga Ussal Crab Dig

The sports are only in the GBA game afaik and don't have arenas like Huai and Koli do in LoMN, so I'm hesitant to get a screencap of that in (unless @V A H K I T I thinks otherwise) (edited)

Rahi and Turaga seem like ensemble pictures and I'd need that rigged up separately (to be fair, if we finalize the Turaga placements in KINI I can get a screenshot of that)

Attachment: 2020-04-15_13-07-41.mp4 (7.04 MB)

--- AHA

Found a difference in how alpha and beta VLGS load the text for the hook

beta: this.hook = new lego_pickup("hook", 0, 3, "item", 1, 1); alpha: this.hook = new lego_pickup("hook", 0, 3, "item", 1, 3);

the alpha loads four lines (I assume the different value at the end there is how many strings it loads; 0-1 v.s. 0-3)

so if we have a description sentence as separate lines we can load them with proper text wrapping

this might work for text on token doors too, thinking about it (edited)

The Cap'm (Reese) 15-Apr-20 02:39 PM

YO

I DID IT

UTTER_BODGE 15-Apr-20 02:47 PM

The Cap'm (Reese) 15-Apr-20 02:54 PM

Boom

That's all of them done

...Actually, while I'm at it, the Kaukau was right on the edge of being fucky, so I'll do it as well.

UTTER_BODGE 15-Apr-20 02:56 PM

are we doing this for main too?

The Cap'm (Reese) 15-Apr-20 02:56 PM

I'd assume so

UTTER_BODGE 15-Apr-20 02:56 PM

yay

The Cap'm (Reese) 15-Apr-20 02:56 PM

I'm just on rebuilt rn for the glossary thing so I'm doing it first

UTTER_BODGE 15-Apr-20 02:57 PM

sounds good

Ondrik🅱 (Ondrej) 15-Apr-20 03:00 PM

One question

how?

ooh

The Cap'm (Reese) 15-Apr-20 03:00 PM

I explained above but

Ondrik🅱 (Ondrej) 15-Apr-20 03:00 PM

okay, with OSI

The Cap'm (Reese) 15-Apr-20 03:00 PM

ye

Ondrik🅱 (Ondrej) 15-Apr-20 03:00 PM

yeah, I just read

V A H K I T I 15-Apr-20 03:05 PM

Very nicely done Reese!

Also Re: the glossary, I'm okay with Tales of the Tohunga screencaps for the games

It WAS a companion to this game after all

The Cap'm (Reese) 15-Apr-20 03:06 PM

k

V A H K I T I 15-Apr-20 03:06 PM

As the the ensemble pics, there are those in existence for both Rahi and the Turaga

Though not in game

The Cap'm (Reese) 15-Apr-20 03:06 PM

Oh?

ah

link me those and I'll throw em in

V A H K I T I 15-Apr-20 03:06 PM

I mean most of the glossary uses the CG renders, right?

The Cap'm (Reese) 15-Apr-20 03:06 PM

ye

with some in-game screenshots as supplement

V A H K I T I 15-Apr-20 03:07 PM

Still looking for the Rahi. I may have to ask Peri about it

The Cap'm (Reese) 15-Apr-20 03:11 PM

Okay done

Text fixes pushed for rebuilt. Once the glossary's done I'll get them done for main.

UTTER_BODGE 15-Apr-20 03:14 PM

booyah

The Cap'm (Reese) 15-Apr-20 03:18 PM

@V A H K I T I Do you want me to use the GBA images for Koli and Huai as well or should I keep the LoMN field screenshots

V A H K I T I 15-Apr-20 03:18 PM

up to you

The Cap'm (Reese) 15-Apr-20 03:18 PM

Aight. ~~I'm lazy so~~ I'll keep the LoMN ones

UTTER_BODGE 15-Apr-20 03:18 PM

personally I'd opt for LoMN stuff when possible

The Cap'm (Reese) 15-Apr-20 03:20 PM

I just nabbed these from the BS01 pages btw

Ondrik🅱 (Ondrej) 15-Apr-20 03:20 PM

I'd put a the after of, but that's entirely my preference

The Cap'm (Reese) 15-Apr-20 03:21 PM

wut

UTTER_BODGE 15-Apr-20 03:21 PM

sounds fine as-is imo

Ondrik🅱 (Ondrej) 15-Apr-20 03:21 PM

instead of of Ta-Koro village, have it be of the Ta-Koro village

The Cap'm (Reese) 15-Apr-20 03:21 PM

oh

well I didn't write that

Ondrik🅱 (Ondrej) 15-Apr-20 03:21 PM

yeah

still

UTTER_BODGE 15-Apr-20 03:21 PM

people refer to cities and towns like the game does there all the time (edited)

The Cap'm (Reese) 15-Apr-20 03:22 PM

I've never seen this minigame but this screencap is...amazing.

i cannot tell what the fuck that is

Rahi is the only blank square left

Ok idea for this picture

( ͡° ͜ʖ ͡°)

1

V A H K I T I 15-Apr-20 03:26 PM

YOU KNOW WHAT

DO IT

Sethtaros 15-Apr-20 03:26 PM

Kewa Bird Riding requires masterful Kewa Bird riding.

Also that is perfect.

V A H K I T I 15-Apr-20 03:26 PM

The Cap'm (Reese) 15-Apr-20 03:28 PM

THE GLOSSARY IS COMPLETE

Ondrik🅱 (Ondrej) 15-Apr-20 03:29 PM

Y e e t!

V A H K I T I 15-Apr-20 03:29 PM

Whyyyy is it so distorted?

Ondrik🅱 (Ondrej) 15-Apr-20 03:29 PM

My guess is that it auto-resizes pictures to fit

like the flags in KSP

The Cap'm (Reese) 15-Apr-20 03:29 PM

no

V A H K I T I 15-Apr-20 03:29 PM

Actually all the others are like that too

Did.. did you think that was okay?

benji 15-Apr-20 03:29 PM

Yeah I'm not a fan of the squished

The Cap'm (Reese) 15-Apr-20 03:29 PM

The textures are a specific size

V A H K I T I 15-Apr-20 03:30 PM

Then you need to crop the images

:p

The Cap'm (Reese) 15-Apr-20 03:30 PM

in that case

V A H K I T I 15-Apr-20 03:30 PM

Also hi Benji! Imma get a coffee, but after that do ya wanna finish this addpart thing?

Also Reese, let's move this to #litestone-graphic-design

Re: AddPart, I think we can do this same thing with Passive Rahi but just in reverse, right? Here we're just cloning code from another function and making it run before handing it back to the EXE to run AddPart as normal.

For that we'd need to run the native code, then tack some code from AiDie onto the end

I haven't been this excited about LOMN stuff in a while :p

benji 15-Apr-20 03:45 PM

I'm not free at the moment

V A H K I T I 15-Apr-20 03:46 PM

Aight, any idea when you might be?

benji 15-Apr-20 03:47 PM

An hour? Maybe?

V A H K I T I 15-Apr-20 03:52 PM

sure

The Cap'm (Reese) 15-Apr-20 04:17 PM

PR is up for the text fix for main

V A H K I T I 15-Apr-20 04:17 PM

Nice. I'll finish up your glossary images first

The Cap'm (Reese) 15-Apr-20 04:18 PM

are those going in main or rebuilt only

V A H K I T I 15-Apr-20 04:18 PM

rebuilt only

The Cap'm (Reese) 15-Apr-20 04:18 PM

k

figured

but i had to ask

V A H K I T I 15-Apr-20 05:12 PM

Merged the text PR

The Cap'm (Reese) 15-Apr-20 05:15 PM

yey

V A H K I T I 15-Apr-20 05:33 PM

@JrMasterModelBuilder Another question.

This pseudocode in GcCharacter::Process is all that's needed to properly run the infected mask stuff + particle emitter, right?

GcCharacter::Animate(this_2, time, time_delta); if ( this_2->death_animation_related < dbl_6FF068 ) { if ( !this_2->evil_permanent ) ScDrawableModel::SetEvil(this_2->drawable_model_384, dword_6FF078); } else if ( !this_2->evil_permanent ) { v18 = dbl_6FF070 - this_2->death_animation_related; ScDrawableModel::SetEvil(this_2->drawable_model_384, v18); } // Move up some amount: move_up = this_2->death_animation_related * double_1_1__dbl_6FF080 * time_delta; this_2->point_536.y = move_up + this_2->point_536.y; // Create and position emitter (infected mask fountain thing): emitter = GcEmitter::Create(a2, 0x18u); emitter_z = this_2->point_536.z; emitter_y = this_2->point_536.y - double_1_0__dbl_6FF088; point.x = this_2->point_536.x; point.y = emitter_y; point.z = emitter_z; GcEmitter::Set(emitter, &point, 1, 0); v23.i = (DWORD)this_2->id_548; v80.i = '????'; v81.i = v23.i; // Is this really the right type? v24 = (GcTargetingReticle *)GcNoLightDirector::Get(&v81, &v80); anim_sprite = 0; if ( v24 ) anim_sprite = v24->anim_sprite; // Position anim sprite (injected mask): if ( anim_sprite ) GcAnimSprite::SetPosition(anim_sprite, &this_2->point_536); time_delta_2 = time_delta; this_2->death_animation_related = time_delta_2 + this_2->death_animation_related; GcCharacter::SetShadowType(this_2, 0); }

If so, is there an easy way I can call this section of the function directly?

JrMasterModelBuilder 15-Apr-20 05:38 PM

No, you can't really call a portion of a function. (edited)

V A H K I T I 15-Apr-20 05:39 PM

Hmm... would I have to make a new function out of just this code then?

JrMasterModelBuilder 15-Apr-20 05:39 PM

Well you could in theory copy that section of data into a new address space and run it.

That would work because the code is not position independent. (edited)

V A H K I T I 15-Apr-20 05:40 PM

I have no idea what that means. xP

I'm just trying to think of the easiest way to make this run, cause currently it's called from GcCharacter::Kill, but we don't want to use that function anymore.

JrMasterModelBuilder 15-Apr-20 05:40 PM

You could probably copy the bytes straight into a new binary. (edited)

V A H K I T I 15-Apr-20 05:41 PM

If we use GcCharacter::AiSetBenign, that code isn't called at all, hence our previous conundrum

What I'm thinking is to just do what I'm doing with addpart but in reverse, where we trampoline to the OG SetBenign function, then somehow tack this onto the end

Into a new binary? I'm not sure I follow

benji 15-Apr-20 05:43 PM

I'm ready for AddPart whenever @V A H K I T I

V A H K I T I 15-Apr-20 05:43 PM

Sweet

What's the next step?

benji 15-Apr-20 05:44 PM

Well, you need to change what BLK it's looking at before trampolining, and then change it back after

that's it

V A H K I T I 15-Apr-20 05:44 PM

So how do I do that? :p

benji 15-Apr-20 05:44 PM

Well, to remember the old blockfile, create a variable to hold it and then use SrGetCurBlockFile()

JrMasterModelBuilder 15-Apr-20 05:45 PM

All the instructions are in memory. If you were to have a section of memory that contain those instructions you could jump to it.

That would run that portion of code.

benji 15-Apr-20 05:45 PM

I think that might be a bit more hacky than necessary

JrMasterModelBuilder 15-Apr-20 05:45 PM

You might have to have some code at the beginning and end that makes it a complete function though. (edited)

V A H K I T I 15-Apr-20 05:45 PM

Hmm... well let's look into that after I finish addpart

One hookmod at a time. :p I was just asking ahead of time cause Benji wasn't free to continue this one yet

:p

Unless you want to try it while I work on this

JrMasterModelBuilder 15-Apr-20 05:46 PM

Also not sure if you might need to mark that section of memory executable (edited)

benji 15-Apr-20 05:47 PM

to declare a variable in C and C++, you use this format: <type> <name>;. 
The <type> of a blockfile, judging from the return type of SrGetCurBlockFile(), is ScBlockFile*, and a good <name> might be oldBlockFile 

V A H K I T I 15-Apr-20 05:47 PM

So ScBlockFile*, oldblockfile;?

benji 15-Apr-20 05:47 PM

The comma isn't part of the code

V A H K I T I 15-Apr-20 05:47 PM

ah

benji 15-Apr-20 05:48 PM

Then call SrGetCurBlockFile() and assign the value to your variable, which might look like this: oldblockfile = SrGetCurBlockFile();

V A H K I T I 15-Apr-20 05:49 PM

It doesn't like that

Error (active) E0513 a value of type "SrGetCurBlockFile" cannot be assigned to an entity of type "ScBlockFile *"

benji 15-Apr-20 05:50 PM

oh, you need to use the pointer we declared last night, which would look like pSrGetCurBlockFile()

IIRC

V A H K I T I 15-Apr-20 05:50 PM

There we go

It's okay with that

benji 15-Apr-20 05:50 PM

I am as well

V A H K I T I 15-Apr-20 05:50 PM

:p

benji 15-Apr-20 05:52 PM

Then to switch blockfiles to the one for the character that's having AddPart called on it, you use the exe's GcCharacter::LoadCharBlockHeader method, like so: pGcCharacter__LoadCharBlockHeader(_this);

V A H K I T I 15-Apr-20 05:54 PM

Alright so this is what I have so far:

void(__fastcall hGcCharacter__AddPart)(GcCharacter* _this, void* unused, const struct _ScBaseString* a2, const ScIdentifier* a3) { ScBlockFile* oldblockfile; oldblockfile = pSrGetCurBlockFile(); pGcCharacter__LoadCharBlockHeader(_this); tGcCharacter__AddPart(_this, unused, a2, a3); OutputDebugStringW(L"Attached a part! Yay!\n"); }

benji 15-Apr-20 05:54 PM

And of course after you call the old function via trampoline, you need to switch back to the original blockfile with SrSetCurBlockFile

(so that nothing else notices you messed with anything) (edited)

Next, you need to do the whole thing over for the secondary blockfile

V A H K I T I 15-Apr-20 05:57 PM

Well I'm just trying to figure out how to call pSrSetCurBlockFile now. I assume I just set the variable to that instead of pSrGetCurBlockFile, yes?

benji 15-Apr-20 05:58 PM

No, the Set version takes a parameter and doesn't return anything

so when you call it, you have to tell it what you want the current block file to be

V A H K I T I 15-Apr-20 05:58 PM

But that will never be a single predefined thing. I assume shenanigans must ensue here. :p (edited)

benji 15-Apr-20 05:59 PM

what do you mean - we stored the blockfile to use in the variable as the first and second steps

V A H K I T I 15-Apr-20 05:59 PM

Oh okay, I see

benji 15-Apr-20 05:59 PM

For the secondary blockfile:
 - Create a variable for it
 - Get it using SrGetCurSecondBlockFile()
 - Set it using GcAreaDirector::LoadCharTexBlockHeader(1);
, and after trampolining,
 - set the secondary blockfile back to what it originally was, using SrSetCurSecondBlockFile 

V A H K I T I 15-Apr-20 06:01 PM

Well I'm still on the end of first one now. Do I just put it down as pSrSetCurBlockFile (oldblockfile);?

~~I always feel stupid when I'm doing this cause it's so obvious I don't really understand what I'm doing.~~ >->

benji 15-Apr-20 06:02 PM

yep, without the space

V A H K I T I 15-Apr-20 06:02 PM

~~Oh shit I did a thing right~~

benji 15-Apr-20 06:03 PM

nah I'm TA-ing first-year computer science classes, helping with homework and stuff, and you fit right in

V A H K I T I 15-Apr-20 06:04 PM

Fair enough. :p

Okay so for the secondary blockfile, I should position that code in the same places around the trampoline that I did for the current blockfile, or just put it all before or after?

benji 15-Apr-20 06:06 PM

same thing as before - some of it goes before the trampoline, and some of it after

V A H K I T I 15-Apr-20 06:08 PM

void(__fastcall hGcCharacter__AddPart)(GcCharacter* _this, void* unused, const struct _ScBaseString* a2, const ScIdentifier* a3) { //Here we get the current character blockfile ScBlockFile* oldblockfile; ScBlockFile* newblockfile; oldblockfile = pSrGetCurBlockFile(); newblockfile = pSrGetCurSecondBlockFile(); pGcCharacter__LoadCharBlockHeader(_this); pGcAreaDirector__LoadCharTexBlockHeader(1); //Trampoline back to native function tGcCharacter__AddPart(_this, unused, a2, a3); //Reset back to original current blockfile pSrSetCurBlockFile(oldblockfile); pSrSetCurSecondBlockFile(newblockfile); OutputDebugStringW(L"Attached a part! Yay!\n"); }

Like that?

benji 15-Apr-20 06:09 PM

looks, good, except the name newblockfile is misleading - it's the old secondary blockfile

V A H K I T I 15-Apr-20 06:10 PM

Ah okay

benji 15-Apr-20 06:11 PM

For reference, this code sets the main blockfile to Root/Data/Characters/%.4s.blk, where %.4s is the character ID

V A H K I T I 15-Apr-20 06:12 PM

It works!

benji 15-Apr-20 06:12 PM

And it sets the secondary blockfile to Root/Data/Characters/textures.blk

V A H K I T I 15-Apr-20 06:12 PM

@ShadowDraikana @The Cap'm (Reese) Equipment is GO!

benji 15-Apr-20 06:12 PM

nice. You're practically a programmer now.

V A H K I T I 15-Apr-20 06:13 PM

Well if I am I'm not a very good one. xP

But thank you for the praise

I just need to move the textures for the spear of fusion now, cause it's not looking in the level foldder anymore

UTTER_BODGE 15-Apr-20 06:13 PM

\o/

ShadowDraikana 15-Apr-20 06:13 PM

~~must be nice~~

V A H K I T I 15-Apr-20 06:14 PM

Okay so NOW I can really go ham on the splitweaponstesting branch

benji 15-Apr-20 06:14 PM

Did you commit?

V A H K I T I 15-Apr-20 06:14 PM

Right I should do that

:p

Done

ShadowDraikana 15-Apr-20 06:15 PM

make sure this gets actually added properly as far as the hookmods into the main repo go

benji 15-Apr-20 06:15 PM

Aight I've done my work, I'm out

V A H K I T I 15-Apr-20 06:15 PM

Thanks Benji, you're a lifesaver. :p

Also Ash, I've pinned Benji's 6 step guide here to making a basic mod.

ShadowDraikana 15-Apr-20 06:16 PM

~~but motivation~~

V A H K I T I 15-Apr-20 06:16 PM

:v

ShadowDraikana 15-Apr-20 06:16 PM

Also

For the love of god make sure we keep the conflicts on that branch to a bare minimum

V A H K I T I 15-Apr-20 06:17 PM

WHich, initial-hookmod-api, or split-weapons-testing?

ShadowDraikana 15-Apr-20 06:17 PM

weapon testing

V A H K I T I 15-Apr-20 06:18 PM

Aight. At this point I'm probably just gonna delete it and redo the code on clusterfuck

Cause if I've set this up right, I can just have the weapon set up in the toa class and add/remove the new ones only where necessary

Ie Removepart from hand, addpart to back in vllg, the reverse of that in each area directly accessible from vllg.

Alright so a good place to start with this would be to add the sashes, disks and spears to village guards

They're already defined in the code so we just need to throw in the models, put in an addpart call, and call it a day

I'll start in on that now

The Cap'm (Reese) 15-Apr-20 06:27 PM

yeet

V A H K I T I 15-Apr-20 06:27 PM

Can you do me a favour if you know how?

The Cap'm (Reese) 15-Apr-20 06:28 PM

m-m-m-meeeeeeee?

V A H K I T I 15-Apr-20 06:28 PM

Yes.

The Cap'm (Reese) 15-Apr-20 06:28 PM

no

V A H K I T I 15-Apr-20 06:28 PM

I need an index of all the villagers stationed as guards. Ie: if a guard is say.. VL04, I need that written somewhere.

The Cap'm (Reese) 15-Apr-20 06:28 PM

no clue

I can try looking into it

V A H K I T I 15-Apr-20 06:29 PM

@ShadowDraikana You set them up initially. I don't suppose you kept track of who was who? :p

The Cap'm (Reese) 15-Apr-20 06:30 PM

well if you know the model ID of the Kaukau I can tell you one of the onu-koro ones right quick probably

V A H K I T I 15-Apr-20 06:30 PM

Well at the very least, the vllgX_puzzle classes tell us what mask they all wear, so that can help in creating our little Mata Nui census here.

Yeah that

ShadowDraikana 15-Apr-20 06:30 PM

check mask ids to narrow things down

Actually

V A H K I T I 15-Apr-20 06:31 PM

Kaukau is mk1a

ShadowDraikana 15-Apr-20 06:31 PM

convo slb reveals.this.immediately

The Cap'm (Reese) 15-Apr-20 06:31 PM

oh yeah

that'd probably be a better way of figuring it out

ShadowDraikana 15-Apr-20 06:31 PM

chdck for drug group

V A H K I T I 15-Apr-20 06:31 PM

Sweet

LOL

I'll get started on adding the models while you two do that then

ShadowDraikana 15-Apr-20 06:32 PM

excuse me what

V A H K I T I 15-Apr-20 06:33 PM

?

I'm setting up the equipment for guards.

I need help knowing who the guards are, but I also need to set up the models for them

The Cap'm (Reese) 15-Apr-20 06:33 PM

I'll start with lev4-6 if you wanna sweep through 1-3

V A H K I T I 15-Apr-20 06:34 PM

Me or Ash?

The Cap'm (Reese) 15-Apr-20 06:34 PM

Whoever, IDK

My point is that i'm starting with 4

V A H K I T I 15-Apr-20 06:34 PM

If Ash can't do it, I will. I was just hoping to get the rest of the shit set up at the same time is all. :p

ShadowDraikana 15-Apr-20 06:34 PM

fucking fine let me get ids

Ill do all of them if you want

V A H K I T I 15-Apr-20 06:35 PM

I mean if you don't want to do it, it's fine. :v

We can handle it

I was just asking you guys to do it so we could maximize our time usage

For that matter we also need to decide who gets equipment aside from guards, if anyone

The Cap'm (Reese) 15-Apr-20 06:36 PM

lev4 is vl08-vl11

V A H K I T I 15-Apr-20 06:36 PM

Btw, I already have a functional model for the disk sash, so that's good to go. I just need a spear next.

I'll probably model it after the MNOG tridents

The Cap'm (Reese) 15-Apr-20 06:37 PM

how much weapon variation we doin

V A H K I T I 15-Apr-20 06:37 PM

¯\_(ツ)_/¯

The Cap'm (Reese) 15-Apr-20 06:37 PM

is each village getting a unique one

ShadowDraikana 15-Apr-20 06:37 PM

just give them pitchforks

problem solved

V A H K I T I 15-Apr-20 06:37 PM

I think we could do SOME variation.

Cause in MNOG, Ga-Matoran specifically use staffs

ShadowDraikana 15-Apr-20 06:39 PM

disappointed in the lack of pitchforks

The Cap'm (Reese) 15-Apr-20 06:39 PM

lev5 is vlgr, vl12, vl13

ShadowDraikana 15-Apr-20 06:39 PM

youre welcome for that weird id grouping lol

i know exactly how that happened tho

Just Ash Things™️

The Cap'm (Reese) 15-Apr-20 06:40 PM

lev6 is vl11 and vl12, but I assume there'll probably have to be more there

V A H K I T I 15-Apr-20 06:40 PM

In MNOG the Onu-Matoran are only holding disks, but in Tales of the Tohunga they have SOME kind of spear

But it's just like a black streak of pixels, so I can't tell what it really is

The Cap'm (Reese) 15-Apr-20 06:41 PM

lev1 is vl11-vl15

V A H K I T I 15-Apr-20 06:41 PM

Ironically Ko-Matoran hold pickaxes.

IIRC Le-Matoran specifically use disks

So we can definitely do some variation here

joint-Dogg666 15-Apr-20 06:43 PM

There's only one "guard" sprite for Tales of the Tohunga

The Cap'm (Reese) 15-Apr-20 06:43 PM

lev2 is vl04, vl05, vl06, and vl16

and lev3 is vl03, vl11-13

got all those @V A H K I T I ?

V A H K I T I 15-Apr-20 06:49 PM

Ye, thank

Hmm

Plugging this in doesn't seem to be working

gccharacter::addpart(var1, "vl11/sash", 1); gccharacter::addpart(var1, "vl12/sash", 1); gccharacter::addpart(var1, "vl13/sash", 1); gccharacter::addpart(var1, "vl14/sash", 1); gccharacter::addpart(var1, "vl15/sash", 1);

Var1 is set in the settohunga code

Ie: var1 = gcmodeldirector::getcharacter(scslosifoundation::stringtoidentifier("vl15"), 0);

So this SHOULD be working...

The Cap'm (Reese) 15-Apr-20 06:53 PM

this is lev1 yes

Attachment: vllg_CONV.xml (35.6 KB)

V A H K I T I 15-Apr-20 06:54 PM

It is yes

Okay I think I beefed something somewhere cause now the test level is crashing

stand by

The Cap'm (Reese) 15-Apr-20 06:54 PM

oof

V A H K I T I 15-Apr-20 06:57 PM

Yep, am dum

Forgot to delete the vlgr blk after renaming the items

Cause it won't rebuild if the last modified date hasn't changed

The Cap'm (Reese) 15-Apr-20 06:57 PM

you fool

V A H K I T I 15-Apr-20 06:58 PM

Well now we just have a new problem. Nothing we can't fix, but may complicate things.

The Cap'm (Reese) 15-Apr-20 06:59 PM

?

V A H K I T I 15-Apr-20 06:59 PM

Because settohunga is constantly changing the value of var1, only one of the guards ends up getting the equipment. I MAY be able to fix this my moving my addpart calls into each of the settohunga calls, but we'll see

The Cap'm (Reese) 15-Apr-20 07:00 PM

V A H K I T I 15-Apr-20 07:01 PM

There we go

Yep, that fixed it

We just need to spread out the addpart calls so they're all called in sequence while var1 is still set as the same value as the tohunga being added to

The Cap'm (Reese) 15-Apr-20 07:01 PM

ah

V A H K I T I 15-Apr-20 07:02 PM

So now all the Onu-Koro guarsa have disks.

The Cap'm (Reese) 15-Apr-20 07:02 PM

are the sashes supposed to be white btw

V A H K I T I 15-Apr-20 07:02 PM

No, that was just for testing. We may have to decide on a set colour for them unless we want another hookmod to dynamically colour them using settohunga

The Cap'm (Reese) 15-Apr-20 07:02 PM

ah

i think having a set color would be fine

V A H K I T I 15-Apr-20 07:03 PM

Onu-Koro and Ta-Koro both use black, so I think we'll go with that

The Cap'm (Reese) 15-Apr-20 07:03 PM

yeet

so we going all in on this for 1.1? Guard equipment, weapon holstering, shield surfing?

V A H K I T I 15-Apr-20 07:06 PM

At the very least we can do the tohunga equipment

I'm going to make the different weapons today so we can implement them right away

Also this ties into the "add quest items to village" addition (edited)

The Cap'm (Reese) 15-Apr-20 07:07 PM

yea

V A H K I T I 15-Apr-20 07:07 PM

Since I can now make Taipu hold the pick, the Le-matoran hold the volo-lutu launcher, etc

The Cap'm (Reese) 15-Apr-20 07:07 PM

yea

ShadowDraikana 15-Apr-20 07:07 PM

Was going to point out the var thing but you got it. A little confused but you got the spirit